LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay"
@ 2021-08-18 20:44 Krzysztof Kozlowski
       [not found] ` <162938788185.467628.13192922419725983504.b4-ty@arndb.de>
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-08-18 20:44 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, arm, soc
  Cc: Jason Wang, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	Krzysztof Kozlowski

From: Jason Wang <wangborong@cdjrlc.com>

"delay" variable on line 79 can be deleted by returning "0" on line 88.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Link: https://lore.kernel.org/r/20210624055627.22295-1-wangborong@cdjrlc.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---

Hi Arnd and Olof,

I have just one patch for Samsung ARM mach/soc, so sending this
directly.

Best regards,
Krzysztof


 arch/arm/mach-s3c/mach-gta02.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-s3c/mach-gta02.c b/arch/arm/mach-s3c/mach-gta02.c
index aec8b451c016..418939ce0fc3 100644
--- a/arch/arm/mach-s3c/mach-gta02.c
+++ b/arch/arm/mach-s3c/mach-gta02.c
@@ -79,13 +79,12 @@ static struct pcf50633 *gta02_pcf;
 
 static long gta02_panic_blink(int state)
 {
-	long delay = 0;
 	char led;
 
 	led = (state) ? 1 : 0;
 	gpio_direction_output(GTA02_GPIO_AUX_LED, led);
 
-	return delay;
+	return 0;
 }
 
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay"
       [not found] ` <162938788185.467628.13192922419725983504.b4-ty@arndb.de>
@ 2021-08-19 21:40   ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2021-08-19 21:40 UTC (permalink / raw)
  To: arm-soc, SoC Team, Krzysztof Kozlowski, Olof Johansson
  Cc: Arnd Bergmann, Linux Kernel Mailing List, Jason Wang,
	moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, Linux ARM

On Thu, Aug 19, 2021 at 5:44 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> On Wed, 18 Aug 2021 22:44:22 +0200, Krzysztof Kozlowski wrote:
> > "delay" variable on line 79 can be deleted by returning "0" on line 88.
>
> Applied to for-next, thanks!
>
> [1/1] ARM: s3c: delete unneed local variable "delay"
>       commit: 319a1b58f6c7432345f13383b26c8c10e7eb1dda

I had accidentally added this to the arm/fixes branch at first, but corrected
that now and applied it to arm/soc instead, as you intended.

          Arnd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-19 21:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 20:44 [PATCH][PULL/direct] ARM: s3c: delete unneed local variable "delay" Krzysztof Kozlowski
     [not found] ` <162938788185.467628.13192922419725983504.b4-ty@arndb.de>
2021-08-19 21:40   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).