LKML Archive on
help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <>
To: Konstantin Komarov <>
	"Gustavo A. R. Silva" <>,
Subject: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang
Date: Wed, 18 Aug 2021 17:21:46 -0500	[thread overview]
Message-ID: <20210818222146.GA312859@embeddedor> (raw)

Fix the following fallthrough warnings:

fs/ntfs3/inode.c:1792:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
fs/ntfs3/index.c:178:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

This helps with the ongoing efforts to globally enable
-Wimplicit-fallthrough for Clang.

Signed-off-by: Gustavo A. R. Silva <>
 fs/ntfs3/index.c | 1 +
 fs/ntfs3/inode.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index 6aa9540ece47..76eae60b7fce 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -175,6 +175,7 @@ static inline NTFS_CMP_FUNC get_cmp_func(const struct INDEX_ROOT *root)
+		break;
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index bf51e294432e..a573c6e98cb8 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -1789,6 +1789,7 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
 	switch (err) {
 	case 0:
+		break;
 	case -ENOTEMPTY:
 	case -ENOSPC:
 	case -EROFS:

             reply	other threads:[~2021-08-18 22:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 22:21 Gustavo A. R. Silva [this message]
2021-08-18 23:29 ` Nathan Chancellor
2021-08-27 16:26 ` Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818222146.GA312859@embeddedor \ \ \ \ \ \
    --subject='Re: [PATCH][next] fs/ntfs3: Fix fall-through warnings for Clang' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).