LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule
@ 2021-08-19  1:23 Masahiro Yamada
  2021-08-24  3:05 ` Martin K. Petersen
  2021-08-28  2:32 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2021-08-19  1:23 UTC (permalink / raw)
  To: linux-scsi
  Cc: Masahiro Yamada, James E.J. Bottomley, Martin K. Petersen, linux-kernel

Add FORCE so that if_changed can detect the command line change.
scsi_devinfo_tbl.c must be added to 'targets' too.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/scsi/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 1748d1ec1338..77812ba3c4aa 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -183,7 +183,7 @@ CFLAGS_ncr53c8xx.o	:= $(ncr53c8xx-flags-y) $(ncr53c8xx-flags-m)
 zalon7xx-objs	:= zalon.o ncr53c8xx.o
 
 # Files generated that shall be removed upon make clean
-clean-files :=	53c700_d.h 53c700_u.h scsi_devinfo_tbl.c
+clean-files :=	53c700_d.h 53c700_u.h
 
 $(obj)/53c700.o: $(obj)/53c700_d.h
 
@@ -192,9 +192,11 @@ $(obj)/scsi_sysfs.o: $(obj)/scsi_devinfo_tbl.c
 quiet_cmd_bflags = GEN     $@
 	cmd_bflags = sed -n 's/.*define *BLIST_\([A-Z0-9_]*\) *.*/BLIST_FLAG_NAME(\1),/p' $< > $@
 
-$(obj)/scsi_devinfo_tbl.c: include/scsi/scsi_devinfo.h
+$(obj)/scsi_devinfo_tbl.c: include/scsi/scsi_devinfo.h FORCE
 	$(call if_changed,bflags)
 
+targets +=  scsi_devinfo_tbl.c
+
 # If you want to play with the firmware, uncomment
 # GENERATE_FIRMWARE := 1
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule
  2021-08-19  1:23 [PATCH] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule Masahiro Yamada
@ 2021-08-24  3:05 ` Martin K. Petersen
  2021-08-28  2:32 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-08-24  3:05 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-scsi, James E.J. Bottomley, Martin K. Petersen, linux-kernel


Masahiro,

> Add FORCE so that if_changed can detect the command line change.
> scsi_devinfo_tbl.c must be added to 'targets' too.

Applied to 5.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule
  2021-08-19  1:23 [PATCH] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule Masahiro Yamada
  2021-08-24  3:05 ` Martin K. Petersen
@ 2021-08-28  2:32 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-08-28  2:32 UTC (permalink / raw)
  To: linux-scsi, Masahiro Yamada
  Cc: Martin K . Petersen, James E.J. Bottomley, linux-kernel

On Thu, 19 Aug 2021 10:23:39 +0900, Masahiro Yamada wrote:

> Add FORCE so that if_changed can detect the command line change.
> scsi_devinfo_tbl.c must be added to 'targets' too.
> 
> 
> 
> 

Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule
      https://git.kernel.org/mkp/scsi/c/98079418c53f

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-28  2:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19  1:23 [PATCH] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule Masahiro Yamada
2021-08-24  3:05 ` Martin K. Petersen
2021-08-28  2:32 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).