LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding
@ 2021-08-19  5:52 George Liu
  2021-09-14  8:15 ` George Liu
  0 siblings, 1 reply; 4+ messages in thread
From: George Liu @ 2021-08-19  5:52 UTC (permalink / raw)
  To: joel, openbmc; +Cc: linux-aspeed, linux-kernel, robh+dt, George Liu

Signed-off-by: George Liu <liuxiwei@inspur.com>
---
 arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
index 1752f3250e44..d0c3acbf6c8c 100644
--- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
@@ -3,6 +3,7 @@
 #include "aspeed-g5.dtsi"
 #include <dt-bindings/gpio/aspeed-gpio.h>
 #include <dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
 	model = "FP5280G2 BMC";
@@ -902,4 +903,10 @@ fan@7 {
 
 };
 
+&kcs3 {
+	status = "okay";
+	aspeed,lpc-io-reg = <0xca2>;
+	aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+};
+
 #include "ibm-power9-dual.dtsi"
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding
  2021-08-19  5:52 [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding George Liu
@ 2021-09-14  8:15 ` George Liu
  2021-09-14  8:45   ` Joel Stanley
  0 siblings, 1 reply; 4+ messages in thread
From: George Liu @ 2021-09-14  8:15 UTC (permalink / raw)
  To: joel, OpenBMC Maillist; +Cc: linux-aspeed, linux-kernel, robh+dt, George Liu

Hey Joel:
do you have any comments at this patch?

Thx -- George Liu

On Thu, Aug 19, 2021 at 1:52 PM George Liu <liuxiwei1013@gmail.com> wrote:
>
> Signed-off-by: George Liu <liuxiwei@inspur.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> index 1752f3250e44..d0c3acbf6c8c 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> @@ -3,6 +3,7 @@
>  #include "aspeed-g5.dtsi"
>  #include <dt-bindings/gpio/aspeed-gpio.h>
>  #include <dt-bindings/leds/leds-pca955x.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
>
>  / {
>         model = "FP5280G2 BMC";
> @@ -902,4 +903,10 @@ fan@7 {
>
>  };
>
> +&kcs3 {
> +       status = "okay";
> +       aspeed,lpc-io-reg = <0xca2>;
> +       aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> +};
> +
>  #include "ibm-power9-dual.dtsi"
> --
> 2.30.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding
  2021-09-14  8:15 ` George Liu
@ 2021-09-14  8:45   ` Joel Stanley
  2021-09-14  8:55     ` George Liu
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2021-09-14  8:45 UTC (permalink / raw)
  To: George Liu
  Cc: OpenBMC Maillist, linux-aspeed, Linux Kernel Mailing List,
	Rob Herring, George Liu

On Tue, 14 Sept 2021 at 08:16, George Liu <liuxiwei1013@gmail.com> wrote:
>
> Hey Joel:
> do you have any comments at this patch?
>
> Thx -- George Liu
>
> On Thu, Aug 19, 2021 at 1:52 PM George Liu <liuxiwei1013@gmail.com> wrote:
> >
> > Signed-off-by: George Liu <liuxiwei@inspur.com>

It looks okay to me.

Reviewed-by: Joel Stanley <joel@jms.id.au>

I have applied it for 5.16.

> > ---
> >  arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > index 1752f3250e44..d0c3acbf6c8c 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > @@ -3,6 +3,7 @@
> >  #include "aspeed-g5.dtsi"
> >  #include <dt-bindings/gpio/aspeed-gpio.h>
> >  #include <dt-bindings/leds/leds-pca955x.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> >
> >  / {
> >         model = "FP5280G2 BMC";
> > @@ -902,4 +903,10 @@ fan@7 {
> >
> >  };
> >
> > +&kcs3 {
> > +       status = "okay";
> > +       aspeed,lpc-io-reg = <0xca2>;
> > +       aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> > +};
> > +
> >  #include "ibm-power9-dual.dtsi"
> > --
> > 2.30.2
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding
  2021-09-14  8:45   ` Joel Stanley
@ 2021-09-14  8:55     ` George Liu
  0 siblings, 0 replies; 4+ messages in thread
From: George Liu @ 2021-09-14  8:55 UTC (permalink / raw)
  To: Joel Stanley
  Cc: OpenBMC Maillist, linux-aspeed, Linux Kernel Mailing List,
	Rob Herring, George Liu

Thanks!

On Tue, Sep 14, 2021 at 4:45 PM Joel Stanley <joel@jms.id.au> wrote:
>
> On Tue, 14 Sept 2021 at 08:16, George Liu <liuxiwei1013@gmail.com> wrote:
> >
> > Hey Joel:
> > do you have any comments at this patch?
> >
> > Thx -- George Liu
> >
> > On Thu, Aug 19, 2021 at 1:52 PM George Liu <liuxiwei1013@gmail.com> wrote:
> > >
> > > Signed-off-by: George Liu <liuxiwei@inspur.com>
>
> It looks okay to me.
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> I have applied it for 5.16.
>
> > > ---
> > >  arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > > index 1752f3250e44..d0c3acbf6c8c 100644
> > > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > > @@ -3,6 +3,7 @@
> > >  #include "aspeed-g5.dtsi"
> > >  #include <dt-bindings/gpio/aspeed-gpio.h>
> > >  #include <dt-bindings/leds/leds-pca955x.h>
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > >
> > >  / {
> > >         model = "FP5280G2 BMC";
> > > @@ -902,4 +903,10 @@ fan@7 {
> > >
> > >  };
> > >
> > > +&kcs3 {
> > > +       status = "okay";
> > > +       aspeed,lpc-io-reg = <0xca2>;
> > > +       aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> > > +};
> > > +
> > >  #include "ibm-power9-dual.dtsi"
> > > --
> > > 2.30.2
> > >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-14  8:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19  5:52 [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding George Liu
2021-09-14  8:15 ` George Liu
2021-09-14  8:45   ` Joel Stanley
2021-09-14  8:55     ` George Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).