LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: build warning after merge of the dma-mapping tree
@ 2021-08-18 22:54 Stephen Rothwell
  2021-08-19  7:02 ` Christoph Hellwig
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-08-18 22:54 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

kernel/dma/coherent.c:325:29: warning: 'dma_reserved_default_memory' defined but not used [-Wunused-variable]
  325 | static struct reserved_mem *dma_reserved_default_memory __initdata;
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  b7987aff1d0c ("dma-mapping: make the global coherent pool conditional")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: build warning after merge of the dma-mapping tree
  2021-08-18 22:54 linux-next: build warning after merge of the dma-mapping tree Stephen Rothwell
@ 2021-08-19  7:02 ` Christoph Hellwig
  0 siblings, 0 replies; 11+ messages in thread
From: Christoph Hellwig @ 2021-08-19  7:02 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux Kernel Mailing List, Linux Next Mailing List

Thanks,

fixed.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: build warning after merge of the dma-mapping tree
  2021-09-03  6:45 ` Stephen Rothwell
@ 2021-09-06 12:41   ` Christoph Hellwig
  0 siblings, 0 replies; 11+ messages in thread
From: Christoph Hellwig @ 2021-09-06 12:41 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Logan Gunthorpe, Linux Kernel Mailing List,
	Linux Next Mailing List

Thanks,

I've commited a fix.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: build warning after merge of the dma-mapping tree
  2021-08-13  7:11 Stephen Rothwell
@ 2021-09-03  6:45 ` Stephen Rothwell
  2021-09-06 12:41   ` Christoph Hellwig
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-09-03  6:45 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Logan Gunthorpe, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

On Fri, 13 Aug 2021 17:11:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the dma-mapping tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> kernel/dma/mapping.c:224: warning: Function parameter or member 'nents' not described in 'dma_map_sg_attrs'
> 
> Caused by commit
> 
>   fffe3cc8c219 ("dma-mapping: allow map_sg() ops to return negative error codes")

I am still getting this warning.


-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: build warning after merge of the dma-mapping tree
@ 2021-08-13  7:11 Stephen Rothwell
  2021-09-03  6:45 ` Stephen Rothwell
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-08-13  7:11 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Logan Gunthorpe, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (htmldocs)
produced this warning:

kernel/dma/mapping.c:224: warning: Function parameter or member 'nents' not described in 'dma_map_sg_attrs'

Caused by commit

  fffe3cc8c219 ("dma-mapping: allow map_sg() ops to return negative error codes")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: build warning after merge of the dma-mapping tree
  2020-09-02  0:03 Stephen Rothwell
@ 2020-09-02 15:25 ` Christoph Hellwig
  0 siblings, 0 replies; 11+ messages in thread
From: Christoph Hellwig @ 2020-09-02 15:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux Next Mailing List,
	Linux Kernel Mailing List, Jim Quinlan, Santosh Shilimkar

Adding Santosh,

I'm trying to understand the code that Jim changed for the range
dma offsets.  Do I miss something or can the whole DMA offset case
for keystone only happen when CONFIG_LPAE is enabled?  Which means
we could ifdef out this section to avoid the warning?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: build warning after merge of the dma-mapping tree
@ 2020-09-02  0:03 Stephen Rothwell
  2020-09-02 15:25 ` Christoph Hellwig
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2020-09-02  0:03 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jim Quinlan

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hi all,

After merging the dma-mapping tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from arch/arm/mach-keystone/keystone.c:24:
arch/arm/mach-keystone/keystone.c: In function 'keystone_platform_notifier':
arch/arm/mach-keystone/memory.h:17:34: warning: conversion from 'long long unsigned int' to 'phys_addr_t' {aka 'unsigned int'} changes value from '34359738368' to '0' [-Woverflow]
   17 | #define KEYSTONE_HIGH_PHYS_START 0x800000000ULL
      |                                  ^~~~~~~~~~~~~~
arch/arm/mach-keystone/keystone.c:40:39: note: in expansion of macro 'KEYSTONE_HIGH_PHYS_START'
   40 |   int ret = dma_set_offset_range(dev, KEYSTONE_HIGH_PHYS_START,
      |                                       ^~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  eef520b232c6 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: build warning after merge of the dma-mapping tree
  2018-10-01 22:35 Stephen Rothwell
@ 2018-10-02 14:22 ` Christoph Hellwig
  0 siblings, 0 replies; 11+ messages in thread
From: Christoph Hellwig @ 2018-10-02 14:22 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux-Next Mailing List, Linux Kernel Mailing List

Thanks,

fixed now.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: build warning after merge of the dma-mapping tree
@ 2018-10-01 22:35 Stephen Rothwell
  2018-10-02 14:22 ` Christoph Hellwig
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-10-01 22:35 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi Christoph,

After merging the dma-mapping tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/base/platform.c:1182:12: warning: 'dma_default_get_required_mask' defined but not used [-Wunused-function]
 static u64 dma_default_get_required_mask(struct device *dev)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  dma_default_get_required_mask ("dma-mapping: make the get_required_mask method available unconditionally")

It is only used in the case ARCH_HAS_DMA_GET_REQUIRED_MASK is not defined.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: build warning after merge of the dma-mapping tree
  2017-09-03 22:34 Stephen Rothwell
@ 2017-09-04  5:51 ` Christoph Hellwig
  0 siblings, 0 replies; 11+ messages in thread
From: Christoph Hellwig @ 2017-09-04  5:51 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux-Next Mailing List,
	Linux Kernel Mailing List, Marek Szyprowski

Thanks Stephen, I'll fix it.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: build warning after merge of the dma-mapping tree
@ 2017-09-03 22:34 Stephen Rothwell
  2017-09-04  5:51 ` Christoph Hellwig
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2017-09-03 22:34 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Marek Szyprowski

Hi Christoph,

After merging the dma-mapping tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/base/dma-coherent.c: In function '__dma_alloc_from_coherent':
drivers/base/dma-coherent.c:160:6: warning: unused variable 'dma_memory_map' [-Wunused-variable]
  int dma_memory_map;
      ^

Introduced by commit

  2436bdcda53f ("dma-coherent: remove the DMA_MEMORY_MAP and DMA_MEMORY_IO flags")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-09-06 12:41 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 22:54 linux-next: build warning after merge of the dma-mapping tree Stephen Rothwell
2021-08-19  7:02 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2021-08-13  7:11 Stephen Rothwell
2021-09-03  6:45 ` Stephen Rothwell
2021-09-06 12:41   ` Christoph Hellwig
2020-09-02  0:03 Stephen Rothwell
2020-09-02 15:25 ` Christoph Hellwig
2018-10-01 22:35 Stephen Rothwell
2018-10-02 14:22 ` Christoph Hellwig
2017-09-03 22:34 Stephen Rothwell
2017-09-04  5:51 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).