LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [v1 0/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
@ 2021-08-19 8:41 yangcong
2021-08-19 8:41 ` [v1 1/2] " yangcong
2021-08-19 8:41 ` [v1 2/2] dt-bindings: " yangcong
0 siblings, 2 replies; 6+ messages in thread
From: yangcong @ 2021-08-19 8:41 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, robh+dt, dianders
Cc: dri-devel, devicetree, linux-kernel, yangcong
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on. Add support in the driver for this.
yangcong (2):
drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
.../bindings/display/panel/boe,tv101wum-nl6.yaml | 4 ++++
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 11 +++++++++++
2 files changed, 15 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [v1 1/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
2021-08-19 8:41 [v1 0/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail yangcong
@ 2021-08-19 8:41 ` yangcong
2021-08-19 8:41 ` [v1 2/2] dt-bindings: " yangcong
1 sibling, 0 replies; 6+ messages in thread
From: yangcong @ 2021-08-19 8:41 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, robh+dt, dianders
Cc: dri-devel, devicetree, linux-kernel, yangcong
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on. Add support in the driver for this.
Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
---
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index db9d0b86d542..9a644433629e 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -45,6 +45,7 @@ struct boe_panel {
const struct panel_desc *desc;
enum drm_panel_orientation orientation;
+ struct regulator *pp3300;
struct regulator *pp1800;
struct regulator *avee;
struct regulator *avdd;
@@ -511,6 +512,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
} else {
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(500, 1000);
@@ -518,6 +520,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
regulator_disable(boe->avdd);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
}
boe->prepared = false;
@@ -536,6 +539,10 @@ static int boe_panel_prepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(1000, 1500);
+ ret = regulator_enable(boe->pp3300);
+ if (ret < 0)
+ return ret;
+
ret = regulator_enable(boe->pp1800);
if (ret < 0)
return ret;
@@ -767,6 +774,10 @@ static int boe_panel_add(struct boe_panel *boe)
if (IS_ERR(boe->avee))
return PTR_ERR(boe->avee);
+ boe->pp3300 = devm_regulator_get(dev, "pp3300");
+ if (IS_ERR(boe->pp3300))
+ return PTR_ERR(boe->pp3300);
+
boe->pp1800 = devm_regulator_get(dev, "pp1800");
if (IS_ERR(boe->pp1800))
return PTR_ERR(boe->pp1800);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [v1 2/2] dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
2021-08-19 8:41 [v1 0/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail yangcong
2021-08-19 8:41 ` [v1 1/2] " yangcong
@ 2021-08-19 8:41 ` yangcong
1 sibling, 0 replies; 6+ messages in thread
From: yangcong @ 2021-08-19 8:41 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, robh+dt, dianders
Cc: dri-devel, devicetree, linux-kernel, yangcong
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on.
Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
---
.../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
index 38bc1d1b511e..e45de7a4360e 100644
--- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
+++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
@@ -36,6 +36,9 @@ properties:
pp1800-supply:
description: core voltage supply
+ pp3300-supply:
+ description: core voltage supply
+
avdd-supply:
description: phandle of the regulator that provides positive voltage
@@ -52,6 +55,7 @@ required:
- reg
- enable-gpios
- pp1800-supply
+ - pp3300-supply
- avdd-supply
- avee-supply
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [v1 1/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
2021-08-19 12:48 [v1 0/2] " yangcong
@ 2021-08-19 12:48 ` yangcong
0 siblings, 0 replies; 6+ messages in thread
From: yangcong @ 2021-08-19 12:48 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, dianders
Cc: dri-devel, devicetree, linux-kernel, yangcong
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on. Add support in the driver for this.
Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
---
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index db9d0b86d542..9a644433629e 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -45,6 +45,7 @@ struct boe_panel {
const struct panel_desc *desc;
enum drm_panel_orientation orientation;
+ struct regulator *pp3300;
struct regulator *pp1800;
struct regulator *avee;
struct regulator *avdd;
@@ -511,6 +512,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
} else {
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(500, 1000);
@@ -518,6 +520,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
regulator_disable(boe->avdd);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
}
boe->prepared = false;
@@ -536,6 +539,10 @@ static int boe_panel_prepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(1000, 1500);
+ ret = regulator_enable(boe->pp3300);
+ if (ret < 0)
+ return ret;
+
ret = regulator_enable(boe->pp1800);
if (ret < 0)
return ret;
@@ -767,6 +774,10 @@ static int boe_panel_add(struct boe_panel *boe)
if (IS_ERR(boe->avee))
return PTR_ERR(boe->avee);
+ boe->pp3300 = devm_regulator_get(dev, "pp3300");
+ if (IS_ERR(boe->pp3300))
+ return PTR_ERR(boe->pp3300);
+
boe->pp1800 = devm_regulator_get(dev, "pp1800");
if (IS_ERR(boe->pp1800))
return PTR_ERR(boe->pp1800);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [v1 1/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
2021-08-19 9:29 [v1 0/2] " yangcong
@ 2021-08-19 9:29 ` yangcong
0 siblings, 0 replies; 6+ messages in thread
From: yangcong @ 2021-08-19 9:29 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, dianders
Cc: dri-devel, devicetree, linux-kernel, yangcong
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on. Add support in the driver for this.
Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
---
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index db9d0b86d542..9a644433629e 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -45,6 +45,7 @@ struct boe_panel {
const struct panel_desc *desc;
enum drm_panel_orientation orientation;
+ struct regulator *pp3300;
struct regulator *pp1800;
struct regulator *avee;
struct regulator *avdd;
@@ -511,6 +512,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
} else {
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(500, 1000);
@@ -518,6 +520,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
regulator_disable(boe->avdd);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
}
boe->prepared = false;
@@ -536,6 +539,10 @@ static int boe_panel_prepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(1000, 1500);
+ ret = regulator_enable(boe->pp3300);
+ if (ret < 0)
+ return ret;
+
ret = regulator_enable(boe->pp1800);
if (ret < 0)
return ret;
@@ -767,6 +774,10 @@ static int boe_panel_add(struct boe_panel *boe)
if (IS_ERR(boe->avee))
return PTR_ERR(boe->avee);
+ boe->pp3300 = devm_regulator_get(dev, "pp3300");
+ if (IS_ERR(boe->pp3300))
+ return PTR_ERR(boe->pp3300);
+
boe->pp1800 = devm_regulator_get(dev, "pp1800");
if (IS_ERR(boe->pp1800))
return PTR_ERR(boe->pp1800);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [v1 1/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail
2021-08-19 8:28 [v1 0/2] " yangcong
@ 2021-08-19 8:28 ` yangcong
0 siblings, 0 replies; 6+ messages in thread
From: yangcong @ 2021-08-19 8:28 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, robh+dt, dri-devel,
devicetree, linux-kernel, dianders
Cc: yangcong
The auo,b101uan08.3 panel (already supported by this driver) has
a 3.3V rail that needs to be turned on. For previous users of
this panel this voltage was directly output by pmic. On a new
user (the not-yet-upstream sc7180-trogdor-mrbland board) we need
to turn the 3.3V rail on. Add support in the driver for this.
Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com>
---
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index db9d0b86d542..9a644433629e 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -45,6 +45,7 @@ struct boe_panel {
const struct panel_desc *desc;
enum drm_panel_orientation orientation;
+ struct regulator *pp3300;
struct regulator *pp1800;
struct regulator *avee;
struct regulator *avdd;
@@ -511,6 +512,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
} else {
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(500, 1000);
@@ -518,6 +520,7 @@ static int boe_panel_unprepare(struct drm_panel *panel)
regulator_disable(boe->avdd);
usleep_range(5000, 7000);
regulator_disable(boe->pp1800);
+ regulator_disable(boe->pp3300);
}
boe->prepared = false;
@@ -536,6 +539,10 @@ static int boe_panel_prepare(struct drm_panel *panel)
gpiod_set_value(boe->enable_gpio, 0);
usleep_range(1000, 1500);
+ ret = regulator_enable(boe->pp3300);
+ if (ret < 0)
+ return ret;
+
ret = regulator_enable(boe->pp1800);
if (ret < 0)
return ret;
@@ -767,6 +774,10 @@ static int boe_panel_add(struct boe_panel *boe)
if (IS_ERR(boe->avee))
return PTR_ERR(boe->avee);
+ boe->pp3300 = devm_regulator_get(dev, "pp3300");
+ if (IS_ERR(boe->pp3300))
+ return PTR_ERR(boe->pp3300);
+
boe->pp1800 = devm_regulator_get(dev, "pp1800");
if (IS_ERR(boe->pp1800))
return PTR_ERR(boe->pp1800);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-19 12:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 8:41 [v1 0/2] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail yangcong
2021-08-19 8:41 ` [v1 1/2] " yangcong
2021-08-19 8:41 ` [v1 2/2] dt-bindings: " yangcong
-- strict thread matches above, loose matches on Subject: below --
2021-08-19 12:48 [v1 0/2] " yangcong
2021-08-19 12:48 ` [v1 1/2] " yangcong
2021-08-19 9:29 [v1 0/2] " yangcong
2021-08-19 9:29 ` [v1 1/2] " yangcong
2021-08-19 8:28 [v1 0/2] " yangcong
2021-08-19 8:28 ` [v1 1/2] " yangcong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).