LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Duncan <j.duncan@cox.net>
To: lnx7586@gregdf.com
Cc: mikpelinux@gmail.com, daniel.vetter@ffwll.ch,
	dri-devel@lists.freedesktop.org, jason@jlekstrand.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/ttm: allow debugfs_create_file() to fail in ttm_global_init()
Date: Thu, 19 Aug 2021 15:38:26 -0700	[thread overview]
Message-ID: <20210819153826.460b9c11@ws> (raw)
In-Reply-To: <20210816143046.3320-1-lnx7586@gregdf.com>

On Mon, 16 Aug 2021 16:30:46 +0200
lnx7586@gregdf.com wrote:

> From: Greg Depoire--Ferrer <lnx7586@gregdf.com>
> 
> Commit 69de4421bb4c ("drm/ttm: Initialize debugfs from
> ttm_global_init()") unintentionally made ttm_global_init() return
> early with an error when debugfs_create_file() fails. When
> CONFIG_DEBUG_FS is disabled, debugfs_create_file() returns a ENODEV
> error so the TTM device would fail to initialize.
> 
> Instead of returning early with the error, print it and continue.
> ENODEV can be ignored because it just means that CONFIG_DEBUG_FS is
> disabled.
> 
> Fixes: 69de4421bb4c ("drm/ttm: Initialize debugfs from ttm_global_init()")
> Reported-by: Mikael Pettersson <mikpelinux@gmail.com>
> Reported-by: Duncan <j.duncan@cox.net>
> Signed-off-by: Greg Depoire--Ferrer <lnx7586@gregdf.com>
> ---
> Hi, I had this bug as well with the nouveau driver after updating.
> This patch fixes it for me.
> 
>  drivers/gpu/drm/ttm/ttm_device.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

This fixes the problem here, too.  Running it now.

Tested-by: Duncan <j.duncan@cox.net>

-- 
Duncan - HTML messages treated as spam
"They that can give up essential liberty to obtain a little
temporary safety, deserve neither liberty nor safety."
Benjamin Franklin

      reply	other threads:[~2021-08-19 22:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 17:16 [BISECTED] 5.14.0-rc4 broke drm/ttm when !CONFIG_DEBUG_FS Mikael Pettersson
2021-08-02 18:29 ` Duncan
2021-08-03  6:54   ` Mikael Pettersson
2021-08-16 14:30 ` [PATCH] drm/ttm: allow debugfs_create_file() to fail in ttm_global_init() lnx7586
2021-08-19 22:38   ` Duncan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210819153826.460b9c11@ws \
    --to=j.duncan@cox.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lnx7586@gregdf.com \
    --cc=mikpelinux@gmail.com \
    --subject='Re: [PATCH] drm/ttm: allow debugfs_create_file() to fail in ttm_global_init()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).