LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3
@ 2021-08-19 15:48 Nadezda Lutovinova
2021-08-19 20:15 ` Fabio Estevam
2021-08-20 10:06 ` Felipe Balbi
0 siblings, 2 replies; 3+ messages in thread
From: Nadezda Lutovinova @ 2021-08-19 15:48 UTC (permalink / raw)
To: Felipe Balbi
Cc: Nadezda Lutovinova, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-usb, linux-arm-kernel, linux-kernel, ldv-project
If IRQ occurs between calling devm_request_threaded_irq() and
initializing dwc3_imx->dwc3, then null pointer dereference occurs
since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt().
The patch puts registration of the interrupt handler after
initializing of neccesery data.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
---
drivers/usb/dwc3/dwc3-imx8mp.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index 756faa46d33a..d328d20abfbc 100644
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -152,13 +152,6 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
}
dwc3_imx->irq = irq;
- err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt,
- IRQF_ONESHOT, dev_name(dev), dwc3_imx);
- if (err) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
- goto disable_clks;
- }
-
pm_runtime_set_active(dev);
pm_runtime_enable(dev);
err = pm_runtime_get_sync(dev);
@@ -186,6 +179,13 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
}
of_node_put(dwc3_np);
+ err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt,
+ IRQF_ONESHOT, dev_name(dev), dwc3_imx);
+ if (err) {
+ dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
+ goto depopulate;
+ }
+
device_set_wakeup_capable(dev, true);
pm_runtime_put(dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3
2021-08-19 15:48 [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3 Nadezda Lutovinova
@ 2021-08-19 20:15 ` Fabio Estevam
2021-08-20 10:06 ` Felipe Balbi
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-08-19 20:15 UTC (permalink / raw)
To: Nadezda Lutovinova
Cc: Felipe Balbi, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, USB list,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, ldv-project
Hi Nadezda,
On Thu, Aug 19, 2021 at 12:48 PM Nadezda Lutovinova
<lutovinova@ispras.ru> wrote:
>
> If IRQ occurs between calling devm_request_threaded_irq() and
> initializing dwc3_imx->dwc3, then null pointer dereference occurs
> since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.
"necessary"
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3
2021-08-19 15:48 [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3 Nadezda Lutovinova
2021-08-19 20:15 ` Fabio Estevam
@ 2021-08-20 10:06 ` Felipe Balbi
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2021-08-20 10:06 UTC (permalink / raw)
To: Nadezda Lutovinova
Cc: Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-usb, linux-arm-kernel, linux-kernel, ldv-project
Nadezda Lutovinova <lutovinova@ispras.ru> writes:
> If IRQ occurs between calling devm_request_threaded_irq() and
> initializing dwc3_imx->dwc3, then null pointer dereference occurs
> since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-20 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 15:48 [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3 Nadezda Lutovinova
2021-08-19 20:15 ` Fabio Estevam
2021-08-20 10:06 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).