LKML Archive on
help / color / mirror / Atom feed
From: Jakub Kicinski <>
To: Marc Zyngier <>
	Matteo Croce <>,
	"David S. Miller" <>,
	Eric Dumazet <>,
	Giuseppe Cavallaro <>,
	Alexandre Torgue <>
Subject: Re: [PATCH net] stmmac: Revert "stmmac: align RX buffers"
Date: Fri, 20 Aug 2021 14:46:10 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 20 Aug 2021 19:30:02 +0100 Marc Zyngier wrote:
> This reverts commit a955318fe67e ("stmmac: align RX buffers"),
> which breaks at least one platform (Nvidia Jetson-X1), causing
> packet corruption. This is 100% reproducible, and reverting
> the patch results in a working system again.
> Given that it is "only" a performance optimisation, let's
> return to a known working configuration until we can have a
> good understanding of what is happening here.

Seems reasonable. Hopefully it wont discourage Matteo from revisiting
the optimization. Applied, thanks!

  reply	other threads:[~2021-08-20 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 18:30 Marc Zyngier
2021-08-20 21:46 ` Jakub Kicinski [this message]
2021-08-21  9:50   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net] stmmac: Revert "stmmac: align RX buffers"' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).