LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: iio: cdc: remove braces from single line if blocks
@ 2021-08-20 22:49 Alexander Vorwerk
  2021-08-30 11:30 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Vorwerk @ 2021-08-20 22:49 UTC (permalink / raw)
  To: lars, Michael.Hennerich, jic23, gregkh
  Cc: linux-iio, linux-staging, linux-kernel, Alexander Vorwerk

Remove braces from single line if blocks to clear checkpatch warnings.
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Alexander Vorwerk <alec@vc-celle.de>
---
 drivers/staging/iio/cdc/ad7746.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 78ac720266e6..71c709771676 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -241,10 +241,8 @@ static int ad7746_select_channel(struct iio_dev *indio_dev,
 		if (ret < 0)
 			return ret;
 
-		if (chip->capdac_set != chan->channel) {
-
+		if (chip->capdac_set != chan->channel)
 			chip->capdac_set = chan->channel;
-		}
 		break;
 	case IIO_VOLTAGE:
 	case IIO_TEMP:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: iio: cdc: remove braces from single line if blocks
  2021-08-20 22:49 [PATCH] staging: iio: cdc: remove braces from single line if blocks Alexander Vorwerk
@ 2021-08-30 11:30 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-08-30 11:30 UTC (permalink / raw)
  To: Alexander Vorwerk
  Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-staging, linux-kernel

On Sat, 21 Aug 2021 00:49:14 +0200
Alexander Vorwerk <alec@vc-celle.de> wrote:

> Remove braces from single line if blocks to clear checkpatch warnings.
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Alexander Vorwerk <alec@vc-celle.de>
Applied. Thanks
> ---
>  drivers/staging/iio/cdc/ad7746.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 78ac720266e6..71c709771676 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -241,10 +241,8 @@ static int ad7746_select_channel(struct iio_dev *indio_dev,
>  		if (ret < 0)
>  			return ret;
>  
> -		if (chip->capdac_set != chan->channel) {
> -
> +		if (chip->capdac_set != chan->channel)
>  			chip->capdac_set = chan->channel;
> -		}
>  		break;
>  	case IIO_VOLTAGE:
>  	case IIO_TEMP:


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-30 11:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 22:49 [PATCH] staging: iio: cdc: remove braces from single line if blocks Alexander Vorwerk
2021-08-30 11:30 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).