LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH linux-next] video: fbdev: mb862xx: drop unneeded assignment in the mb86290fb_imageblit8()
@ 2021-08-21  2:18 CGEL
  0 siblings, 0 replies; only message in thread
From: CGEL @ 2021-08-21  2:18 UTC (permalink / raw)
  To: dri-devel; +Cc: linux-fbdev, linux-kernel, Luo penghao, Zeal Robot

From: Luo penghao <luo.penghao@zte.com.cn>

The first assignment is not used.In order to keep the
code style consistency of the whole file,the first
‘ptr’ assignment should be deleted.

The clang_analyzer complains as follows:

drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:135:9: warning:
Although the value storedto 'ptr' is used in the enclosing expression,
the value is never actually read from 'ptr'.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Luo penghao <luo.penghao@zte.com.cn>
---
 drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
index d40b806..61aed7f 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
@@ -132,7 +132,7 @@ static void mb86290fb_imageblit8(u32 *cmd, u16 step, u16 dx, u16 dy,
 	cmd[2] = (height << 16) | width;
 
 	i = 0;
-	line = ptr = image->data;
+	line = image->data;
 	bytes = image->width;
 
 	while (i < height) {
-- 
2.15.2



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-21  2:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21  2:18 [PATCH linux-next] video: fbdev: mb862xx: drop unneeded assignment in the mb86290fb_imageblit8() CGEL

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).