LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Usb: storage: usb: removed useless cast of void*
@ 2021-08-21 12:11 Niklas Lantau
  2021-08-26 11:23 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Niklas Lantau @ 2021-08-21 12:11 UTC (permalink / raw)
  To: stern; +Cc: linux-usb, usb-storage, linux-kernel, Niklas Lantau

Removed useless cast of a void* and changed __us to data

Signed-off-by: Niklas Lantau <niklaslantau@gmail.com>
---
 drivers/usb/storage/usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 90aa9c12ffac..e78e20fb1afa 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -295,9 +295,9 @@ void fill_inquiry_response(struct us_data *us, unsigned char *data,
 }
 EXPORT_SYMBOL_GPL(fill_inquiry_response);
 
-static int usb_stor_control_thread(void * __us)
+static int usb_stor_control_thread(void *data)
 {
-	struct us_data *us = (struct us_data *)__us;
+	struct us_data *us = data;
 	struct Scsi_Host *host = us_to_host(us);
 	struct scsi_cmnd *srb;
 
-- 
2.33.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Usb: storage: usb: removed useless cast of void*
  2021-08-21 12:11 [PATCH] Usb: storage: usb: removed useless cast of void* Niklas Lantau
@ 2021-08-26 11:23 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-08-26 11:23 UTC (permalink / raw)
  To: Niklas Lantau; +Cc: stern, linux-usb, usb-storage, linux-kernel

On Sat, Aug 21, 2021 at 02:11:34PM +0200, Niklas Lantau wrote:
> Removed useless cast of a void* and changed __us to data

Why did you do two different things in the same patch?

If you want to work on coding style cleanups, I recommend starting in
the drivers/staging/ area to gain experience before venturing out into
the rest of the kernel.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-26 11:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 12:11 [PATCH] Usb: storage: usb: removed useless cast of void* Niklas Lantau
2021-08-26 11:23 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).