LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] media: rc and cec: keep all menu entries together
@ 2021-08-22  0:04 Randy Dunlap
  2021-09-20 11:19 ` Hans Verkuil
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-08-22  0:04 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Sean Young, Hans Verkuil, linux-media,
	Mauro Carvalho Chehab

Keep all of the Remote Controller and CEC menu entries grouped
together. This is most relevant to 'make xconfig', where the
entries for "HDMI CEC RC integration" and "Enable CEC error injection
support" are not displayed (presented) anywhere near the other
Remote Controller support options.
By grouping all of these menu entries inside a menu/endmenu block,
they are forced to be kept together.

Fixes: 46d2a3b964dd ("media: place CEC menu before MEDIA_SUPPORT")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Sean Young <sean@mess.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20210820.orig/drivers/media/Kconfig
+++ linux-next-20210820/drivers/media/Kconfig
@@ -6,8 +6,10 @@
 #
 # NOTE: CEC and Remote Controller support should not depend on MEDIA_SUPPORT
 #
+menu "Remote Controller and CEC support"
 source "drivers/media/rc/Kconfig"
 source "drivers/media/cec/Kconfig"
+endmenu
 
 menuconfig MEDIA_SUPPORT
 	tristate "Multimedia support"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: rc and cec: keep all menu entries together
  2021-08-22  0:04 [PATCH] media: rc and cec: keep all menu entries together Randy Dunlap
@ 2021-09-20 11:19 ` Hans Verkuil
  2021-09-20 23:57   ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2021-09-20 11:19 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel; +Cc: Sean Young, linux-media, Mauro Carvalho Chehab

Hi Randy,

On 22/08/2021 02:04, Randy Dunlap wrote:
> Keep all of the Remote Controller and CEC menu entries grouped
> together. This is most relevant to 'make xconfig', where the
> entries for "HDMI CEC RC integration" and "Enable CEC error injection
> support" are not displayed (presented) anywhere near the other
> Remote Controller support options.
> By grouping all of these menu entries inside a menu/endmenu block,
> they are forced to be kept together.
> 
> Fixes: 46d2a3b964dd ("media: place CEC menu before MEDIA_SUPPORT")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sean Young <sean@mess.org>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: linux-media@vger.kernel.org
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  drivers/media/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20210820.orig/drivers/media/Kconfig
> +++ linux-next-20210820/drivers/media/Kconfig
> @@ -6,8 +6,10 @@
>  #
>  # NOTE: CEC and Remote Controller support should not depend on MEDIA_SUPPORT
>  #
> +menu "Remote Controller and CEC support"
>  source "drivers/media/rc/Kconfig"
>  source "drivers/media/cec/Kconfig"
> +endmenu

Remote control and CEC really have very little to do with one another, except
for "HDMI CEC RC integration", which is a feature of CEC.

It would make more sense IMHO to make a "CEC support" menu and move the
CEC drivers and "HDMI CEC RC integration" and "Enable CEC error injection
support" to that new menu. It's a bit odd that those two CEC options are
directly under the Device Drivers menu.

Would that work for you?

Regards,

	Hans

>  
>  menuconfig MEDIA_SUPPORT
>  	tristate "Multimedia support"
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: rc and cec: keep all menu entries together
  2021-09-20 11:19 ` Hans Verkuil
@ 2021-09-20 23:57   ` Randy Dunlap
  0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-09-20 23:57 UTC (permalink / raw)
  To: Hans Verkuil, linux-kernel; +Cc: Sean Young, linux-media, Mauro Carvalho Chehab

On 9/20/21 4:19 AM, Hans Verkuil wrote:
> Hi Randy,
> 
> On 22/08/2021 02:04, Randy Dunlap wrote:
>> Keep all of the Remote Controller and CEC menu entries grouped
>> together. This is most relevant to 'make xconfig', where the
>> entries for "HDMI CEC RC integration" and "Enable CEC error injection
>> support" are not displayed (presented) anywhere near the other
>> Remote Controller support options.
>> By grouping all of these menu entries inside a menu/endmenu block,
>> they are forced to be kept together.
>>
>> Fixes: 46d2a3b964dd ("media: place CEC menu before MEDIA_SUPPORT")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Sean Young <sean@mess.org>
>> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> Cc: linux-media@vger.kernel.org
>> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>> ---
>>   drivers/media/Kconfig |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> --- linux-next-20210820.orig/drivers/media/Kconfig
>> +++ linux-next-20210820/drivers/media/Kconfig
>> @@ -6,8 +6,10 @@
>>   #
>>   # NOTE: CEC and Remote Controller support should not depend on MEDIA_SUPPORT
>>   #
>> +menu "Remote Controller and CEC support"
>>   source "drivers/media/rc/Kconfig"
>>   source "drivers/media/cec/Kconfig"
>> +endmenu
> 
> Remote control and CEC really have very little to do with one another, except
> for "HDMI CEC RC integration", which is a feature of CEC.
> 
> It would make more sense IMHO to make a "CEC support" menu and move the
> CEC drivers and "HDMI CEC RC integration" and "Enable CEC error injection
> support" to that new menu. It's a bit odd that those two CEC options are
> directly under the Device Drivers menu.
> 
> Would that work for you?
> 

Hi Hans,
I don't know, but I'll try it out.

Thanks.

> 
>>   
>>   menuconfig MEDIA_SUPPORT
>>   	tristate "Multimedia support"
>>
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-21  2:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22  0:04 [PATCH] media: rc and cec: keep all menu entries together Randy Dunlap
2021-09-20 11:19 ` Hans Verkuil
2021-09-20 23:57   ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).