LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the block tree
@ 2021-08-22  3:24 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2021-08-22  3:24 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hi all,

In commit

  071e5f53b789 ("block: always initialize bio->bi_pool")

Fixes tag

  Fixes: Fixes: a4aa1b0494ea ("bio: optimize initialization of a bio")

has these problem(s):

  - Extra "Fixes:" word

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2022-01-03 21:25 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2022-01-03 21:25 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Geliang Tang, Christoph Hellwig, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

In commit

  3a605e32a7f8 ("nvme: drop unused variable ctrl in nvme_setup_cmd")

Fixes tag

  Fixes: 292ddf67bbd5 ("nvme: increment request genctr on completion")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: e4fdb2b167ed ("nvme: increment request genctr on completion")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-10-19 21:46 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2021-10-19 21:46 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Zheng Liang, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

In commit

  2fc428f6b7ca ("block, bfq: fix UAF problem in bfqg_stats_init()")

Fixes tag

  Fixes: commit fd41e60331b ("bfq-iosched: stop using blkg->stat_bytes and ->stat_ios")

has these problem(s):

  - leading word 'commit' unexpected
  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-05-19 19:25 ` Sergey Shtylyov
@ 2021-05-19 21:55   ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2021-05-19 21:55 UTC (permalink / raw)
  To: Sergey Shtylyov, Stephen Rothwell
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 5/19/21 1:25 PM, Sergey Shtylyov wrote:
> Hello!
> 
> On 5/19/21 1:01 AM, Stephen Rothwell wrote:
> 
> [...]
>> In commit
>>
>>   1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")
>>
>> Fixes tag
>>
>>   Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
>>
>> has these problem(s):
>>
>>   - Subject does not match target commit subject
>>     Just use
>> 	git log -1 --format='Fixes: %h ("%s")'
>>
>> Maybe you meant
>>
>> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> 
>    This one!
> 
>> or
>>
>> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")
> 
>    Perhaps this could be fixed still, Jens?

Yep, I fixed it up, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-05-18 22:01 Stephen Rothwell
@ 2021-05-19 19:25 ` Sergey Shtylyov
  2021-05-19 21:55   ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Sergey Shtylyov @ 2021-05-19 19:25 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

Hello!

On 5/19/21 1:01 AM, Stephen Rothwell wrote:

[...]
> In commit
> 
>   1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")
> 
> Fixes tag
> 
>   Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Maybe you meant
> 
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

   This one!

> or
> 
> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

   Perhaps this could be fixed still, Jens?

MBR, Sergey

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-05-18 22:01 Stephen Rothwell
  2021-05-19 19:25 ` Sergey Shtylyov
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2021-05-18 22:01 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Sergey Shtylyov, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Hi all,

In commit

  1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")

Fixes tag

  Fixes: 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

or

Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-05-05 22:23 Stephen Rothwell
@ 2021-05-09  1:49 ` Minwoo Im
  0 siblings, 0 replies; 59+ messages in thread
From: Minwoo Im @ 2021-05-09  1:49 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jens Axboe, Christoph Hellwig, Linux Kernel Mailing List,
	Linux Next Mailing List

Hello,

Sorry for the late reply, and appreciate pointing that out :)
I will keep that in mind.

Thanks!

On Thu, May 6, 2021 at 7:23 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   48145b62563a ("nvme: fix controller ioctl through ns_head")
>
> Fixes tag
>
>   Fixes: 3557a4409701 ("nvme: don't bother to look up a namespace for
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-05-05 22:23 Stephen Rothwell
  2021-05-09  1:49 ` Minwoo Im
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2021-05-05 22:23 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Minwoo Im, Christoph Hellwig, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  48145b62563a ("nvme: fix controller ioctl through ns_head")

Fixes tag

  Fixes: 3557a4409701 ("nvme: don't bother to look up a namespace for

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-03-05  7:46   ` Christoph Hellwig
@ 2021-03-05 15:53     ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2021-03-05 15:53 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Stephen Rothwell, Daniel Wagner, Linux Kernel Mailing List,
	Linux Next Mailing List

On 3/5/21 12:46 AM, Christoph Hellwig wrote:
> On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote:
>> Christoph, since there's multiple commits with issues, mind resending
>> a fixed branch? Then I'll drop the one I pulled today.
> 
> I've fixed the commit id and dropped the patch without the author
> signoff, but your branch still has the current patches.

Killed it this morning, please resend it. Plan on shipping to Linus
today so we ensure we hit -rc2.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-03-05  0:26 ` Jens Axboe
@ 2021-03-05  7:46   ` Christoph Hellwig
  2021-03-05 15:53     ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Christoph Hellwig @ 2021-03-05  7:46 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Daniel Wagner, Christoph Hellwig,
	Linux Kernel Mailing List, Linux Next Mailing List

On Thu, Mar 04, 2021 at 05:26:42PM -0700, Jens Axboe wrote:
> Christoph, since there's multiple commits with issues, mind resending
> a fixed branch? Then I'll drop the one I pulled today.

I've fixed the commit id and dropped the patch without the author
signoff, but your branch still has the current patches.

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-03-04 23:52 Stephen Rothwell
@ 2021-03-05  0:26 ` Jens Axboe
  2021-03-05  7:46   ` Christoph Hellwig
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2021-03-05  0:26 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Wagner, Christoph Hellwig, Linux Kernel Mailing List,
	Linux Next Mailing List

On 3/4/21 4:52 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails")
> 
> Fixes tag
> 
>   Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid devm allocation")

Christoph, since there's multiple commits with issues, mind resending
a fixed branch? Then I'll drop the one I pulled today.


-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-03-04 23:52 Stephen Rothwell
  2021-03-05  0:26 ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2021-03-04 23:52 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Daniel Wagner, Christoph Hellwig, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi all,

In commit

  284e4cdb0c0b ("nvme-hwmon: Return error code when registration fails")

Fixes tag

  Fixes: ec420cdcfab4 ("nvme/hwmon: rework to avoid devm allocation")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ed7770f66286 ("nvme-hwmon: rework to avoid devm allocation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-02-22 21:01 Stephen Rothwell
@ 2021-02-22 21:15 ` Chaitanya Kulkarni
  0 siblings, 0 replies; 59+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-22 21:15 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

On 2/22/21 13:01, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")
>
> Fixes tag
>
>   Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>
> -- Cheers, Stephen Rothwell

Yes, it was my fault it should be 1b9a9ab78b0a the last 'a' is missing.


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-02-22 21:01 Stephen Rothwell
  2021-02-22 21:15 ` Chaitanya Kulkarni
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2021-02-22 21:01 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Chaitanya Kulkarni, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

In commit

  179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")

Fixes tag

  Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-02-20  4:51 Stephen Rothwell
@ 2021-02-20  4:57 ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2021-02-20  4:57 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Pavel Begunkov, Linux Kernel Mailing List, Linux Next Mailing List

On 2/19/21 9:51 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races")
> 
> Fixes tag
> 
>   Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling io_run_task_work*")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: a4f2225d1cb2 ("io_uring: don't hold uring_lock when calling io_run_task_work*")

Fixed it up, thanks Stephen.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-02-20  4:51 Stephen Rothwell
  2021-02-20  4:57 ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2021-02-20  4:51 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Pavel Begunkov, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  76676c992506 ("io_uring: fix io_rsrc_ref_quiesce races")

Fixes tag

  Fixes: 0ce4a72632317 ("io_uring: don't hold uring_lock when calling io_run_task_work*")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a4f2225d1cb2 ("io_uring: don't hold uring_lock when calling io_run_task_work*")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-02-04 20:13 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2021-02-04 20:13 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Jiri Kosina, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Hi all,

In commit

  8a0c014cd205 ("floppy: reintroduce O_NDELAY fix")

Fixes tag

  Fixes: 09954bad4 ("floppy: refactor open() flags handling")

has these problem(s):

  - SHA1 should be at least 12 digits long

Fixes tag

  Fixes: f2791e7ead ("Revert "floppy: refactor open() flags handling"")

has these problem(s):

  - SHA1 should be at least 12 digits long

These can be fixed for future commits by setting core.abbrev to 12
(or more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-01-26 16:01         ` Jan Kara
@ 2021-01-26 16:05           ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2021-01-26 16:05 UTC (permalink / raw)
  To: Jan Kara
  Cc: Paolo Valente, Stephen Rothwell, Jia Cheng Hu,
	Linux Kernel Mailing List, Linux Next Mailing List

On 1/26/21 9:01 AM, Jan Kara wrote:
> On Tue 26-01-21 08:47:55, Jens Axboe wrote:
>> On 1/26/21 6:29 AM, Jan Kara wrote:
>>> On Mon 25-01-21 11:39:50, Jens Axboe wrote:
>>>> On 1/25/21 11:35 AM, Paolo Valente wrote:
>>>>>
>>>>>
>>>>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> In commit
>>>>>>
>>>>>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
>>>>>>
>>>>>> Fixes tag
>>>>>>
>>>>>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>>>
>>>>>> has these problem(s):
>>>>>>
>>>>>>  - Target SHA1 does not exist
>>>>>>
>>>>>> Maybe you meant
>>>>>>
>>>>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>>>
>>>>>
>>>>> Hi Jens,
>>>>> how to proceed in such a case (with patches already applied by you)?
>>>>> Shall I send you a v2 with only this change?
>>>>
>>>> We just have to ignore it... But in the future, always double check that
>>>> you are using the right shas, not some sha from an internal tree.
>>>
>>> FWIW I have a commit hook in my git tree that just refuses a commit with
>>> unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
>>> merge...
>>
>> That's not a bad idea, would help catch it upfront. Can you share the
>> hook?
> 
> Sure, attached. Note that the hook just gets commit ID from the Fixes tag
> and formats it with 12 commit ID digits and appropriate commit subject.

Thanks, that looks great, and also fixes up short shas.


-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-01-26 15:47       ` Jens Axboe
@ 2021-01-26 16:01         ` Jan Kara
  2021-01-26 16:05           ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Jan Kara @ 2021-01-26 16:01 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Jan Kara, Paolo Valente, Stephen Rothwell, Jia Cheng Hu,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Tue 26-01-21 08:47:55, Jens Axboe wrote:
> On 1/26/21 6:29 AM, Jan Kara wrote:
> > On Mon 25-01-21 11:39:50, Jens Axboe wrote:
> >> On 1/25/21 11:35 AM, Paolo Valente wrote:
> >>>
> >>>
> >>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
> >>>>
> >>>> Hi all,
> >>>>
> >>>> In commit
> >>>>
> >>>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
> >>>>
> >>>> Fixes tag
> >>>>
> >>>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>>>
> >>>> has these problem(s):
> >>>>
> >>>>  - Target SHA1 does not exist
> >>>>
> >>>> Maybe you meant
> >>>>
> >>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>>>
> >>>
> >>> Hi Jens,
> >>> how to proceed in such a case (with patches already applied by you)?
> >>> Shall I send you a v2 with only this change?
> >>
> >> We just have to ignore it... But in the future, always double check that
> >> you are using the right shas, not some sha from an internal tree.
> > 
> > FWIW I have a commit hook in my git tree that just refuses a commit with
> > unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
> > merge...
> 
> That's not a bad idea, would help catch it upfront. Can you share the
> hook?

Sure, attached. Note that the hook just gets commit ID from the Fixes tag
and formats it with 12 commit ID digits and appropriate commit subject.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

[-- Attachment #2: commit-msg --]
[-- Type: text/plain, Size: 700 bytes --]

#!/bin/sh
#
# Called by "git commit" with one argument, the name of the file
# that has the commit message.  The hook should exit with non-zero
# status after issuing an appropriate message if it wants to stop the
# commit.  The hook is allowed to edit the commit message file.

# Process all Fixes tags, check commit IDs and set appropriate commit titles.

for COMMIT in $(sed -n -e 's/^Fixes: \([0-9a-z]*\).*/\1/p' "$1"); do
	GOOD=$(git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" $COMMIT -- 2>/dev/null)
	if [ -z "$GOOD" ]; then
		echo "Unknown commit: $COMMIT"
		exit 1
	fi
	echo "Setting fixes tag: $GOOD"
	sed -i -e "s/^Fixes: $COMMIT.*/Fixes: $GOOD/" "$1"
done

exit 0

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-01-26 13:29     ` Jan Kara
@ 2021-01-26 15:47       ` Jens Axboe
  2021-01-26 16:01         ` Jan Kara
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2021-01-26 15:47 UTC (permalink / raw)
  To: Jan Kara
  Cc: Paolo Valente, Stephen Rothwell, Jia Cheng Hu,
	Linux Kernel Mailing List, Linux Next Mailing List

On 1/26/21 6:29 AM, Jan Kara wrote:
> On Mon 25-01-21 11:39:50, Jens Axboe wrote:
>> On 1/25/21 11:35 AM, Paolo Valente wrote:
>>>
>>>
>>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
>>>>
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
>>>>
>>>> Fixes tag
>>>>
>>>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>
>>>> has these problem(s):
>>>>
>>>>  - Target SHA1 does not exist
>>>>
>>>> Maybe you meant
>>>>
>>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
>>>>
>>>
>>> Hi Jens,
>>> how to proceed in such a case (with patches already applied by you)?
>>> Shall I send you a v2 with only this change?
>>
>> We just have to ignore it... But in the future, always double check that
>> you are using the right shas, not some sha from an internal tree.
> 
> FWIW I have a commit hook in my git tree that just refuses a commit with
> unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
> merge...

That's not a bad idea, would help catch it upfront. Can you share the
hook?

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-01-25 18:39   ` Jens Axboe
@ 2021-01-26 13:29     ` Jan Kara
  2021-01-26 15:47       ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Jan Kara @ 2021-01-26 13:29 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Paolo Valente, Stephen Rothwell, Jia Cheng Hu, Jan Kara,
	Linux Kernel Mailing List, Linux Next Mailing List

On Mon 25-01-21 11:39:50, Jens Axboe wrote:
> On 1/25/21 11:35 AM, Paolo Valente wrote:
> > 
> > 
> >> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
> >>
> >> Hi all,
> >>
> >> In commit
> >>
> >>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
> >>
> >> Fixes tag
> >>
> >>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>
> >> has these problem(s):
> >>
> >>  - Target SHA1 does not exist
> >>
> >> Maybe you meant
> >>
> >> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
> >>
> > 
> > Hi Jens,
> > how to proceed in such a case (with patches already applied by you)?
> > Shall I send you a v2 with only this change?
> 
> We just have to ignore it... But in the future, always double check that
> you are using the right shas, not some sha from an internal tree.

FWIW I have a commit hook in my git tree that just refuses a commit with
unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I
merge...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-01-25 18:35 ` Paolo Valente
@ 2021-01-25 18:39   ` Jens Axboe
  2021-01-26 13:29     ` Jan Kara
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2021-01-25 18:39 UTC (permalink / raw)
  To: Paolo Valente, Stephen Rothwell
  Cc: Jia Cheng Hu, Jan Kara, Linux Kernel Mailing List,
	Linux Next Mailing List

On 1/25/21 11:35 AM, Paolo Valente wrote:
> 
> 
>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
>>
>> Hi all,
>>
>> In commit
>>
>>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
>>
>> Fixes tag
>>
>>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
>>
>> has these problem(s):
>>
>>  - Target SHA1 does not exist
>>
>> Maybe you meant
>>
>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
>>
> 
> Hi Jens,
> how to proceed in such a case (with patches already applied by you)?
> Shall I send you a v2 with only this change?

We just have to ignore it... But in the future, always double check that
you are using the right shas, not some sha from an internal tree.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2021-01-25  9:40 Stephen Rothwell
@ 2021-01-25 18:35 ` Paolo Valente
  2021-01-25 18:39   ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Paolo Valente @ 2021-01-25 18:35 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jens Axboe, Jia Cheng Hu, Jan Kara, Linux Kernel Mailing List,
	Linux Next Mailing List



> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell <sfr@canb.auug.org.au> ha scritto:
> 
> Hi all,
> 
> In commit
> 
>  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")
> 
> Fixes tag
> 
>  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")
> 
> has these problem(s):
> 
>  - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")
> 

Hi Jens,
how to proceed in such a case (with patches already applied by you)?
Shall I send you a v2 with only this change?

Thanks,
Paolo

> -- 
> Cheers,
> Stephen Rothwell


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2021-01-25  9:40 Stephen Rothwell
  2021-01-25 18:35 ` Paolo Valente
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2021-01-25  9:40 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Jia Cheng Hu, Jan Kara, Paolo Valente, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

In commit

  d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection")

Fixes tag

  Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-12-17 20:38 Stephen Rothwell
@ 2020-12-17 20:42 ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2020-12-17 20:42 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Stefan Haberland

On 12/17/20 1:38 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   358e7cbf87b4 ("s390/dasd: fix hanging device offline processing")
> 
> Fixes tag
> 
>   Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address configuration")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 41995342b40c ("s390/dasd: fix endless loop after read unit address configuration")

Thanks, I fixed it up.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-12-17 20:38 Stephen Rothwell
  2020-12-17 20:42 ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-12-17 20:38 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Stefan Haberland

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi all,

In commit

  358e7cbf87b4 ("s390/dasd: fix hanging device offline processing")

Fixes tag

  Fixes: 47825e05d93e ("s390/dasd: fix endless loop after read unit address configuration")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 41995342b40c ("s390/dasd: fix endless loop after read unit address configuration")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-12-01 21:44   ` Stephen Rothwell
@ 2020-12-01 21:52     ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2020-12-01 21:52 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux Kernel Mailing List, Linux Next Mailing List

On 12/1/20 2:44 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
>>>
>>> In commit
>>>
>>>   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
>>>
>>> Fixes tag
>>>
>>>   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
>>>
>>> has these problem(s):
>>>
>>>   - SHA1 should be at least 12 digits long
>>>
>>> For the future, this can be fixed by setting core.abbrev to 12 (or more)
>>> or (for git v2.11 or later) just making sure it is not set (or set to
>>> "auto").  
>>
>> It's in Linus's tree, not in -next. The ship has sailed...
> 
> Ummm, 573cc9d095bc is only in your tree as far as I can see ...
> however, I don't really expect these short SHA1 issues to be fixed up
> (as that would require rebasing your tree), just that people will try
> not to do the same in the future.

Hmm yes, but that's because I botched something up. I'll take a look!

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-12-01 21:09 ` Jens Axboe
@ 2020-12-01 21:44   ` Stephen Rothwell
  2020-12-01 21:52     ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-12-01 21:44 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Christoph Hellwig, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

Hi Jens,

On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
> > 
> > In commit
> > 
> >   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
> > 
> > Fixes tag
> > 
> >   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
> > 
> > has these problem(s):
> > 
> >   - SHA1 should be at least 12 digits long
> > 
> > For the future, this can be fixed by setting core.abbrev to 12 (or more)
> > or (for git v2.11 or later) just making sure it is not set (or set to
> > "auto").  
> 
> It's in Linus's tree, not in -next. The ship has sailed...

Ummm, 573cc9d095bc is only in your tree as far as I can see ...
however, I don't really expect these short SHA1 issues to be fixed up
(as that would require rebasing your tree), just that people will try
not to do the same in the future.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-12-01 21:02 Stephen Rothwell
@ 2020-12-01 21:09 ` Jens Axboe
  2020-12-01 21:44   ` Stephen Rothwell
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2020-12-01 21:09 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Linux Kernel Mailing List, Linux Next Mailing List

On 12/1/20 2:02 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
> 
> Fixes tag
> 
>   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> For the future, this can be fixed by setting core.abbrev to 12 (or more)
> or (for git v2.11 or later) just making sure it is not set (or set to
> "auto").

It's in Linus's tree, not in -next. The ship has sailed...

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-12-01 21:02 Stephen Rothwell
  2020-12-01 21:09 ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-12-01 21:02 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Christoph Hellwig, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")

Fixes tag

  Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")

has these problem(s):

  - SHA1 should be at least 12 digits long

For the future, this can be fixed by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-11-30 21:28 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2020-11-30 21:28 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Christoph Hellwig, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  107673613884 ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")

Fixes tag

  Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")

has these problem(s):

  - SHA1 should be at least 12 digits long

For the future, this can be fixed by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-09-24 22:38 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2020-09-24 22:38 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xiao Ni, Song Liu

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi all,

In commit

  10988d55ae96 ("md/raid10: Change the return type of raid10_handle_discard to int")

Fixes tag

  fixes: 8f694215ae4c (md/raid10: improve raid10 discard request)

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 828d14fd7a6c ("md/raid10: improve raid10 discard request")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-07-29 22:12 ` Stephen Rothwell
@ 2020-07-30 15:04   ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2020-07-30 15:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Chaitanya Kulkarni, Christoph Hellwig

On 7/29/20 4:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> [Just adding cc's]
> 
> On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> In commit
>>
>>   64d452b3560b ("nvme-loop: set ctrl state connecting after init")
>>
>> Fixes tag
>>
>>   Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
>>
>> has these problem(s):
>>
>>   - Target SHA1 does not exist
>>
>> I can't easily find what commit is meant :-(

Yeah, it's obviously garbage, the commit doesn't even exist, let alone the sha.

Chaitanya, where's this from??

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-07-29 22:08 Stephen Rothwell
@ 2020-07-29 22:12 ` Stephen Rothwell
  2020-07-30 15:04   ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-07-29 22:12 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Chaitanya Kulkarni, Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi all,

[Just adding cc's]

On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   64d452b3560b ("nvme-loop: set ctrl state connecting after init")
> 
> Fixes tag
> 
>   Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> I can't easily find what commit is meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-07-29 22:08 Stephen Rothwell
  2020-07-29 22:12 ` Stephen Rothwell
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-07-29 22:08 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi all,

In commit

  64d452b3560b ("nvme-loop: set ctrl state connecting after init")

Fixes tag

  Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")

has these problem(s):

  - Target SHA1 does not exist

I can't easily find what commit is meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-29 22:36     ` Stephen Rothwell
@ 2020-06-29 22:45       ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2020-06-29 22:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Pavel Begunkov, Linux Next Mailing List, Linux Kernel Mailing List

On 6/29/20 4:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
>>> On 29/06/2020 01:05, Stephen Rothwell wrote:  
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")  
>>>
>>> Jens, could you please fix this up after me?
>>> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a  
>>
>> I don't think that's a grave enough concern to rebase, it's just "missing" a
>> single digit of the sha.
> 
> Yeah, its more of a "please fix your git config". :-)

Agree! But I'm guessing that Pavel did this manually, which I end up
doing a lot too... And then mistakes happen.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-29 16:25   ` Jens Axboe
@ 2020-06-29 22:36     ` Stephen Rothwell
  2020-06-29 22:45       ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-06-29 22:36 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Pavel Begunkov, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Hi all,

On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> > On 29/06/2020 01:05, Stephen Rothwell wrote:  
> >> Hi all,
> >>
> >> In commit
> >>
> >>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> >>
> >> Fixes tag
> >>
> >>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")  
> > 
> > Jens, could you please fix this up after me?
> > full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a  
> 
> I don't think that's a grave enough concern to rebase, it's just "missing" a
> single digit of the sha.

Yeah, its more of a "please fix your git config". :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-29 16:21 ` Pavel Begunkov
@ 2020-06-29 16:25   ` Jens Axboe
  2020-06-29 22:36     ` Stephen Rothwell
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2020-06-29 16:25 UTC (permalink / raw)
  To: Pavel Begunkov, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> On 29/06/2020 01:05, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>
>> Fixes tag
>>
>>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
> 
> Jens, could you please fix this up after me?
> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

I don't think that's a grave enough concern to rebase, it's just "missing" a
single digit of the sha.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-28 22:05 Stephen Rothwell
@ 2020-06-29 16:21 ` Pavel Begunkov
  2020-06-29 16:25   ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Pavel Begunkov @ 2020-06-29 16:21 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 29/06/2020 01:05, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> 
> Fixes tag
> 
>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

Jens, could you please fix this up after me?
full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

-- 
Pavel Begunkov

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-06-28 22:05 Stephen Rothwell
  2020-06-29 16:21 ` Pavel Begunkov
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-06-28 22:05 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pavel Begunkov

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")

Fixes tag

  Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  5:12       ` Stephen Rothwell
@ 2020-06-28 13:38         ` Jens Axboe
  0 siblings, 0 replies; 59+ messages in thread
From: Jens Axboe @ 2020-06-28 13:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Konstantin Ryabitsev, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

On 6/26/20 11:12 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Right, but that's what git format-patch does when the line is long.
> 
> I just tested, and "git format-patch" (for me) does *not* split those lines.

Huh, I could have sworn it's done that for me in the past, just like it
splits the Subject: line into multiple lines as well (that I just did
verify that it still does).

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  5:01     ` Stephen Rothwell
@ 2020-06-27 11:18       ` Pavel Begunkov
  0 siblings, 0 replies; 59+ messages in thread
From: Pavel Begunkov @ 2020-06-27 11:18 UTC (permalink / raw)
  To: Stephen Rothwell, Konstantin Ryabitsev
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List

On 27/06/2020 08:01, Stephen Rothwell wrote:
> Hi Konstantin,
> 
> On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>>
>> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:  
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>>
>>>> has these problem(s):
>>>>
>>>>   - Subject has leading but no trailing parentheses
>>>>   - Subject has leading but no trailing quotes
>>>>
>>>> Please do not split Fixes tags over more than one line.  
>>>
>>> Gah, that's b4 messing it up. I've actually seen this before, but
>>> I caught it. If you look at the actual commit, this is what the b4
>>> output ends up being for the fixes line:
>>>
>>> [snip]
>>> io_kiocb's result and iopoll_completed")
>>>
>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> even though it's correct in the email. I'm guessing some issue having to
>>> do with the longer line?  
>>
>> Yeah, I'll try to see if there's something I can do here, but it's going 
>> to be largely guesswork. Here's the original email:
>>
>> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
>>
>> The Fixes: footer really does get split into two. It's not that hard to 
>> add logic just for the Fixes tag (since it conveniently follows a set 
>> pattern), but finding a universal fix for split footers will be more 
>> difficult.
>>
>> I'll see what I can do.
> 
> But (what am I missing?) the Fixes: tag has been split over 2 lines in
> the original message ... on lore and my copy.  There is nothing for b4
> to do here, the author needs to do this right.

Yes, it was split from the beginning. It's really a shame it can't handle
multi-line tags, but well, I'll keep that in mind.

Though, it's curious how

```
Fixes ("line1
line2")
```

became 
```
line2")

Fixes ("line1
```

And that's what the rest of the thread is about.

-- 
Pavel Begunkov

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  2:25     ` Jens Axboe
@ 2020-06-27  5:12       ` Stephen Rothwell
  2020-06-28 13:38         ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-06-27  5:12 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Konstantin Ryabitsev, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hi Jens,

On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> Right, but that's what git format-patch does when the line is long.

I just tested, and "git format-patch" (for me) does *not* split those lines.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  1:56   ` Konstantin Ryabitsev
  2020-06-27  2:25     ` Jens Axboe
@ 2020-06-27  5:01     ` Stephen Rothwell
  2020-06-27 11:18       ` Pavel Begunkov
  1 sibling, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-06-27  5:01 UTC (permalink / raw)
  To: Konstantin Ryabitsev
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List,
	Pavel Begunkov

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

Hi Konstantin,

On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> > On 6/26/20 5:07 PM, Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > In commit
> > > 
> > >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > > 
> > > has these problem(s):
> > > 
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > > 
> > > Please do not split Fixes tags over more than one line.  
> > 
> > Gah, that's b4 messing it up. I've actually seen this before, but
> > I caught it. If you look at the actual commit, this is what the b4
> > output ends up being for the fixes line:
> > 
> > [snip]
> > io_kiocb's result and iopoll_completed")
> > 
> > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > 
> > even though it's correct in the email. I'm guessing some issue having to
> > do with the longer line?  
> 
> Yeah, I'll try to see if there's something I can do here, but it's going 
> to be largely guesswork. Here's the original email:
> 
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
> 
> The Fixes: footer really does get split into two. It's not that hard to 
> add logic just for the Fixes tag (since it conveniently follows a set 
> pattern), but finding a universal fix for split footers will be more 
> difficult.
> 
> I'll see what I can do.

But (what am I missing?) the Fixes: tag has been split over 2 lines in
the original message ... on lore and my copy.  There is nothing for b4
to do here, the author needs to do this right.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  1:56   ` Konstantin Ryabitsev
@ 2020-06-27  2:25     ` Jens Axboe
  2020-06-27  5:12       ` Stephen Rothwell
  2020-06-27  5:01     ` Stephen Rothwell
  1 sibling, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2020-06-27  2:25 UTC (permalink / raw)
  To: Konstantin Ryabitsev
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

On 6/26/20 7:56 PM, Konstantin Ryabitsev wrote:
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>
>>> Fixes tag
>>>
>>>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> has these problem(s):
>>>
>>>   - Subject has leading but no trailing parentheses
>>>   - Subject has leading but no trailing quotes
>>>
>>> Please do not split Fixes tags over more than one line.
>>
>> Gah, that's b4 messing it up. I've actually seen this before, but
>> I caught it. If you look at the actual commit, this is what the b4
>> output ends up being for the fixes line:
>>
>> [snip]
>> io_kiocb's result and iopoll_completed")
>>
>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>
>> even though it's correct in the email. I'm guessing some issue having to
>> do with the longer line?
> 
> Yeah, I'll try to see if there's something I can do here, but it's going 
> to be largely guesswork. Here's the original email:
> 
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
> 
> The Fixes: footer really does get split into two. It's not that hard to 
> add logic just for the Fixes tag (since it conveniently follows a set 
> pattern), but finding a universal fix for split footers will be more 
> difficult.

Right, but that's what git format-patch does when the line is long. Do
we have other tags where that's a concern? If not, then the fix should
be solid I think.

> I'll see what I can do.

Thanks!

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  1:32 ` Jens Axboe
@ 2020-06-27  1:56   ` Konstantin Ryabitsev
  2020-06-27  2:25     ` Jens Axboe
  2020-06-27  5:01     ` Stephen Rothwell
  0 siblings, 2 replies; 59+ messages in thread
From: Konstantin Ryabitsev @ 2020-06-27  1:56 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > 
> > Fixes tag
> > 
> >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > 
> > has these problem(s):
> > 
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.
> 
> Gah, that's b4 messing it up. I've actually seen this before, but
> I caught it. If you look at the actual commit, this is what the b4
> output ends up being for the fixes line:
> 
> [snip]
> io_kiocb's result and iopoll_completed")
> 
> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> 
> even though it's correct in the email. I'm guessing some issue having to
> do with the longer line?

Yeah, I'll try to see if there's something I can do here, but it's going 
to be largely guesswork. Here's the original email:

https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw

The Fixes: footer really does get split into two. It's not that hard to 
add logic just for the Fixes tag (since it conveniently follows a set 
pattern), but finding a universal fix for split footers will be more 
difficult.

I'll see what I can do.

-K

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-26 23:07 Stephen Rothwell
@ 2020-06-27  1:32 ` Jens Axboe
  2020-06-27  1:56   ` Konstantin Ryabitsev
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2020-06-27  1:32 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Pavel Begunkov, Konstantin Ryabitsev

On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> 
> Fixes tag
> 
>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Gah, that's b4 messing it up. I've actually seen this before, but
I caught it. If you look at the actual commit, this is what the b4
output ends up being for the fixes line:

[snip]
io_kiocb's result and iopoll_completed")

Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize

even though it's correct in the email. I'm guessing some issue having to
do with the longer line?

CC Konstantin.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-06-26 23:07 Stephen Rothwell
  2020-06-27  1:32 ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2020-06-26 23:07 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pavel Begunkov

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")

Fixes tag

  Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-05-28 21:10 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2020-05-28 21:10 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Hi all,

In commit

  dc35ada4251f ("block: fix a warning when blkdev.h is included for !CONFIG_BLOCK builds")

Fixes tag

  Fixes: 956d510ee78 ("block: add disk/bio-based accounting helpers")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-03-22 14:08 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2020-03-22 14:08 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhiqiang Liu,
	Feilong Lin

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi all,

In commit

  2f95fa5c955d ("block, bfq: fix use-after-free in bfq_idle_slice_timer_body")

Fixes tag

  Fixes: aee69d78d ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-10-24  6:16 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2019-10-24  6:16 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jackie Liu

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  f131f240623a ("io_uring: cq entries should be equal to (or greater) than sq entries")

Fixes tag

  Fixes: 95d8765bd9f2 ("io_uring: allow application controlled CQ ring size")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: f3cbc97703c5 ("io_uring: allow application controlled CQ ring size")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-10-10 17:36 ` Bart Van Assche
@ 2019-10-11  0:42   ` Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2019-10-11  0:42 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Hi Bart,

On Thu, 10 Oct 2019 10:36:36 -0700 Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> > 
> >    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> The above fixes tag follows the recommended format except that it is 
> followed by a kernel version number. Is there a recommended format for 
> embedding the kernel version number in a Fixes: tag? I think that 
> information is useful. I haven't found any recommendations for how to do 
> that in Documentation/process/submitting-patches.rst.

I have not seen any recommended way to do that, but there is no
necessity to embed the version as it can easily be derived:

$ git describe --contains e34cbd307477
v4.10-rc1~153^2~94

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-10-07 20:16 Stephen Rothwell
@ 2019-10-10 17:36 ` Bart Van Assche
  2019-10-11  0:42   ` Stephen Rothwell
  0 siblings, 1 reply; 59+ messages in thread
From: Bart Van Assche @ 2019-10-10 17:36 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> In commit
> 
>    1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")
> 
> Fixes tag
> 
>    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> has these problem(s):
> 
>    - Subject has leading but no trailing quotes
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Hi Stephen,

The above fixes tag follows the recommended format except that it is 
followed by a kernel version number. Is there a recommended format for 
embedding the kernel version number in a Fixes: tag? I think that 
information is useful. I haven't found any recommendations for how to do 
that in Documentation/process/submitting-patches.rst.

Thanks,

Bart.



^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-10-07 20:16 Stephen Rothwell
  2019-10-10 17:36 ` Bart Van Assche
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2019-10-07 20:16 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")

Fixes tag

  Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-09-10 14:57 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:57 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jackie Liu

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi all,

In commit

  8776f3fa15a5 ("io_uring: fix wrong sequence setting logic")

Fixes tag

  Fixes: de0617e4671 ("io_uring: add support for marking commands as draining")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-07-11 22:03 ` Jens Axboe
@ 2019-07-12  8:47   ` Minwoo Im
  0 siblings, 0 replies; 59+ messages in thread
From: Minwoo Im @ 2019-07-12  8:47 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On 19-07-11 16:03:22, Jens Axboe wrote:
> On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> > 
> > Fixes tag
> > 
> >    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> > 
> > has these problem(s):
> > 
> >    - SHA1 should be at least 12 digits long
> >      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >      or later) just making sure it is not set (or set to "auto").
> >    - Subject has leading but no trailing parentheses
> >    - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.  Also do not
> > include blank lines among the tags.

I'm sorry for noises here.  I will keep that in mind.

Thanks Stephen,

> 
> I should have caught that. Since it's top-of-tree and recent, I'll
> amend it.

Jens,  I will do it from the next time.  Thanks for ammend.

^ permalink raw reply	[flat|nested] 59+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-07-11 21:35 Stephen Rothwell
@ 2019-07-11 22:03 ` Jens Axboe
  2019-07-12  8:47   ` Minwoo Im
  0 siblings, 1 reply; 59+ messages in thread
From: Jens Axboe @ 2019-07-11 22:03 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Minwoo Im

On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> 
> Fixes tag
> 
>    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> 
> has these problem(s):
> 
>    - SHA1 should be at least 12 digits long
>      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>      or later) just making sure it is not set (or set to "auto").
>    - Subject has leading but no trailing parentheses
>    - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also do not
> include blank lines among the tags.

I should have caught that. Since it's top-of-tree and recent, I'll
amend it.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-07-11 21:35 Stephen Rothwell
  2019-07-11 22:03 ` Jens Axboe
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2019-07-11 21:35 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Minwoo Im

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

In commit

  8f3858763d33 ("nvme: fix NULL deref for fabrics options")

Fixes tag

  Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also do not
include blank lines among the tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-02-21 20:39 Stephen Rothwell
  0 siblings, 0 replies; 59+ messages in thread
From: Stephen Rothwell @ 2019-02-21 20:39 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ming Lei

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Jens,

In commit

  8f4e80da764e ("block: bounce: make sure that bvec table is updated")

Fixes tag

  Fixes: 6dc4f100c ("block: allow bio_for_each_segment_all() to iterate over multi-page bvec")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread

end of thread, other threads:[~2022-01-03 21:25 UTC | newest]

Thread overview: 59+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22  3:24 linux-next: Fixes tag needs some work in the block tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2022-01-03 21:25 Stephen Rothwell
2021-10-19 21:46 Stephen Rothwell
2021-05-18 22:01 Stephen Rothwell
2021-05-19 19:25 ` Sergey Shtylyov
2021-05-19 21:55   ` Jens Axboe
2021-05-05 22:23 Stephen Rothwell
2021-05-09  1:49 ` Minwoo Im
2021-03-04 23:52 Stephen Rothwell
2021-03-05  0:26 ` Jens Axboe
2021-03-05  7:46   ` Christoph Hellwig
2021-03-05 15:53     ` Jens Axboe
2021-02-22 21:01 Stephen Rothwell
2021-02-22 21:15 ` Chaitanya Kulkarni
2021-02-20  4:51 Stephen Rothwell
2021-02-20  4:57 ` Jens Axboe
2021-02-04 20:13 Stephen Rothwell
2021-01-25  9:40 Stephen Rothwell
2021-01-25 18:35 ` Paolo Valente
2021-01-25 18:39   ` Jens Axboe
2021-01-26 13:29     ` Jan Kara
2021-01-26 15:47       ` Jens Axboe
2021-01-26 16:01         ` Jan Kara
2021-01-26 16:05           ` Jens Axboe
2020-12-17 20:38 Stephen Rothwell
2020-12-17 20:42 ` Jens Axboe
2020-12-01 21:02 Stephen Rothwell
2020-12-01 21:09 ` Jens Axboe
2020-12-01 21:44   ` Stephen Rothwell
2020-12-01 21:52     ` Jens Axboe
2020-11-30 21:28 Stephen Rothwell
2020-09-24 22:38 Stephen Rothwell
2020-07-29 22:08 Stephen Rothwell
2020-07-29 22:12 ` Stephen Rothwell
2020-07-30 15:04   ` Jens Axboe
2020-06-28 22:05 Stephen Rothwell
2020-06-29 16:21 ` Pavel Begunkov
2020-06-29 16:25   ` Jens Axboe
2020-06-29 22:36     ` Stephen Rothwell
2020-06-29 22:45       ` Jens Axboe
2020-06-26 23:07 Stephen Rothwell
2020-06-27  1:32 ` Jens Axboe
2020-06-27  1:56   ` Konstantin Ryabitsev
2020-06-27  2:25     ` Jens Axboe
2020-06-27  5:12       ` Stephen Rothwell
2020-06-28 13:38         ` Jens Axboe
2020-06-27  5:01     ` Stephen Rothwell
2020-06-27 11:18       ` Pavel Begunkov
2020-05-28 21:10 Stephen Rothwell
2020-03-22 14:08 Stephen Rothwell
2019-10-24  6:16 Stephen Rothwell
2019-10-07 20:16 Stephen Rothwell
2019-10-10 17:36 ` Bart Van Assche
2019-10-11  0:42   ` Stephen Rothwell
2019-09-10 14:57 Stephen Rothwell
2019-07-11 21:35 Stephen Rothwell
2019-07-11 22:03 ` Jens Axboe
2019-07-12  8:47   ` Minwoo Im
2019-02-21 20:39 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).