LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bryan Brattlof <hello@bryanbrattlof.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()
Date: Sun, 22 Aug 2021 13:47:33 +0000	[thread overview]
Message-ID: <20210822134723.cuzzogvujokqiw3l@h510> (raw)
In-Reply-To: <2537053.yL3VPc0Jk4@localhost.localdomain>

On 22.08.2021 08:25, Fabio M. De Francesco wrote:
> On Sunday, August 22, 2021 1:55:29 AM CEST Bryan Brattlof wrote:
> > The sdio_read_mem() function is unused. We can remove it.
> >
> > Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
> >  drivers/staging/rtl8723bs/include/rtw_io.h |  2 --
> >  2 files changed, 13 deletions(-)
>
> This change adds a build warning, which is not allowed.
>
> Please merge this, and the 4/6 patch into a single change, so that it
> all is removed together, causing no build warnings at any point in time.
>

Will do.

Thanks for the review, Fabio!
~Bryan

>
> thanks,
>
> Fabio
>
>
>


      reply	other threads:[~2021-08-22 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21 23:55 Bryan Brattlof
2021-08-22  6:25 ` Fabio M. De Francesco
2021-08-22 13:47   ` Bryan Brattlof [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210822134723.cuzzogvujokqiw3l@h510 \
    --to=hello@bryanbrattlof.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).