LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()
@ 2021-08-21 23:55 Bryan Brattlof
  2021-08-22  6:25 ` Fabio M. De Francesco
  0 siblings, 1 reply; 3+ messages in thread
From: Bryan Brattlof @ 2021-08-21 23:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Bryan Brattlof, linux-staging, linux-kernel

The sdio_read_mem() function is unused. We can remove it.

Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
 drivers/staging/rtl8723bs/include/rtw_io.h |  2 --
 2 files changed, 13 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 6bd662928ab6..019ace4b8564 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -299,16 +299,6 @@ static s32 sdio_write32(struct intf_hdl *intfhdl, u32 addr, u32 val)
 	return err;
 }

-static void sdio_read_mem(
-	struct intf_hdl *intfhdl,
-	u32 addr,
-	u32 cnt,
-	u8 *rmem
-)
-{
-	sdio_readN(intfhdl, addr, cnt, rmem);
-}
-
 /*
  * Description:
  *Read from RX FIFO
@@ -410,7 +400,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
 	ops->_read8 = &sdio_read8;
 	ops->_read16 = &sdio_read16;
 	ops->_read32 = &sdio_read32;
-	ops->_read_mem = &sdio_read_mem;
 	ops->_read_port = &sdio_read_port;

 	ops->_write8 = &sdio_write8;
diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
index 0753e20cfaa2..43102f65bddd 100644
--- a/drivers/staging/rtl8723bs/include/rtw_io.h
+++ b/drivers/staging/rtl8723bs/include/rtw_io.h
@@ -89,8 +89,6 @@ struct _io_ops {
 		int (*_write16_async)(struct intf_hdl *pintfhdl, u32 addr, u16 val);
 		int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);

-		void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
-
 		void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);

 		u32 (*_read_interrupt)(struct intf_hdl *pintfhdl, u32 addr);
--
2.30.2



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()
  2021-08-21 23:55 [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem() Bryan Brattlof
@ 2021-08-22  6:25 ` Fabio M. De Francesco
  2021-08-22 13:47   ` Bryan Brattlof
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio M. De Francesco @ 2021-08-22  6:25 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Bryan Brattlof
  Cc: Bryan Brattlof, linux-staging, linux-kernel

On Sunday, August 22, 2021 1:55:29 AM CEST Bryan Brattlof wrote:
> The sdio_read_mem() function is unused. We can remove it.
> 
> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
>  drivers/staging/rtl8723bs/include/rtw_io.h |  2 --
>  2 files changed, 13 deletions(-)

This change adds a build warning, which is not allowed.

Please merge this, and the 4/6 patch into a single change, so that it
all is removed together, causing no build warnings at any point in time.

thanks,

Fabio




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem()
  2021-08-22  6:25 ` Fabio M. De Francesco
@ 2021-08-22 13:47   ` Bryan Brattlof
  0 siblings, 0 replies; 3+ messages in thread
From: Bryan Brattlof @ 2021-08-22 13:47 UTC (permalink / raw)
  To: Fabio M. De Francesco; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel

On 22.08.2021 08:25, Fabio M. De Francesco wrote:
> On Sunday, August 22, 2021 1:55:29 AM CEST Bryan Brattlof wrote:
> > The sdio_read_mem() function is unused. We can remove it.
> >
> > Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
> >  drivers/staging/rtl8723bs/include/rtw_io.h |  2 --
> >  2 files changed, 13 deletions(-)
>
> This change adds a build warning, which is not allowed.
>
> Please merge this, and the 4/6 patch into a single change, so that it
> all is removed together, causing no build warnings at any point in time.
>

Will do.

Thanks for the review, Fabio!
~Bryan

>
> thanks,
>
> Fabio
>
>
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-22 13:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 23:55 [PATCH 3/6] staging: rtl8723bs: remove sdio_read_mem() Bryan Brattlof
2021-08-22  6:25 ` Fabio M. De Francesco
2021-08-22 13:47   ` Bryan Brattlof

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).