From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69DCC4338F for ; Sun, 22 Aug 2021 17:04:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCF7561261 for ; Sun, 22 Aug 2021 17:04:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231878AbhHVRFX (ORCPT ); Sun, 22 Aug 2021 13:05:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231393AbhHVRFW (ORCPT ); Sun, 22 Aug 2021 13:05:22 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EEF9C061575 for ; Sun, 22 Aug 2021 10:04:41 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1mHqtf-0008Kr-7j; Sun, 22 Aug 2021 19:04:35 +0200 Date: Sun, 22 Aug 2021 19:04:35 +0200 From: Martin Kaiser To: Phillip Potter Cc: Greg Kroah-Hartman , Larry Finger , Dan Carpenter , Michael Straube , linux-staging@lists.linux.dev, Linux Kernel Mailing List Subject: Re: [PATCH 01/10] staging: r8188eu: remove unnecessary cast Message-ID: <20210822170435.ijsi7ep7rbdu4i3k@viti.kaiser.cx> References: <20210821164859.4351-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Phillip Potter (phil@philpotter.co.uk): > On Sat, 21 Aug 2021 at 17:49, Martin Kaiser wrote: > > name is a const char * by default. This type should be ok for r8188eu. > > Signed-off-by: Martin Kaiser > > --- > > drivers/staging/r8188eu/os_dep/usb_intf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c > > index e002070f7fba..72556ac10d7d 100644 > > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c > > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c > > @@ -61,7 +61,7 @@ struct rtw_usb_drv { > > }; > > static struct rtw_usb_drv rtl8188e_usb_drv = { > > - .usbdrv.name = (char *)"r8188eu", > > + .usbdrv.name = "r8188eu", > > .usbdrv.probe = rtw_drv_init, > > .usbdrv.disconnect = rtw_dev_remove, > > .usbdrv.id_table = rtw_usb_id_tbl, > > -- > > 2.20.1 Hi Phil, > Looks ok to me, thanks. I would consider using a cover letter style > [PATCH 00/10] style approach as an addition in future though, just my > personal opinion. > Acked-by: Phillip Potter Thanks. This series is a mixed bag of things I found while poking around in the code. So I didn't think there was anything useful to say in a cover letter. Still, I see your point, it makes sense for a patch series to have a cover letter, I'll add one for future patch series. Best regards, Martin