LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] HSI: cmt_speech: unmark comments as kernel-doc
@ 2021-08-22 16:38 Randy Dunlap
  2021-08-22 17:18 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-08-22 16:38 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, kernel test robot, Sebastian Reichel,
	Aditya Srivastava, Kai Vehmanen

Fix build warnings from the kernel test robot:

drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Block until pending data transfers have completed.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Aditya Srivastava <yashsri421@gmail.com>
Cc: Kai Vehmanen <kai.vehmanen@nokia.com>
---
 drivers/hsi/clients/cmt_speech.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20210820.orig/drivers/hsi/clients/cmt_speech.c
+++ linux-next-20210820/drivers/hsi/clients/cmt_speech.c
@@ -827,7 +827,7 @@ static int check_buf_params(struct cs_hs
 	return r;
 }
 
-/**
+/*
  * Block until pending data transfers have completed.
  */
 static int cs_hsi_data_sync(struct cs_hsi_iface *hi)
@@ -850,7 +850,7 @@ static int cs_hsi_data_sync(struct cs_hs
 			r = -ERESTARTSYS;
 			goto out;
 		}
-		/**
+		/*
 		 * prepare_to_wait must be called with hi->lock held
 		 * so that callbacks can check for waitqueue_active()
 		 */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] HSI: cmt_speech: unmark comments as kernel-doc
  2021-08-22 16:38 [PATCH] HSI: cmt_speech: unmark comments as kernel-doc Randy Dunlap
@ 2021-08-22 17:18 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2021-08-22 17:18 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, kernel test robot, Sebastian Reichel,
	Aditya Srivastava, Kai Vehmanen

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On Sun 2021-08-22 09:38:38, Randy Dunlap wrote:
> Fix build warnings from the kernel test robot:
> 
> drivers/hsi/clients/cmt_speech.c:831: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>     * Block until pending data transfers have completed.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Aditya Srivastava <yashsri421@gmail.com>
> Cc: Kai Vehmanen <kai.vehmanen@nokia.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

Best regards,
								Pavel

> @@ -827,7 +827,7 @@ static int check_buf_params(struct cs_hs
>  	return r;
>  }
>  
> -/**
> +/*
>   * Block until pending data transfers have completed.
>   */
>  static int cs_hsi_data_sync(struct cs_hsi_iface *hi)
> @@ -850,7 +850,7 @@ static int cs_hsi_data_sync(struct cs_hs
>  			r = -ERESTARTSYS;
>  			goto out;
>  		}
> -		/**
> +		/*
>  		 * prepare_to_wait must be called with hi->lock held
>  		 * so that callbacks can check for waitqueue_active()
>  		 */

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-22 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22 16:38 [PATCH] HSI: cmt_speech: unmark comments as kernel-doc Randy Dunlap
2021-08-22 17:18 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).