From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FC4C4338F for ; Mon, 23 Aug 2021 12:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8CCD613D0 for ; Mon, 23 Aug 2021 12:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236923AbhHWMDh (ORCPT ); Mon, 23 Aug 2021 08:03:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236759AbhHWMDL (ORCPT ); Mon, 23 Aug 2021 08:03:11 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D3FFC0613CF for ; Mon, 23 Aug 2021 05:02:27 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id h13so25962624wrp.1 for ; Mon, 23 Aug 2021 05:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KxckDw2JXa4ldQzXueminO2tKvea3/cdZgsuvf9IC8A=; b=aat7G1oKvN1HFqRl3dmnKk8bBkoOfsPkk6Km4zotqpZsCvkCKxxmVaApYeKoMgTX9V vNvFJupOymowYdrd6iZLaPzrSjJ5/cu8J2q68M7uBi0HgQm96U4e8xqAmPVRb7t16+WN jteDT6LW6M/ZdW5qc4+zDkDk2ITGjNvLFdBJx5q4NWS9QZhBkViFLUbV9L0stJhkO1CD hGdE72+qjPG7NwHF0fvnbkNCG/hIxnaZHA54m5XJpUDqtKQ8LODxKnq2ofuai8JdYXR4 koTDjOPezwlqUYLFXE8Yg3ZB2LXgR5HZrzWEQ7iAqygDydV6PcZhi+rEg1Idylkw4ZvY evuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KxckDw2JXa4ldQzXueminO2tKvea3/cdZgsuvf9IC8A=; b=EA96cet5GsawlGjc2fU2OkcvKs2hkhbv/wLUq7avyb2mJ6+PDbY0RfnAai26GflIO5 o3Ksqvl6lEURlhb0D3tIbagWfe1muKOitwlsvR7BgKjISIE7IEv3bNJyxGq1n4Ma3Wmr 5+aF7lbTTn8yR9ohSjAOeseYW1JTc7AkUmlo4H6cgfWOxnAKaHF51FjncMkpFIwZzchH Nfs4+df9wQz2xofB85CWwfpaKVY5pE3c5GR3GTIuxo2aYmpcLnxxAExsts9EXS5DK1PI uS6D2mymV+Ihi7/aGr1bZ4VL+yhVgwckEnT3qkmmlQLYpuGBrq/qdo3nqthyUCtVYo2O KGig== X-Gm-Message-State: AOAM530MZ6Tr+A9wCZKF6UPSXDujnALMRZcTj6E0PIOZ0whiGwAppJG5 +PePghqOlYoOz92+/tnX+wo= X-Google-Smtp-Source: ABdhPJwhIv1sa0eZPeWm9ttqpthQs0tDhvklS9rwin04fcsxLWabnd9XRjytnY8vvPnytU3OJQciVg== X-Received: by 2002:a5d:6b8f:: with SMTP id n15mr13311059wrx.241.1629720146209; Mon, 23 Aug 2021 05:02:26 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::3c39]) by smtp.gmail.com with ESMTPSA id g5sm901332wrq.80.2021.08.23.05.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 05:02:25 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 5/8] staging: r8188eu: use is_multicast_ether_addr in core/rtw_security.c Date: Mon, 23 Aug 2021 14:01:03 +0200 Message-Id: <20210823120106.9633-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210823120106.9633-1-straube.linux@gmail.com> References: <20210823120106.9633-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use is_multicast_ether_addr instead of custom macro IS_MCAST, all buffers are properly aligned. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_security.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_security.c b/drivers/staging/r8188eu/core/rtw_security.c index b9ab4b20ed8e..5aa893ab46e9 100644 --- a/drivers/staging/r8188eu/core/rtw_security.c +++ b/drivers/staging/r8188eu/core/rtw_security.c @@ -538,7 +538,7 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmitframe) stainfo = rtw_get_stainfo(&padapter->stapriv, &pattrib->ra[0]); if (stainfo) { - if (IS_MCAST(pattrib->ra)) + if (is_multicast_ether_addr(pattrib->ra)) prwskey = psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XGrpKeyid].skey; else prwskey = &stainfo->dot118021x_UncstKey.skey[0]; @@ -608,7 +608,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) if (prxattrib->encrypt == _TKIP_) { stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); if (stainfo) { - if (IS_MCAST(prxattrib->ra)) { + if (is_multicast_ether_addr(prxattrib->ra)) { if (!psecuritypriv->binstallGrpkey) { res = _FAIL; DBG_88E("%s:rx bc/mc packets, but didn't install group key!!!!!!!!!!\n", __func__); @@ -1188,7 +1188,7 @@ u32 rtw_aes_encrypt(struct adapter *padapter, u8 *pxmitframe) stainfo = rtw_get_stainfo(&padapter->stapriv, &pattrib->ra[0]); if (stainfo) { - if (IS_MCAST(pattrib->ra)) + if (is_multicast_ether_addr(pattrib->ra)) prwskey = psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XGrpKeyid].skey; else prwskey = &stainfo->dot118021x_UncstKey.skey[0]; @@ -1421,7 +1421,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) if (prxattrib->encrypt == _AES_) { stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]); if (stainfo) { - if (IS_MCAST(prxattrib->ra)) { + if (is_multicast_ether_addr(prxattrib->ra)) { /* in concurrent we should use sw descrypt in group key, so we remove this message */ if (!psecuritypriv->binstallGrpkey) { res = _FAIL; -- 2.32.0