LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
@ 2021-08-23 14:10 Tang Bin
2021-08-25 6:12 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-08-23 14:10 UTC (permalink / raw)
To: davem, mkl, wg, kuba; +Cc: linux-can, netdev, linux-kernel, Tang Bin
In the function mpc5xxx_can_probe(), the variale 'data'
has already been determined in the above code, so the
BUG_ON() in this place is useless, remove it.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/net/can/mscan/mpc5xxx_can.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
index 3b7465acd..35892c1ef 100644
--- a/drivers/net/can/mscan/mpc5xxx_can.c
+++ b/drivers/net/can/mscan/mpc5xxx_can.c
@@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)
clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL);
- BUG_ON(!data);
priv->type = data->type;
priv->can.clock.freq = data->get_clock(ofdev, clock_name,
&mscan_clksrc);
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
2021-08-23 14:10 [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG_ON() Tang Bin
@ 2021-08-25 6:12 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2021-08-25 6:12 UTC (permalink / raw)
To: Tang Bin; +Cc: davem, wg, kuba, linux-can, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
On 23.08.2021 22:10:33, Tang Bin wrote:
> In the function mpc5xxx_can_probe(), the variale 'data'
^b
Fixed typo while applying.
> has already been determined in the above code, so the
> BUG_ON() in this place is useless, remove it.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/net/can/mscan/mpc5xxx_can.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
> index 3b7465acd..35892c1ef 100644
> --- a/drivers/net/can/mscan/mpc5xxx_can.c
> +++ b/drivers/net/can/mscan/mpc5xxx_can.c
> @@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)
>
> clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL);
>
> - BUG_ON(!data);
> priv->type = data->type;
> priv->can.clock.freq = data->get_clock(ofdev, clock_name,
> &mscan_clksrc);
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 14:10 [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG_ON() Tang Bin
2021-08-25 6:12 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).