From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFE0C4338F for ; Mon, 23 Aug 2021 17:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CCD8613A8 for ; Mon, 23 Aug 2021 17:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231391AbhHWRCh (ORCPT ); Mon, 23 Aug 2021 13:02:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:45246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230360AbhHWRCg (ORCPT ); Mon, 23 Aug 2021 13:02:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 43C9861371; Mon, 23 Aug 2021 17:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629738113; bh=l1QzhnmDx6j5Mo9ionHtqp1z0YofUbL+bbew5Dj9YYo=; h=From:To:Cc:Subject:Date:From; b=jwyEKZa2USyHYPNvzjfM3aZudsMZ7aBP8c5ive48y1YkK/4Pc8R/0BHplqrNiOrVM BVhnYPAmRZkxaOep6YKhh67gkszdDpwIe8LrRZCTUvJAY8SidJlBEWNO4U3EaSWqjS tbPwsvI2Hrm8N66gj48BaZth7Mn9OnGXqzROfQu1jYFJ3g503bd804avPg2+YGMiyI ouVVl3BIyViT/kNkFiAOlmGya5G+Ke5KHFMkIL5BXGyyhgYGcTlHeLQpYCVu3aAoHb CeHXRLojCWJA3DvmW0/WFjV+66LOQSCtLNtIAiztUWvxaTbq2UpiiUJlygeflYH6fM vEjaH5BrcrXJQ== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: don't ignore writing pages on fsync during checkpoint=disable Date: Mon, 23 Aug 2021 10:01:51 -0700 Message-Id: <20210823170151.1434772-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.33.0.rc2.250.ged5fa647cd-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We must flush dirty pages when calling fsync() during checkpoint=disable. Returning zero makes inode being clear, which fails to flush them when enabling checkpoint back even by sync_inodes_sb(). Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index d4fc5e0d2ffe..45c54332358b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -262,8 +262,7 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, }; unsigned int seq_id = 0; - if (unlikely(f2fs_readonly(inode->i_sb) || - is_sbi_flag_set(sbi, SBI_CP_DISABLED))) + if (unlikely(f2fs_readonly(inode->i_sb))) return 0; trace_f2fs_sync_file_enter(inode); @@ -277,7 +276,7 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, ret = file_write_and_wait_range(file, start, end); clear_inode_flag(inode, FI_NEED_IPU); - if (ret) { + if (ret || is_sbi_flag_set(sbi, SBI_CP_DISABLED)) { trace_f2fs_sync_file_exit(inode, cp_reason, datasync, ret); return ret; } -- 2.33.0.rc2.250.ged5fa647cd-goog