LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFC][PATCH] mm/page_isolation: tracing: trace all test_pages_isolated failures
@ 2021-08-23 20:28 George G. Davis
  2021-08-31 14:53 ` David Hildenbrand
  0 siblings, 1 reply; 5+ messages in thread
From: George G. Davis @ 2021-08-23 20:28 UTC (permalink / raw)
  To: Andrew Morton, open list:MEMORY MANAGEMENT, open list
  Cc: george_davis, Eugeniu Rosca, George G. Davis

From: "George G. Davis" <davis.george@siemens.com>

Some test_pages_isolated failure conditions don't include trace points.
For debugging issues caused by "pinned" pages, make sure to trace all
calls whether they succeed or fail. In this case, a failure case did not
result in a trace point. So add the missing failure case in
test_pages_isolated traces.

Signed-off-by: George G. Davis <davis.george@siemens.com>
---
 mm/page_isolation.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index bddf788f45bf..fff55bb830f9 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -287,6 +287,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
 	unsigned long pfn, flags;
 	struct page *page;
 	struct zone *zone;
+	int ret;
 
 	/*
 	 * Note: pageblock_nr_pages != MAX_ORDER. Then, chunks of free pages
@@ -299,15 +300,21 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
 			break;
 	}
 	page = __first_valid_page(start_pfn, end_pfn - start_pfn);
-	if ((pfn < end_pfn) || !page)
-		return -EBUSY;
+	if ((pfn < end_pfn) || !page) {
+		ret = -EBUSY;
+		goto out;
+	}
+
 	/* Check all pages are free or marked as ISOLATED */
 	zone = page_zone(page);
 	spin_lock_irqsave(&zone->lock, flags);
 	pfn = __test_page_isolated_in_pageblock(start_pfn, end_pfn, isol_flags);
 	spin_unlock_irqrestore(&zone->lock, flags);
 
+	ret = pfn < end_pfn ? -EBUSY : 0;
+
+out:
 	trace_test_pages_isolated(start_pfn, end_pfn, pfn);
 
-	return pfn < end_pfn ? -EBUSY : 0;
+	return ret;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-03 16:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 20:28 [RFC][PATCH] mm/page_isolation: tracing: trace all test_pages_isolated failures George G. Davis
2021-08-31 14:53 ` David Hildenbrand
2021-09-02 22:21   ` George G. Davis
2021-09-03  9:31     ` David Hildenbrand
2021-09-03 16:21       ` George G. Davis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).