LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH linux-next] selftests/powerpc: remove duplicate include
@ 2021-08-24 3:05 CGEL
2021-08-24 14:41 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: CGEL @ 2021-08-24 3:05 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, Paul Mackerras, Shuah Khan, linuxppc-dev,
linux-kselftest, linux-kernel, Changcheng Deng, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Clean up the following includecheck warning:
./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
more than once.
No functional change.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
index 29e5f26..27c083a 100644
--- a/tools/testing/selftests/powerpc/tm/tm-poison.c
+++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
@@ -20,7 +20,6 @@
#include <sched.h>
#include <sys/types.h>
#include <signal.h>
-#include <inttypes.h>
#include "tm.h"
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] selftests/powerpc: remove duplicate include
2021-08-24 3:05 [PATCH linux-next] selftests/powerpc: remove duplicate include CGEL
@ 2021-08-24 14:41 ` Shuah Khan
2021-08-24 16:35 ` Christophe Leroy
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2021-08-24 14:41 UTC (permalink / raw)
To: CGEL, Michael Ellerman
Cc: Benjamin Herrenschmidt, Paul Mackerras, Shuah Khan, linuxppc-dev,
linux-kselftest, linux-kernel, Changcheng Deng, Zeal Robot,
Shuah Khan
On 8/23/21 9:05 PM, CGEL wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Clean up the following includecheck warning:
>
> ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
> more than once.
>
> No functional change.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
> tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
> index 29e5f26..27c083a 100644
> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c
> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
> @@ -20,7 +20,6 @@
> #include <sched.h>
> #include <sys/types.h>
> #include <signal.h>
> -#include <inttypes.h>
>
> #include "tm.h"
>
>
We can't accept this patch. The from and Signed-off-by don't match.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] selftests/powerpc: remove duplicate include
2021-08-24 14:41 ` Shuah Khan
@ 2021-08-24 16:35 ` Christophe Leroy
2021-08-24 16:42 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2021-08-24 16:35 UTC (permalink / raw)
To: Shuah Khan, CGEL, Michael Ellerman
Cc: Zeal Robot, linuxppc-dev, linux-kernel, Paul Mackerras,
linux-kselftest, Changcheng Deng, Shuah Khan
Le 24/08/2021 à 16:41, Shuah Khan a écrit :
> On 8/23/21 9:05 PM, CGEL wrote:
>> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>>
>> Clean up the following includecheck warning:
>>
>> ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
>> more than once.
>>
>> No functional change.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
>> ---
>> tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c
>> b/tools/testing/selftests/powerpc/tm/tm-poison.c
>> index 29e5f26..27c083a 100644
>> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c
>> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
>> @@ -20,7 +20,6 @@
>> #include <sched.h>
>> #include <sys/types.h>
>> #include <signal.h>
>> -#include <inttypes.h>
>> #include "tm.h"
>>
>
> We can't accept this patch. The from and Signed-off-by don't match.
As far as I can see they match:
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Christophe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] selftests/powerpc: remove duplicate include
2021-08-24 16:35 ` Christophe Leroy
@ 2021-08-24 16:42 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2021-08-24 16:42 UTC (permalink / raw)
To: Christophe Leroy, CGEL, Michael Ellerman
Cc: Zeal Robot, linuxppc-dev, linux-kernel, Paul Mackerras,
linux-kselftest, Changcheng Deng, Shuah Khan, Shuah Khan
On 8/24/21 10:35 AM, Christophe Leroy wrote:
>
>
> Le 24/08/2021 à 16:41, Shuah Khan a écrit :
>> On 8/23/21 9:05 PM, CGEL wrote:
>>> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>>>
>>> Clean up the following includecheck warning:
>>>
>>> ./tools/testing/selftests/powerpc/tm/tm-poison.c: inttypes.h is included
>>> more than once.
>>>
>>> No functional change.
>>>
>>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>>> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
>>> ---
>>> tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c b/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> index 29e5f26..27c083a 100644
>>> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> @@ -20,7 +20,6 @@
>>> #include <sched.h>
>>> #include <sys/types.h>
>>> #include <signal.h>
>>> -#include <inttypes.h>
>>> #include "tm.h"
>>>
>>
>> We can't accept this patch. The from and Signed-off-by don't match.
>
> As far as I can see they match:
>
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
>
Yeah. My bad.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-24 16:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 3:05 [PATCH linux-next] selftests/powerpc: remove duplicate include CGEL
2021-08-24 14:41 ` Shuah Khan
2021-08-24 16:35 ` Christophe Leroy
2021-08-24 16:42 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).