LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] cachefiles: remove always false 'datalen < 0' expression
@ 2021-08-24  3:18 Austin Kim
  2021-11-03  8:15 ` Austin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Austin Kim @ 2021-08-24  3:18 UTC (permalink / raw)
  To: dhowells; +Cc: linux-cachefs, linux-kernel, austin.kim

From: Austin Kim <austin.kim@lge.com>

Since 'datalen' is declared as size_t, the 'datalen < 0' expression
is always false. Where size_t is defined as below;

   typedef unsigned long __kernel_ulong_t;
   typedef __kernel_ulong_t __kernel_size_t;
   typedef __kernel_size_t size_t;

So it had better remove unnecessary 'always false' expression.

Signed-off-by: Austin Kim <austin.kim@lge.com>
---
 fs/cachefiles/daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c
index 752c1e43416f..1cfed9e0812a 100644
--- a/fs/cachefiles/daemon.c
+++ b/fs/cachefiles/daemon.c
@@ -225,7 +225,7 @@ static ssize_t cachefiles_daemon_write(struct file *file,
 	if (test_bit(CACHEFILES_DEAD, &cache->flags))
 		return -EIO;
 
-	if (datalen < 0 || datalen > PAGE_SIZE - 1)
+	if (datalen > PAGE_SIZE - 1)
 		return -EOPNOTSUPP;
 
 	/* drag the command string into the kernel so we can parse it */
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cachefiles: remove always false 'datalen < 0' expression
  2021-08-24  3:18 [PATCH] cachefiles: remove always false 'datalen < 0' expression Austin Kim
@ 2021-11-03  8:15 ` Austin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Austin Kim @ 2021-11-03  8:15 UTC (permalink / raw)
  To: dhowells
  Cc: linux-cachefs, Linux Kernel Mailing List, 김동현

2021년 8월 24일 (화) 오후 12:18, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> From: Austin Kim <austin.kim@lge.com>
>
> Since 'datalen' is declared as size_t, the 'datalen < 0' expression
> is always false. Where size_t is defined as below;
>
>    typedef unsigned long __kernel_ulong_t;
>    typedef __kernel_ulong_t __kernel_size_t;
>    typedef __kernel_size_t size_t;
>
> So it had better remove unnecessary 'always false' expression.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
> ---
>  fs/cachefiles/daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c
> index 752c1e43416f..1cfed9e0812a 100644
> --- a/fs/cachefiles/daemon.c
> +++ b/fs/cachefiles/daemon.c
> @@ -225,7 +225,7 @@ static ssize_t cachefiles_daemon_write(struct file *file,
>         if (test_bit(CACHEFILES_DEAD, &cache->flags))
>                 return -EIO;
>
> -       if (datalen < 0 || datalen > PAGE_SIZE - 1)
> +       if (datalen > PAGE_SIZE - 1)
>                 return -EOPNOTSUPP;
>
>         /* drag the command string into the kernel so we can parse it */
> --
> 2.20.1
>

If you are available, would you please review this patch?
It will not take long.

BR,
Austin Kim

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-03  8:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24  3:18 [PATCH] cachefiles: remove always false 'datalen < 0' expression Austin Kim
2021-11-03  8:15 ` Austin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).