From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDD9C4338F for ; Tue, 24 Aug 2021 06:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5ACC61076 for ; Tue, 24 Aug 2021 06:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232440AbhHXG25 (ORCPT ); Tue, 24 Aug 2021 02:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232245AbhHXG2t (ORCPT ); Tue, 24 Aug 2021 02:28:49 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 325CAC0613C1 for ; Mon, 23 Aug 2021 23:28:04 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id d2so15933785qto.6 for ; Mon, 23 Aug 2021 23:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y6XPBNO/FjkntP73oDhopAIjrRJdicZGIZbcxURZOD0=; b=Mnj9uBsNwwF2i/yxIuuPt2hD9TLiyKuHCyR41j2+Grk+HltMdDLIJtuS1gdAvnjiXu vYUr8pVNEbfRcFPDT6fi32j3LFzxPD5/8idpCTh5hRR81B8rQ+0zfkyMPaS4YEM86UnF Zr2PihIO/E9RZKBPY58OqayIA5Gutj3/3VsLW2gW6FrtXKCQ9th1fkfQ/WYF4V0DY112 orSFLTZnmGJa/77h75HMefFkmPqVrID/T1v2ivs5jr7zUgm9fYdDEudAzBVJubgwUzFf bWmxSyxQMPXWWscoojgRdt1GXqeaxgVusCMLS3aK6oRrjPmVyDhPZ7+ra5gq+dhzD6Ic bUSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y6XPBNO/FjkntP73oDhopAIjrRJdicZGIZbcxURZOD0=; b=Gi3xsQV8K9+mEY/f0DsxcJ+Aa2PYSzKr1Oo6ocNOyFr/VWq6JY2xggm7UgIAm1h+vv s8FEWl1aVWyXLtLVU8vT7wiohRha/zSRVehko9X47221uhM/JuWUuVmi+c1MUpA84sUh dyA9F3RXjSi2II1kZUY6JWUSNPbMsT7HBO+j7p4AffZaL0XvCb5ps8XT4wiEis1q+Orw vAnApbAoxdwrXu3Eagsrj+Dg8+D20q9+fGbTADHJr2mUJhZ8EFkyGaP3pGHo0ZnYyvD1 hoaWN18D89o/WUArm6W0klfgKpiMXwfFSbM+1ZTwLGWmKAC3A6Se72JLJvkugxnvuH2R Gm7w== X-Gm-Message-State: AOAM531WlLu8J/LAt6mLQZwH3zov5pUco4tUxUVJ2WJ+OG7sZofum2PW E8z38f/3lPXf30vKvMAHP9g= X-Google-Smtp-Source: ABdhPJyXoIjJGF6325fp6PLh3oNQxqSqioEHOoGZBqeULAfxng5g0O6SFz8pJ+q7Fo8rFbavjlZgQQ== X-Received: by 2002:a05:622a:3c6:: with SMTP id k6mr33334119qtx.29.1629786483411; Mon, 23 Aug 2021 23:28:03 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id f20sm3552057qka.64.2021.08.23.23.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 23:28:03 -0700 (PDT) From: CGEL X-Google-Original-From: CGEL To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot Subject: [PATCH linux-next] kernel:rtmutex: fix boolreturn.cocci warnings Date: Mon, 23 Aug 2021 23:27:56 -0700 Message-Id: <20210824062756.59532-1-deng.changcheng@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jing Yangyang ./kernel/locking/rtmutex.c:375:9-10:WARNING:return of 0/1 in function '__waiter_less' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Reported-by: Zeal Robot Signed-off-by: Jing Yangyang --- kernel/locking/rtmutex.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index 8aaa352..f904f25 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -372,24 +372,24 @@ static __always_inline bool __waiter_less(struct rb_node *a, const struct rb_nod struct rt_mutex_waiter *bw = __node_2_waiter(b); if (rt_mutex_waiter_less(aw, bw)) - return 1; + return true; if (!build_ww_mutex()) - return 0; + return false; if (rt_mutex_waiter_less(bw, aw)) - return 0; + return false; /* NOTE: relies on waiter->ww_ctx being set before insertion */ if (aw->ww_ctx) { if (!bw->ww_ctx) - return 1; + return true; return (signed long)(aw->ww_ctx->stamp - bw->ww_ctx->stamp) < 0; } - return 0; + return false; } static __always_inline void -- 1.8.3.1