From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F17FC4338F for ; Tue, 24 Aug 2021 13:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 580BC61262 for ; Tue, 24 Aug 2021 13:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237603AbhHXNmX (ORCPT ); Tue, 24 Aug 2021 09:42:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:55842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237403AbhHXNmT (ORCPT ); Tue, 24 Aug 2021 09:42:19 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B698F61245; Tue, 24 Aug 2021 13:41:34 +0000 (UTC) Date: Tue, 24 Aug 2021 09:41:28 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: CGEL , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot Subject: Re: [PATCH linux-next] kernel:fair: fix boolreturn.cocci warnings Message-ID: <20210824094128.58898319@oasis.local.home> In-Reply-To: References: <20210824062359.59474-1-deng.changcheng@zte.com.cn> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2021 10:22:49 +0200 Peter Zijlstra wrote: > On Tue, Aug 24, 2021 at 10:15:54AM +0200, Peter Zijlstra wrote: > > On Mon, Aug 23, 2021 at 11:23:59PM -0700, CGEL wrote: > > > From: Jing Yangyang > > > > > > ./kernel/sched/fair.c:9638:9-10:WARNING: return of 0/1 in function > > > 'imbalanced_active_balance' with return type bool > > > > > > Return statements in functions returning bool should use true/false > > > instead of 1/0. > > > > > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > > > > > Reported-by: Zeal Robot > > > Signed-off-by: Jing Yangyang > > > > *sigh*, another stupid robot sending stupid patches.. > > > > /me goes create another mail filter... > > Here, the hunk of sieve script, incase other people want to use it too. > > > #SCRIPTNAME: Zeal Robot > if body :text :contains "Reported-by: Zeal Robot " > { > fileinto "SPAM"; > stop; > } Doesn't hurt to just take the patch and then you wont have to spend time on new robots flagging this as a "bug". -- Steve