LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mathias Nyman <mathias.nyman@intel.com>, Alan Stern <stern@rowland.harvard.edu> Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <chris.chiu@canonical.com> Subject: [RFC PATCH 4/5] usb: core: hcd-pci: Let usb_hcd_pci_probe() indicate if RH has to be registered Date: Tue, 24 Aug 2021 16:23:01 +0530 [thread overview] Message-ID: <20210824105302.25382-5-kishon@ti.com> (raw) In-Reply-To: <20210824105302.25382-1-kishon@ti.com> No functional change. Add __usb_hcd_pci_probe() which takes "register_hub" flag that indicates if roothub (RH) has to be registered or not. This is in preparation for allowing xhci-pci to register roothub after the shared hcd is created. The interface for usb_hcd_pci_probe() is not modified to make sure there are minimal code changes. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/usb/core/hcd-pci.c | 11 ++++++----- include/linux/usb/hcd.h | 8 +++++--- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c index d630cccd2e6e..65c1f9aee4d1 100644 --- a/drivers/usb/core/hcd-pci.c +++ b/drivers/usb/core/hcd-pci.c @@ -160,6 +160,7 @@ static void ehci_wait_for_companions(struct pci_dev *pdev, struct usb_hcd *hcd, * @dev: USB Host Controller being probed * @id: pci hotplug id connecting controller to HCD framework * @driver: USB HC driver handle + * @register_hub: Flag to indicate of roothub has to be registered or not * * Context: task context, might sleep * @@ -171,8 +172,8 @@ static void ehci_wait_for_companions(struct pci_dev *pdev, struct usb_hcd *hcd, * * Return: 0 if successful. */ -int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id, - const struct hc_driver *driver) +int __usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id, + const struct hc_driver *driver, bool register_hub) { struct usb_hcd *hcd; int retval; @@ -262,7 +263,7 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id, down_write(&companions_rwsem); dev_set_drvdata(&dev->dev, hcd); for_each_companion(dev, hcd, ehci_pre_add); - retval = usb_add_hcd(hcd, hcd_irq, IRQF_SHARED); + retval = __usb_add_hcd(hcd, hcd_irq, IRQF_SHARED, register_hub); if (retval != 0) dev_set_drvdata(&dev->dev, NULL); for_each_companion(dev, hcd, ehci_post_add); @@ -270,7 +271,7 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id, } else { down_read(&companions_rwsem); dev_set_drvdata(&dev->dev, hcd); - retval = usb_add_hcd(hcd, hcd_irq, IRQF_SHARED); + retval = __usb_add_hcd(hcd, hcd_irq, IRQF_SHARED, register_hub); if (retval != 0) dev_set_drvdata(&dev->dev, NULL); else @@ -296,7 +297,7 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id, dev_err(&dev->dev, "init %s fail, %d\n", pci_name(dev), retval); return retval; } -EXPORT_SYMBOL_GPL(usb_hcd_pci_probe); +EXPORT_SYMBOL_GPL(__usb_hcd_pci_probe); /* may be called without controller electrically present */ diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h index 2c99cfe20531..49c1a8d56b2c 100644 --- a/include/linux/usb/hcd.h +++ b/include/linux/usb/hcd.h @@ -493,14 +493,16 @@ static inline int ehset_single_step_set_feature(struct usb_hcd *hcd, int port) #ifdef CONFIG_USB_PCI struct pci_dev; struct pci_device_id; -extern int usb_hcd_pci_probe(struct pci_dev *dev, - const struct pci_device_id *id, - const struct hc_driver *driver); +extern int __usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id, + const struct hc_driver *driver, bool register_hub); extern void usb_hcd_pci_remove(struct pci_dev *dev); extern void usb_hcd_pci_shutdown(struct pci_dev *dev); extern int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev *dev); +#define usb_hcd_pci_probe(dev, id, driver) \ + __usb_hcd_pci_probe(dev, id, driver, true) + #ifdef CONFIG_PM extern const struct dev_pm_ops usb_hcd_pci_pm_ops; #endif -- 2.17.1
next prev parent reply other threads:[~2021-08-24 10:53 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-24 10:52 [RFC PATCH 0/5] Fix cold plugged USB device on certain PCIe USB cards Kishon Vijay Abraham I 2021-08-24 10:52 ` [RFC PATCH 1/5] usb: core: hcd: Modularize HCD stop configuration in usb_stop_hcd() Kishon Vijay Abraham I 2021-08-24 13:06 ` Greg Kroah-Hartman 2021-08-24 15:18 ` Kishon Vijay Abraham I 2021-08-26 11:14 ` Greg Kroah-Hartman 2021-08-24 10:52 ` [RFC PATCH 2/5] usb: core: hcd: Let usb_add_hcd() indicate if roothub has to be registered Kishon Vijay Abraham I 2021-08-24 13:08 ` Greg Kroah-Hartman 2021-08-24 14:56 ` Alan Stern 2021-08-24 10:53 ` [RFC PATCH 3/5] usb: core: hcd: Add support for registering secondary RH along with primary HCD Kishon Vijay Abraham I 2021-08-24 11:55 ` Mathias Nyman 2021-08-24 10:53 ` Kishon Vijay Abraham I [this message] 2021-08-24 13:09 ` [RFC PATCH 4/5] usb: core: hcd-pci: Let usb_hcd_pci_probe() indicate if RH has to be registered Greg Kroah-Hartman 2021-08-24 10:53 ` [RFC PATCH 5/5] xhci-pci: Use flag to not register roothub while adding primary HCD Kishon Vijay Abraham I
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210824105302.25382-5-kishon@ti.com \ --to=kishon@ti.com \ --cc=chris.chiu@canonical.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).