LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay"
@ 2021-08-24 10:55 Roger Quadros
  2021-08-25 16:15 ` Nishanth Menon
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Quadros @ 2021-08-24 10:55 UTC (permalink / raw)
  To: nsekhar
  Cc: bgolaszewski, nm, lokeshvutla, linux-arm-kernel, devicetree,
	linux-kernel, Roger Quadros

As per Device Tree Specification [1], the status parameter of nodes can
be "okay", "disabled", etc. "ok" is not a valid parameter.

U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.

[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Changelog:
v2
-refer to DT spec instead of schema in commit log.

 arch/arm/boot/dts/da850-evm.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 87c517d65f62..9dc79b5977bf 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -415,7 +415,7 @@
 &aemif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&nand_pins>;
-	status = "ok";
+	status = "okay";
 	cs3 {
 		#address-cells = <2>;
 		#size-cells = <1>;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay"
  2021-08-24 10:55 [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay" Roger Quadros
@ 2021-08-25 16:15 ` Nishanth Menon
  2021-10-25  7:37   ` Roger Quadros
  0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2021-08-25 16:15 UTC (permalink / raw)
  To: Roger Quadros
  Cc: nsekhar, bgolaszewski, lokeshvutla, linux-arm-kernel, devicetree,
	linux-kernel

On 13:55-20210824, Roger Quadros wrote:
> As per Device Tree Specification [1], the status parameter of nodes can
> be "okay", "disabled", etc. "ok" is not a valid parameter.
> 
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.

^^ the above comment might be fine to indicate the side effect of
non-compliance

> 
> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Reviewed-by: Nishanth Menon <nm@ti.com>

> ---
> Changelog:
> v2
> -refer to DT spec instead of schema in commit log.
> 
>  arch/arm/boot/dts/da850-evm.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 87c517d65f62..9dc79b5977bf 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -415,7 +415,7 @@
>  &aemif {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&nand_pins>;
> -	status = "ok";
> +	status = "okay";
>  	cs3 {
>  		#address-cells = <2>;
>  		#size-cells = <1>;
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay"
  2021-08-25 16:15 ` Nishanth Menon
@ 2021-10-25  7:37   ` Roger Quadros
  0 siblings, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2021-10-25  7:37 UTC (permalink / raw)
  To: Nori, Sekhar
  Cc: bgolaszewski, lokeshvutla, linux-arm-kernel, devicetree,
	linux-kernel, Nishanth Menon

Hi Sekhar,

On 25/08/2021 19:15, Nishanth Menon wrote:
> On 13:55-20210824, Roger Quadros wrote:
>> As per Device Tree Specification [1], the status parameter of nodes can
>> be "okay", "disabled", etc. "ok" is not a valid parameter.
>>
>> U-boot Driver Model does not recognize status="ok" either and treats
>> the node as disabled.
> 
> ^^ the above comment might be fine to indicate the side effect of
> non-compliance
> 
>>
>> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> 
> Reviewed-by: Nishanth Menon <nm@ti.com>

Could you please pick this one if not too late for -next. Thanks.

> 
>> ---
>> Changelog:
>> v2
>> -refer to DT spec instead of schema in commit log.
>>
>>  arch/arm/boot/dts/da850-evm.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>> index 87c517d65f62..9dc79b5977bf 100644
>> --- a/arch/arm/boot/dts/da850-evm.dts
>> +++ b/arch/arm/boot/dts/da850-evm.dts
>> @@ -415,7 +415,7 @@
>>  &aemif {
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&nand_pins>;
>> -	status = "ok";
>> +	status = "okay";
>>  	cs3 {
>>  		#address-cells = <2>;
>>  		#size-cells = <1>;
>> -- 
>> 2.17.1
>>
> 

--
cheers,
-roger

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-25  7:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 10:55 [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay" Roger Quadros
2021-08-25 16:15 ` Nishanth Menon
2021-10-25  7:37   ` Roger Quadros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).