LKML Archive on
help / color / mirror / Atom feed
From: "Michal Koutný" <>
To: brookxu <>
Subject: Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures
Date: Tue, 24 Aug 2021 18:44:23 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Sat, Aug 14, 2021 at 08:15:16AM +0800, brookxu <> wrote:
> 1. If a large number of containers are created and deleted,
>    there will be a lot of error logs.
> 2. According to an error log, we cannot better understand
>    the actual pressure of resources.
> Therefore, perhaps we should use a failcnt counter to count
> the number of failures, so that we can easily understand the
> actual pressure of resources and avoid too many error log..

This is an understandable use case and generally the implementation via
the counter is good as well.

However, the non-hierarchical failcnt interface looks like v1ism to me
(I think new features should come with v2 first in mind).
What about exposing this in file with max.$res_name entries? 

Or if the hierarchical reporting is unnecessary now, there can be just for starters.

(That reminds me the forgotten[.local] rework [1], oops.)


  parent reply	other threads:[~2021-08-24 16:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14  0:15 brookxu
2021-08-14  1:16 ` Vipin Sharma
2021-08-24 16:44 ` Michal Koutný [this message]
2021-08-24 19:08   ` Tejun Heo
2021-08-25  6:50     ` brookxu
2021-08-26  1:34     ` brookxu
2021-08-26 11:29       ` Michal Koutný
2021-09-08  5:29         ` brookxu
2021-09-09 15:01           ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).