LKML Archive on
help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Kari Argillander <>
Cc: Konstantin Komarov <>,,,
Subject: Re: [PATCH] fs/ntfs3: add checks for allocation failure
Date: Tue, 24 Aug 2021 19:57:30 +0300	[thread overview]
Message-ID: <20210824165730.GN7722@kadam> (raw)
In-Reply-To: <20210824160244.ruutwl3nq6b5feec@kari-VirtualBox>

On Tue, Aug 24, 2021 at 07:02:44PM +0300, Kari Argillander wrote:
> On Tue, Aug 24, 2021 at 02:52:36PM +0300, Dan Carpenter wrote:
> > Add a check for when the kzalloc() in init_rsttbl() fails.  Some of
> > the callers checked for NULL and some did not.  I went down the call
> > tree and added NULL checks where ever they were missing.
> > 
> > Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
> > Signed-off-by: Dan Carpenter <>
> Seems ok. It is not easist file to follow. log_replay is monster and
> it should be refactor in some point. I'm certain that many more bugs
> will be founded there. Also at least community does not have very good
> testing interface for this. 

There is a way to do allocation fault injection, but I haven't messed
with it.

My guess is that syzbot will soon start reporting a ton of bugs.  ;)

dan carpenter

  reply	other threads:[~2021-08-24 17:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 11:52 Dan Carpenter
2021-08-24 16:02 ` Kari Argillander
2021-08-24 16:57   ` Dan Carpenter [this message]
2021-08-27 17:16 ` Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210824165730.GN7722@kadam \ \ \ \ \ \ \
    --subject='Re: [PATCH] fs/ntfs3: add checks for allocation failure' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).