LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/ntfs3: fix an error code in ntfs_get_acl_ex()
Date: Tue, 24 Aug 2021 20:07:20 +0300	[thread overview]
Message-ID: <20210824170720.GO7722@kadam> (raw)
In-Reply-To: <20210824163851.hfbjqqpztgk4ngd5@kari-VirtualBox>

On Tue, Aug 24, 2021 at 07:38:51PM +0300, Kari Argillander wrote:
> On Tue, Aug 24, 2021 at 02:48:58PM +0300, Dan Carpenter wrote:
> > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
> > index 9239c388050e..e8ed38d0c4c9 100644
> > --- a/fs/ntfs3/xattr.c
> > +++ b/fs/ntfs3/xattr.c
> > @@ -521,7 +521,7 @@ static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns,
> >  		ni_unlock(ni);
> >  
> >  	/* Translate extended attribute to acl */
> > -	if (err > 0) {
> > +	if (err >= 0) {
> 
> So now if err (size) is 0 it will try to get acl. Didn't you just say
> that you want to return PTR_ERR(-EINVAL)?
> 

If you pass an invalid too short size to posix_acl_from_xattr() then it
returns PTR_ERR(-EINVAL).  It was hard to phrase this in the change log
but I feel like length of 1 and 0 should be treated the same.


> So overall good finding but maybe more work is needed with this one.
> 
> >  		acl = posix_acl_from_xattr(mnt_userns, buf, err);
> >  		if (!IS_ERR(acl))
> >  			set_cached_acl(inode, type, acl);

regards,
dan carpenter



  reply	other threads:[~2021-08-24 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 11:48 Dan Carpenter
2021-08-24 16:38 ` Kari Argillander
2021-08-24 17:07   ` Dan Carpenter [this message]
2021-08-27 17:17     ` Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210824170720.GO7722@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=kari.argillander@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --subject='Re: [PATCH] fs/ntfs3: fix an error code in ntfs_get_acl_ex()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).