From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D29DC4338F for ; Wed, 25 Aug 2021 01:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5918361151 for ; Wed, 25 Aug 2021 01:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237636AbhHYBMu (ORCPT ); Tue, 24 Aug 2021 21:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237342AbhHYBMp (ORCPT ); Tue, 24 Aug 2021 21:12:45 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D7DBC0613D9 for ; Tue, 24 Aug 2021 18:12:01 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id t1so21510206pgv.3 for ; Tue, 24 Aug 2021 18:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vQeoNCuCerpnBP7H1FyByrk1/uy3hnxn2GxZuaGAVn0=; b=i2ds57vw0tfKS2lnftd9ksYeJGlna28Rp7mnasVgkDjOo+xkPqcBhVwUbxgVzrxiIW 4tIdskbo6X0YQ64/nf/T4BK6nD6q+ZXrmQaOGAyVfhIyMYa7glpYRXmhb5SAt/B1XRxX sJel4LeLMz6a++SI001x9YJZZIC7si6h8T/0c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vQeoNCuCerpnBP7H1FyByrk1/uy3hnxn2GxZuaGAVn0=; b=crJ+wjxcugDu4RbEEL8L/INvY2Rpb6qyESF9x79I+zRBLVqcF2oKRja3jm2kCaEHt2 Xd+SPONnDhYP6+lZlQz4SL4TQij4Uu87p4IpKcy26RQXQ/KTzWJGwpA2NTkhIggdC/zU WDD9qAiBhIdq0hicuigIbYJ6ZPTC/Rpi+1liLtvGrn2kmKnj4ARlgpuvshtcZ0kGKOKU nbxhYd2SYiCCfMlhFooQHqAhkCw0mgpHXA/uhMZEc6wksVhiPz7rWKjanYRMe5f4+lUV EQdciO5qRYvIzJznzWvKYIaov1o1oo5AGV+nksLha5qzE+UdXPpwsVo5W6DIVDCn+ZI4 JQLw== X-Gm-Message-State: AOAM532vT/EVJp4AmPV0suvT/mBc1/2kJ5hak6LtXGthOJjMj46/6+cW 6LcV4lkSrLpHBj+QvYKy4k5uua0j5h+J6g== X-Google-Smtp-Source: ABdhPJzL3EjTKKK9ta6tNugAfJzRFccY8dETwDnnVW7G1rwkErthmVFGOhL5nvKBYQiibsyAdydX6g== X-Received: by 2002:aa7:9254:0:b029:3c9:268e:ae68 with SMTP id 20-20020aa792540000b02903c9268eae68mr41908494pfp.58.1629853920529; Tue, 24 Aug 2021 18:12:00 -0700 (PDT) Received: from philipchen.mtv.corp.google.com ([2620:15c:202:201:869c:3ae3:4c6a:b3d5]) by smtp.gmail.com with ESMTPSA id y5sm23246567pgs.27.2021.08.24.18.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 18:12:00 -0700 (PDT) From: Philip Chen To: LKML Cc: swboyd@chromium.org, dianders@chromium.org, Philip Chen , Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm/bridge: parade-ps8640: Reorg the macros Date: Tue, 24 Aug 2021 18:11:55 -0700 Message-Id: <20210824181140.v2.1.I8ead7431357409f2526e5739ec5bc3ddfd242243@changeid> X-Mailer: git-send-email 2.33.0.rc2.250.ged5fa647cd-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reorg the macros as follows: (1) Group the registers on the same page together. (2) Group the register and its bit operation together while indenting the macros of the bit operation with one space. Also fix a misnomer for the number of mipi data lanes. Signed-off-by: Philip Chen --- Changes in v2: - Fix the double sign-off lines drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 7bd0affa057a..685e9c38b2db 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -18,16 +18,18 @@ #include #define PAGE2_GPIO_H 0xa7 -#define PS_GPIO9 BIT(1) +#define PS_GPIO9 BIT(1) #define PAGE2_I2C_BYPASS 0xea -#define I2C_BYPASS_EN 0xd0 +#define I2C_BYPASS_EN 0xd0 #define PAGE2_MCS_EN 0xf3 -#define MCS_EN BIT(0) +#define MCS_EN BIT(0) + #define PAGE3_SET_ADD 0xfe -#define VDO_CTL_ADD 0x13 -#define VDO_DIS 0x18 -#define VDO_EN 0x1c -#define DP_NUM_LANES 4 +#define VDO_CTL_ADD 0x13 +#define VDO_DIS 0x18 +#define VDO_EN 0x1c + +#define NUM_MIPI_LANES 4 /* * PS8640 uses multiple addresses: @@ -254,7 +256,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE; dsi->format = MIPI_DSI_FMT_RGB888; - dsi->lanes = DP_NUM_LANES; + dsi->lanes = NUM_MIPI_LANES; ret = mipi_dsi_attach(dsi); if (ret) goto err_dsi_attach; -- 2.33.0.rc2.250.ged5fa647cd-goog