LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now
@ 2021-08-24 18:20 Kari Argillander
  2021-08-31 16:19 ` Konstantin Komarov
  0 siblings, 1 reply; 2+ messages in thread
From: Kari Argillander @ 2021-08-24 18:20 UTC (permalink / raw)
  To: Konstantin Komarov, ntfs3; +Cc: Kari Argillander, linux-kernel, Pali Rohár

For some reason we have FAT ioctl calls. Even old ntfs driver did not
use these. We should not use these because it his hard to get things out
of kernel when they are upstream. That's why we remove these for now.

More discussion is needed what ioctl should be implemented and what is
important.

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
Earlier disgussion with Pali can be founded here:
lore.kernel.org/linux-fsdevel/20210824113304.eabzy7ulbuouzlac@pali/
---
 fs/ntfs3/file.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index 59344985c2e8..819afc4c902b 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -10,7 +10,6 @@
 #include <linux/compat.h>
 #include <linux/falloc.h>
 #include <linux/fiemap.h>
-#include <linux/msdos_fs.h> /* FAT_IOCTL_XXX */
 #include <linux/nls.h>
 
 #include "debug.h"
@@ -50,15 +49,8 @@ static long ntfs_ioctl(struct file *filp, u32 cmd, unsigned long arg)
 {
 	struct inode *inode = file_inode(filp);
 	struct ntfs_sb_info *sbi = inode->i_sb->s_fs_info;
-	u32 __user *user_attr = (u32 __user *)arg;
 
 	switch (cmd) {
-	case FAT_IOCTL_GET_ATTRIBUTES:
-		return put_user(le32_to_cpu(ntfs_i(inode)->std_fa), user_attr);
-
-	case FAT_IOCTL_GET_VOLUME_ID:
-		return put_user(sbi->volume.ser_num, user_attr);
-
 	case FITRIM:
 		return ntfs_ioctl_fitrim(sbi, arg);
 	}
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now
  2021-08-24 18:20 [PATCH] fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now Kari Argillander
@ 2021-08-31 16:19 ` Konstantin Komarov
  0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2021-08-31 16:19 UTC (permalink / raw)
  To: Kari Argillander, ntfs3; +Cc: linux-kernel, Pali Rohár



On 24.08.2021 21:20, Kari Argillander wrote:
> For some reason we have FAT ioctl calls. Even old ntfs driver did not
> use these. We should not use these because it his hard to get things out
> of kernel when they are upstream. That's why we remove these for now.
> 
> More discussion is needed what ioctl should be implemented and what is
> important.
> 
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> ---
> Earlier disgussion with Pali can be founded here:
> lore.kernel.org/linux-fsdevel/20210824113304.eabzy7ulbuouzlac@pali/
> ---
>  fs/ntfs3/file.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 59344985c2e8..819afc4c902b 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -10,7 +10,6 @@
>  #include <linux/compat.h>
>  #include <linux/falloc.h>
>  #include <linux/fiemap.h>
> -#include <linux/msdos_fs.h> /* FAT_IOCTL_XXX */
>  #include <linux/nls.h>
>  
>  #include "debug.h"
> @@ -50,15 +49,8 @@ static long ntfs_ioctl(struct file *filp, u32 cmd, unsigned long arg)
>  {
>  	struct inode *inode = file_inode(filp);
>  	struct ntfs_sb_info *sbi = inode->i_sb->s_fs_info;
> -	u32 __user *user_attr = (u32 __user *)arg;
>  
>  	switch (cmd) {
> -	case FAT_IOCTL_GET_ATTRIBUTES:
> -		return put_user(le32_to_cpu(ntfs_i(inode)->std_fa), user_attr);
> -
> -	case FAT_IOCTL_GET_VOLUME_ID:
> -		return put_user(sbi->volume.ser_num, user_attr);
> -
>  	case FITRIM:
>  		return ntfs_ioctl_fitrim(sbi, arg);
>  	}
> 

Hi, Kari!

Applied, thanks.

Best regards.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-31 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 18:20 [PATCH] fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now Kari Argillander
2021-08-31 16:19 ` Konstantin Komarov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).