LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: 5.14-rc breaks iotop swap io monitoring.
Date: Tue, 24 Aug 2021 17:33:42 -0400	[thread overview]
Message-ID: <20210824213342.GA1708@codemonkey.org.uk> (raw)
In-Reply-To: <CAHk-=wiRe=JBK85HG7xtXH1XbOWcO1KYW8csuWfLuFoHKTqF0w@mail.gmail.com>

On Tue, Aug 24, 2021 at 09:34:02AM -0700, Linus Torvalds wrote:
 > On Tue, Aug 24, 2021 at 8:19 AM Dave Jones <davej@codemonkey.org.uk> wrote:
 > >
 > > On Tue, Aug 24, 2021 at 10:31:16AM +0200, Peter Zijlstra wrote:
 > >  >
 > >  > If you need DELAYACCT I'm thinking:
 > >  >
 > >  >   e4042ad49235 ("delayacct: Default disabled")
 > >  >
 > >  > and
 > >  >
 > >  >   0cd7c741f01d ("delayacct: Add sysctl to enable at runtime")
 > >
 > > That does sound more relevant. however, even after echo 1  > /proc/sys/kernel/task_delayacct,
 > > it still fails in the same way.
 > 
 > Hmm.
 > 
 > What happens if you boot with the 'delayacct' kernel parameter.
 > 
 > Even if you enable it at run-time, processes that have been started
 > before it was enabled won't actually have the 'tsk->delays'
 > allocation. So I'm not sure how effective the run-time thing is.

Yeah that boot option does make iotop work again.

	Dave


  parent reply	other threads:[~2021-08-24 21:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  3:16 Dave Jones
2021-08-24  3:18 ` Dave Jones
2021-08-24  8:31 ` Peter Zijlstra
2021-08-24 15:19   ` Dave Jones
2021-08-24 16:34     ` Linus Torvalds
2021-08-24 17:35       ` Peter Zijlstra
2021-08-24 21:33       ` Dave Jones [this message]
2021-08-24 23:26         ` Linus Torvalds
2021-08-25  0:29           ` Dave Jones
2021-08-25  7:36           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210824213342.GA1708@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: 5.14-rc breaks iotop swap io monitoring.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).