LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings
       [not found] <202108250651.uuW5Q2Rg-lkp@intel.com>
@ 2021-08-24 22:17 ` kernel test robot
  2021-08-25  4:22   ` Oleksij Rempel
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-08-24 22:17 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: kbuild-all, Linux Memory Management List, Jakub Kicinski,
	Andrew Lunn, Colin Ian King, Grant Grundler, Heiner Kallweit,
	Oliver Neukum, linux-usb, netdev, linux-kernel

From: kernel test robot <lkp@intel.com>

drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
CC: Oleksij Rempel <o.rempel@pengutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   372b2891c15acbf7b90d948b08ac174bde77102c
commit: 7a141e64cf14099d84e530db0e86fcb2c489e341 [9154/10077] net: usb: asix: ax88772: move embedded PHY detection as early as possible
:::::: branch date: 12 hours ago
:::::: commit date: 35 hours ago

 asix_devices.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *d
 		return ret;
 
 	priv->phy_addr = ret;
-	priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false);
+	priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10);
 
 	asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0);
 	chipcode &= AX_CHIPCODE_MASK;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings
  2021-08-24 22:17 ` [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings kernel test robot
@ 2021-08-25  4:22   ` Oleksij Rempel
  2021-08-25 14:29     ` Jakub Kicinski
  0 siblings, 1 reply; 4+ messages in thread
From: Oleksij Rempel @ 2021-08-25  4:22 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, Linux Memory Management List, Jakub Kicinski,
	Andrew Lunn, Colin Ian King, Grant Grundler, Heiner Kallweit,
	Oliver Neukum, linux-usb, netdev, linux-kernel

On Wed, Aug 25, 2021 at 06:17:16AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here
> 
>  Remove unneeded conversion to bool
> 
> Semantic patch information:
>  Relational and logical operators evaluate to bool,
>  explicit conversion is overly verbose and unneeded.
> 
> Generated by: scripts/coccinelle/misc/boolconv.cocci
> 
> Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
> CC: Oleksij Rempel <o.rempel@pengutronix.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   372b2891c15acbf7b90d948b08ac174bde77102c
> commit: 7a141e64cf14099d84e530db0e86fcb2c489e341 [9154/10077] net: usb: asix: ax88772: move embedded PHY detection as early as possible
> :::::: branch date: 12 hours ago
> :::::: commit date: 35 hours ago
> 
>  asix_devices.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *d
>  		return ret;
>  
>  	priv->phy_addr = ret;
> -	priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false);
> +	priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10);
>  
>  	asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0);
>  	chipcode &= AX_CHIPCODE_MASK;
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings
  2021-08-25  4:22   ` Oleksij Rempel
@ 2021-08-25 14:29     ` Jakub Kicinski
  2021-08-25 18:36       ` Oleksij Rempel
  0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2021-08-25 14:29 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: kernel test robot, kbuild-all, Linux Memory Management List,
	Andrew Lunn, Colin Ian King, Grant Grundler, Heiner Kallweit,
	Oliver Neukum, linux-usb, netdev, linux-kernel

On Wed, 25 Aug 2021 06:22:07 +0200 Oleksij Rempel wrote:
> On Wed, Aug 25, 2021 at 06:17:16AM +0800, kernel test robot wrote:
> > From: kernel test robot <lkp@intel.com>
> > 
> > drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here
> > 
> >  Remove unneeded conversion to bool
> > 
> > Semantic patch information:
> >  Relational and logical operators evaluate to bool,
> >  explicit conversion is overly verbose and unneeded.
> > 
> > Generated by: scripts/coccinelle/misc/boolconv.cocci
> > 
> > Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
> > CC: Oleksij Rempel <o.rempel@pengutronix.de>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>  
> 
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

This patch never made it into patchwork, would you mind resending it,
Oleksij?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings
  2021-08-25 14:29     ` Jakub Kicinski
@ 2021-08-25 18:36       ` Oleksij Rempel
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2021-08-25 18:36 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: kernel test robot, kbuild-all, Linux Memory Management List,
	Andrew Lunn, Colin Ian King, Grant Grundler, Heiner Kallweit,
	Oliver Neukum, linux-usb, netdev, linux-kernel

On Wed, Aug 25, 2021 at 07:29:42AM -0700, Jakub Kicinski wrote:
> On Wed, 25 Aug 2021 06:22:07 +0200 Oleksij Rempel wrote:
> > On Wed, Aug 25, 2021 at 06:17:16AM +0800, kernel test robot wrote:
> > > From: kernel test robot <lkp@intel.com>
> > > 
> > > drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here
> > > 
> > >  Remove unneeded conversion to bool
> > > 
> > > Semantic patch information:
> > >  Relational and logical operators evaluate to bool,
> > >  explicit conversion is overly verbose and unneeded.
> > > 
> > > Generated by: scripts/coccinelle/misc/boolconv.cocci
> > > 
> > > Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
> > > CC: Oleksij Rempel <o.rempel@pengutronix.de>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: kernel test robot <lkp@intel.com>  
> > 
> > Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> This patch never made it into patchwork, would you mind resending it,
> Oleksij?

ack. done.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-25 18:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <202108250651.uuW5Q2Rg-lkp@intel.com>
2021-08-24 22:17 ` [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings kernel test robot
2021-08-25  4:22   ` Oleksij Rempel
2021-08-25 14:29     ` Jakub Kicinski
2021-08-25 18:36       ` Oleksij Rempel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).