LKML Archive on
help / color / mirror / Atom feed
* [PATCH v1] virtio-mem: fix sleeping in RCU read side section in virtio_mem_online_page_cb()
@ 2021-08-25 10:24 David Hildenbrand
  0 siblings, 0 replies; only message in thread
From: David Hildenbrand @ 2021-08-25 10:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: David Hildenbrand, Dan Carpenter, Michael S. Tsirkin, Jason Wang,
	Andrew Morton, Linus Torvalds, virtualization

virtio_mem_set_fake_offline() might sleep now, and we call it under
rcu_read_lock(). To fix it, simply move the rcu_read_unlock() further
up, as we're done with the device.

Reported-by: Dan Carpenter <>
Fixes: 6cc26d77613a: "virtio-mem: use page_offline_(start|end) when setting PageOffline()
Cc: "Michael S. Tsirkin" <>
Cc: Jason Wang <>
Cc: Andrew Morton <>
Cc: Linus Torvalds <>
Signed-off-by: David Hildenbrand <>

The problematic commit is in v5.14-rc1 .. v5.14-rc7, but it suspect
might be too late for v5.14.

The original commit went upstream via Andrews tree, we could take this fix
via Andrews tree as well or via the vhost tree (MST), I don't particularly
care. (putting Linus on CC just in case)

 drivers/virtio/virtio_mem.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 09ed55de07d7..b91bc810a87e 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1242,12 +1242,19 @@ static void virtio_mem_online_page_cb(struct page *page, unsigned int order)
 			do_online = virtio_mem_bbm_get_bb_state(vm, id) !=
+		/*
+		 * virtio_mem_set_fake_offline() might sleep, we don't need
+		 * the device anymore. See virtio_mem_remove() how races
+		 * between memory onlining and device removal are handled.
+		 */
+		rcu_read_unlock();
 		if (do_online)
 			generic_online_page(page, order);
 			virtio_mem_set_fake_offline(PFN_DOWN(addr), 1 << order,
-		rcu_read_unlock();

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-25 10:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 10:24 [PATCH v1] virtio-mem: fix sleeping in RCU read side section in virtio_mem_online_page_cb() David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).