LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/3] kselftests: clean configs
@ 2021-08-26  1:58 Li Zhijian
  2021-08-26  1:58 ` [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC Li Zhijian
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Li Zhijian @ 2021-08-26  1:58 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, kernel test robot,
	Jason A. Donenfeld, Nick Desaulniers, Masahiro Yamada, wireguard,
	netdev, Rafael J. Wysocki, Viresh Kumar, linux-pm

0Day will check if all configs listing under selftests are able to be enabled properly.

For the missing configs, it will report something like:
LKP WARN miss config CONFIG_SYNC= of sync/config

CC: kernel test robot <lkp@intel.com>
CC: "Jason A. Donenfeld" <Jason@zx2c4.com>
CC: Nick Desaulniers <ndesaulniers@google.com>
CC: Masahiro Yamada <masahiroy@kernel.org>
CC: wireguard@lists.zx2c4.com
CC: netdev@vger.kernel.org

CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Viresh Kumar <viresh.kumar@linaro.org>
CC: linux-pm@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>

Li Zhijian (3):
  selftests/sync: Remove the deprecated config SYNC
  selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
  selftests/wireguard: Rename DEBUG_PI_LIST to DEBUG_PLIST

 tools/testing/selftests/cpufreq/config              | 2 +-
 tools/testing/selftests/sync/config                 | 1 -
 tools/testing/selftests/wireguard/qemu/debug.config | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

-- 
2.31.1




^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC
  2021-08-26  1:58 [PATCH v2 0/3] kselftests: clean configs Li Zhijian
@ 2021-08-26  1:58 ` Li Zhijian
  2021-08-26 21:10   ` Shuah Khan
  2021-08-26  1:58 ` [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
  2021-08-26  1:58 ` [PATCH v2 3/3] selftests/wireguard: " Li Zhijian
  2 siblings, 1 reply; 10+ messages in thread
From: Li Zhijian @ 2021-08-26  1:58 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, kernel test robot

SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
LKP/0Day will check if all configs listing under selftests are able to be enabled properly.

For the missing configs, it will report something like:
LKP WARN miss config CONFIG_SYNC= of sync/config

CC: Philip Li <philip.li@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 tools/testing/selftests/sync/config | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/sync/config b/tools/testing/selftests/sync/config
index 1ab7e8130db2..47ff5afc3727 100644
--- a/tools/testing/selftests/sync/config
+++ b/tools/testing/selftests/sync/config
@@ -1,4 +1,3 @@
 CONFIG_STAGING=y
 CONFIG_ANDROID=y
-CONFIG_SYNC=y
 CONFIG_SW_SYNC=y
-- 
2.31.1




^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-26  1:58 [PATCH v2 0/3] kselftests: clean configs Li Zhijian
  2021-08-26  1:58 ` [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC Li Zhijian
@ 2021-08-26  1:58 ` Li Zhijian
  2021-08-26 21:10   ` Shuah Khan
  2021-08-26  1:58 ` [PATCH v2 3/3] selftests/wireguard: " Li Zhijian
  2 siblings, 1 reply; 10+ messages in thread
From: Li Zhijian @ 2021-08-26  1:58 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, Rafael J. Wysocki,
	Viresh Kumar, linux-pm

DEBUG_PI_LIST was renamed to DEBUG_PLIST since 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")

CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Viresh Kumar <viresh.kumar@linaro.org>
CC: linux-pm@vger.kernel.org
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 tools/testing/selftests/cpufreq/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/cpufreq/config b/tools/testing/selftests/cpufreq/config
index 27ff72ebd0f5..75e900793e8a 100644
--- a/tools/testing/selftests/cpufreq/config
+++ b/tools/testing/selftests/cpufreq/config
@@ -6,7 +6,7 @@ CONFIG_CPU_FREQ_GOV_ONDEMAND=y
 CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
 CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y
 CONFIG_DEBUG_RT_MUTEXES=y
-CONFIG_DEBUG_PI_LIST=y
+CONFIG_DEBUG_PLIST=y
 CONFIG_DEBUG_SPINLOCK=y
 CONFIG_DEBUG_MUTEXES=y
 CONFIG_DEBUG_LOCK_ALLOC=y
-- 
2.31.1




^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 3/3] selftests/wireguard: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-26  1:58 [PATCH v2 0/3] kselftests: clean configs Li Zhijian
  2021-08-26  1:58 ` [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC Li Zhijian
  2021-08-26  1:58 ` [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
@ 2021-08-26  1:58 ` Li Zhijian
  2021-08-26 21:11   ` Shuah Khan
  2021-08-27 14:23   ` Jason A. Donenfeld
  2 siblings, 2 replies; 10+ messages in thread
From: Li Zhijian @ 2021-08-26  1:58 UTC (permalink / raw)
  To: shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Li Zhijian, Jason A. Donenfeld,
	Nick Desaulniers, Masahiro Yamada, wireguard, netdev

DEBUG_PI_LIST was renamed to DEBUG_PLIST since 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")

CC: "Jason A. Donenfeld" <Jason@zx2c4.com>
CC: Nick Desaulniers <ndesaulniers@google.com>
CC: Masahiro Yamada <masahiroy@kernel.org>
CC: wireguard@lists.zx2c4.com
CC: netdev@vger.kernel.org

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 tools/testing/selftests/wireguard/qemu/debug.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/wireguard/qemu/debug.config b/tools/testing/selftests/wireguard/qemu/debug.config
index fe07d97df9fa..2b321b8a96cf 100644
--- a/tools/testing/selftests/wireguard/qemu/debug.config
+++ b/tools/testing/selftests/wireguard/qemu/debug.config
@@ -47,7 +47,7 @@ CONFIG_DEBUG_ATOMIC_SLEEP=y
 CONFIG_TRACE_IRQFLAGS=y
 CONFIG_DEBUG_BUGVERBOSE=y
 CONFIG_DEBUG_LIST=y
-CONFIG_DEBUG_PI_LIST=y
+CONFIG_DEBUG_PLIST=y
 CONFIG_PROVE_RCU=y
 CONFIG_SPARSE_RCU_POINTER=y
 CONFIG_RCU_CPU_STALL_TIMEOUT=21
-- 
2.31.1




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC
  2021-08-26  1:58 ` [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC Li Zhijian
@ 2021-08-26 21:10   ` Shuah Khan
  2021-08-27  1:35     ` lizhijian
  0 siblings, 1 reply; 10+ messages in thread
From: Shuah Khan @ 2021-08-26 21:10 UTC (permalink / raw)
  To: Li Zhijian, shuah, linux-kselftest
  Cc: philip.li, linux-kernel, kernel test robot, Shuah Khan

On 8/25/21 7:58 PM, Li Zhijian wrote:
> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
> 

Can you please state what you arr fxing and also keep the sentences
75 chars or less.

Where is LKP warning? Include the warning and explain why this
change is necessary.

> For the missing configs, it will report something like:
> LKP WARN miss config CONFIG_SYNC= of sync/config
> 
> CC: Philip Li <philip.li@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-26  1:58 ` [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
@ 2021-08-26 21:10   ` Shuah Khan
  0 siblings, 0 replies; 10+ messages in thread
From: Shuah Khan @ 2021-08-26 21:10 UTC (permalink / raw)
  To: Li Zhijian, shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Rafael J. Wysocki, Viresh Kumar,
	linux-pm, Shuah Khan

On 8/25/21 7:58 PM, Li Zhijian wrote:
> DEBUG_PI_LIST was renamed to DEBUG_PLIST since 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")
> 
> CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> CC: Viresh Kumar <viresh.kumar@linaro.org>
> CC: linux-pm@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---

Can you please state what you arr fxing and also keep the sentences
75 chars or less.

Where is LKP warning? Include the warning and explain why this
change is necessary.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] selftests/wireguard: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-26  1:58 ` [PATCH v2 3/3] selftests/wireguard: " Li Zhijian
@ 2021-08-26 21:11   ` Shuah Khan
  2021-08-27 14:23   ` Jason A. Donenfeld
  1 sibling, 0 replies; 10+ messages in thread
From: Shuah Khan @ 2021-08-26 21:11 UTC (permalink / raw)
  To: Li Zhijian, shuah, linux-kselftest
  Cc: philip.li, linux-kernel, Jason A. Donenfeld, Nick Desaulniers,
	Masahiro Yamada, wireguard, netdev, Shuah Khan

On 8/25/21 7:58 PM, Li Zhijian wrote:
> DEBUG_PI_LIST was renamed to DEBUG_PLIST since 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")
> 
> CC: "Jason A. Donenfeld" <Jason@zx2c4.com>
> CC: Nick Desaulniers <ndesaulniers@google.com>
> CC: Masahiro Yamada <masahiroy@kernel.org>
> CC: wireguard@lists.zx2c4.com
> CC: netdev@vger.kernel.org
> 
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---

Can you please state what you are fixing and also keep the sentences
75 chars or less.

Where is LKP warning? Include the warning and explain why this
change is necessary.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC
  2021-08-26 21:10   ` Shuah Khan
@ 2021-08-27  1:35     ` lizhijian
  2021-08-27 17:00       ` Shuah Khan
  0 siblings, 1 reply; 10+ messages in thread
From: lizhijian @ 2021-08-27  1:35 UTC (permalink / raw)
  To: Shuah Khan, lizhijian, shuah, linux-kselftest
  Cc: philip.li, linux-kernel, kernel test robot



On 27/08/2021 05:10, Shuah Khan wrote:
> On 8/25/21 7:58 PM, Li Zhijian wrote:
>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
>>
>
> Can you please state what you arr fxing and also keep the sentences
> 75 chars or less.
>
> Where is LKP warning? 
https://01.org/lkp
LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.

So in this case, which is related to too old kernel, it just reported it internally.


> Include the warning and explain why this
> change is necessary.
- it's not reasonable to keep the deprecated configs, right ?

- In my understanding, configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

Do you mean the commit log should include above 2 reasons ?

Thanks

>
>> For the missing configs, it will report something like:
>> LKP WARN miss config CONFIG_SYNC= of sync/config
>>
>> CC: Philip Li <philip.li@intel.com>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>
> thanks,
> -- Shuah
>
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] selftests/wireguard: Rename DEBUG_PI_LIST to DEBUG_PLIST
  2021-08-26  1:58 ` [PATCH v2 3/3] selftests/wireguard: " Li Zhijian
  2021-08-26 21:11   ` Shuah Khan
@ 2021-08-27 14:23   ` Jason A. Donenfeld
  1 sibling, 0 replies; 10+ messages in thread
From: Jason A. Donenfeld @ 2021-08-27 14:23 UTC (permalink / raw)
  To: lizhijian
  Cc: Shuah Khan, linux-kselftest, Philip Li, LKML, Nick Desaulniers,
	Masahiro Yamada, WireGuard mailing list, Netdev

Hi,

On Thu, Aug 26, 2021 at 3:54 AM Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
>
> DEBUG_PI_LIST was renamed to DEBUG_PLIST since 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")

Thanks for the patch. I've queued this up in my wireguard-linux.git
tree for some rounds of CI, and I'll send it back out in the next
series I send to netdev.

Regards,
Jason

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC
  2021-08-27  1:35     ` lizhijian
@ 2021-08-27 17:00       ` Shuah Khan
  0 siblings, 0 replies; 10+ messages in thread
From: Shuah Khan @ 2021-08-27 17:00 UTC (permalink / raw)
  To: lizhijian, shuah, linux-kselftest
  Cc: philip.li, linux-kernel, kernel test robot, Shuah Khan

On 8/26/21 7:35 PM, lizhijian@fujitsu.com wrote:
> 
> 
> On 27/08/2021 05:10, Shuah Khan wrote:
>> On 8/25/21 7:58 PM, Li Zhijian wrote:
>>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
>>>
>>
>> Can you please state what you arr fxing and also keep the sentences
>> 75 chars or less.
>>
>> Where is LKP warning?
> https://01.org/lkp
> LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
> As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.
> 
> So in this case, which is related to too old kernel, it just reported it internally.
> 
> 
>> Include the warning and explain why this
>> change is necessary.
> - it's not reasonable to keep the deprecated configs, right ?
> 
> - In my understanding, configs under kselftests are recommended by corresponding tests.
> So if some configs are missing, it will impact the testing results
> 
> Do you mean the commit log should include above 2 reasons ?
> 

Correct. I am asking the commit log to include these details.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-08-27 17:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26  1:58 [PATCH v2 0/3] kselftests: clean configs Li Zhijian
2021-08-26  1:58 ` [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC Li Zhijian
2021-08-26 21:10   ` Shuah Khan
2021-08-27  1:35     ` lizhijian
2021-08-27 17:00       ` Shuah Khan
2021-08-26  1:58 ` [PATCH v2 2/3] selftests/cpufreq: Rename DEBUG_PI_LIST to DEBUG_PLIST Li Zhijian
2021-08-26 21:10   ` Shuah Khan
2021-08-26  1:58 ` [PATCH v2 3/3] selftests/wireguard: " Li Zhijian
2021-08-26 21:11   ` Shuah Khan
2021-08-27 14:23   ` Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).