LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: build failure after merge of the bpf-next tree
@ 2021-08-26  1:50 Stephen Rothwell
  2021-08-26  2:01 ` Daniel Xu
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2021-08-26  1:50 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Daniel Xu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/trace/bpf_trace.c:717:47: error: expected ')' before 'struct'
  717 | BTF_ID_LIST_GLOBAL_SINGLE(btf_task_struct_ids, struct, task_struct)
      |                                               ^~~~~~~
      |                                               )
kernel/trace/bpf_trace.c: In function 'bpf_tracing_func_proto':
kernel/trace/bpf_trace.c:1051:11: error: 'bpf_get_current_task_btf_proto' undeclared (first use in this function); did you mean 'bpf_get_current_task_proto'?
 1051 |   return &bpf_get_current_task_btf_proto;
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           bpf_get_current_task_proto

Caused by commit

  33c5cb36015a ("bpf: Consolidate task_struct BTF_ID declarations")

I have used the bpf-next tree from next-20210825 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-08-26  1:50 linux-next: build failure after merge of the bpf-next tree Stephen Rothwell
@ 2021-08-26  2:01 ` Daniel Xu
  0 siblings, 0 replies; 52+ messages in thread
From: Daniel Xu @ 2021-08-26  2:01 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Kernel Mailing List, Linux Next Mailing List

Hi Stephen,

On Thu, Aug 26, 2021 at 11:50:50AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> kernel/trace/bpf_trace.c:717:47: error: expected ')' before 'struct'
>   717 | BTF_ID_LIST_GLOBAL_SINGLE(btf_task_struct_ids, struct, task_struct)
>       |                                               ^~~~~~~
>       |                                               )
> kernel/trace/bpf_trace.c: In function 'bpf_tracing_func_proto':
> kernel/trace/bpf_trace.c:1051:11: error: 'bpf_get_current_task_btf_proto' undeclared (first use in this function); did you mean 'bpf_get_current_task_proto'?
>  1051 |   return &bpf_get_current_task_btf_proto;
>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |           bpf_get_current_task_proto
> 
> Caused by commit
> 
>   33c5cb36015a ("bpf: Consolidate task_struct BTF_ID declarations")
> 
> I have used the bpf-next tree from next-20210825 for today.

Sorry about the breakage. I've put up
https://lore.kernel.org/bpf/05d94748d9f4b3eecedc4fddd6875418a396e23c.1629942444.git.dxu@dxuuu.xyz/T/#u
which I think should fix it. Can you give that patch a try?

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2022-07-20  3:42 ` Alexei Starovoitov
@ 2022-07-20  3:44   ` Stanislav Fomichev
  0 siblings, 0 replies; 52+ messages in thread
From: Stanislav Fomichev @ 2022-07-20  3:44 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Stephen Rothwell, Daniel Borkmann, Alexei Starovoitov,
	Andrii Nakryiko, bpf, Networking, Linux Kernel Mailing List,
	Linux Next Mailing List

On Tue, Jul 19, 2022 at 8:42 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Jul 19, 2022 at 7:00 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the bpf-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > ld: warning: discarding dynamic section .glink
> > ld: warning: discarding dynamic section .plt
> > ld: linkage table error against `bpf_trampoline_unlink_cgroup_shim'
> > ld: stubs don't match calculated size
> > ld: can not build stubs: bad value
> > ld: kernel/bpf/cgroup.o: in function `.bpf_cgroup_link_release.part.0':
> > cgroup.c:(.text+0x2fc4): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
> > ld: kernel/bpf/cgroup.o: in function `.cgroup_bpf_release':
> > cgroup.c:(.text+0x33b0): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
> > ld: cgroup.c:(.text+0x33c0): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
> >
> > Caused by commit
> >
> >   3908fcddc65d ("bpf: fix lsm_cgroup build errors on esoteric configs")
> >
> > I have reverted that commit for today.
>
> Argh.
>
> Stan,
>
> please take a look.

Sorry about that, I forgot to update the ifdef guards in the header
:-( Will send a fix shortly..

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2022-07-20  1:59 Stephen Rothwell
@ 2022-07-20  3:42 ` Alexei Starovoitov
  2022-07-20  3:44   ` Stanislav Fomichev
  0 siblings, 1 reply; 52+ messages in thread
From: Alexei Starovoitov @ 2022-07-20  3:42 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, bpf,
	Networking, Stanislav Fomichev, Linux Kernel Mailing List,
	Linux Next Mailing List

On Tue, Jul 19, 2022 at 7:00 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: warning: discarding dynamic section .glink
> ld: warning: discarding dynamic section .plt
> ld: linkage table error against `bpf_trampoline_unlink_cgroup_shim'
> ld: stubs don't match calculated size
> ld: can not build stubs: bad value
> ld: kernel/bpf/cgroup.o: in function `.bpf_cgroup_link_release.part.0':
> cgroup.c:(.text+0x2fc4): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
> ld: kernel/bpf/cgroup.o: in function `.cgroup_bpf_release':
> cgroup.c:(.text+0x33b0): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
> ld: cgroup.c:(.text+0x33c0): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
>
> Caused by commit
>
>   3908fcddc65d ("bpf: fix lsm_cgroup build errors on esoteric configs")
>
> I have reverted that commit for today.

Argh.

Stan,

please take a look.

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2022-07-20  1:59 Stephen Rothwell
  2022-07-20  3:42 ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2022-07-20  1:59 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko
  Cc: bpf, Networking, Stanislav Fomichev, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: warning: discarding dynamic section .glink
ld: warning: discarding dynamic section .plt
ld: linkage table error against `bpf_trampoline_unlink_cgroup_shim'
ld: stubs don't match calculated size
ld: can not build stubs: bad value
ld: kernel/bpf/cgroup.o: in function `.bpf_cgroup_link_release.part.0':
cgroup.c:(.text+0x2fc4): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
ld: kernel/bpf/cgroup.o: in function `.cgroup_bpf_release':
cgroup.c:(.text+0x33b0): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'
ld: cgroup.c:(.text+0x33c0): undefined reference to `.bpf_trampoline_unlink_cgroup_shim'

Caused by commit

  3908fcddc65d ("bpf: fix lsm_cgroup build errors on esoteric configs")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2022-04-21  9:45   ` Daniel Borkmann
@ 2022-04-21 10:40     ` Maciej Fijalkowski
  0 siblings, 0 replies; 52+ messages in thread
From: Maciej Fijalkowski @ 2022-04-21 10:40 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Stephen Rothwell, Alexei Starovoitov, Andrii Nakryiko, bpf,
	Networking, Linux Kernel Mailing List, Linux Next Mailing List

On Thu, Apr 21, 2022 at 11:45:46AM +0200, Daniel Borkmann wrote:
> On 4/21/22 2:32 AM, Stephen Rothwell wrote:
> > Hi all,
> 
> Maciej, I presume you are already working on a follow-up for the below?

Yikes! I missed that, let's blame easter break for that.
I'm on it.

> 
> > On Tue, 19 Apr 2022 11:56:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > 
> > > After merging the bpf-next tree, today's linux-next build
> > > (x86_64 allmodconfig) failed like this:
> > > 
> > > In file included from include/linux/compiler_types.h:73,
> > >                   from <command-line>:
> > > drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function 'i40e_run_xdp_zc':
> > > include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
> > >    222 | # define fallthrough                    __attribute__((__fallthrough__))
> > >        |                                         ^~~~~~~~~~~~~
> > > drivers/net/ethernet/intel/i40e/i40e_xsk.c:192:17: note: in expansion of macro 'fallthrough'
> > >    192 |                 fallthrough; /* handle aborts by dropping packet */
> > >        |                 ^~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > > In file included from include/linux/compiler_types.h:73,
> > >                   from <command-line>:
> > > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c: In function 'ixgbe_run_xdp_zc':
> > > include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
> > >    222 | # define fallthrough                    __attribute__((__fallthrough__))
> > >        |                                         ^~~~~~~~~~~~~
> > > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c:147:17: note: in expansion of macro 'fallthrough'
> > >    147 |                 fallthrough; /* handle aborts by dropping packet */
> > >        |                 ^~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > > 
> > > Caused by commits
> > > 
> > >    b8aef650e549 ("i40e, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
> > >    c7dd09fd4628 ("ixgbe, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
> > > 
> > > I have used the bpf-next tree from next-20220414 for today.
> > 
> > I am still getting these failures ...
> > 
> 

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2022-04-21  0:32 ` Stephen Rothwell
@ 2022-04-21  9:45   ` Daniel Borkmann
  2022-04-21 10:40     ` Maciej Fijalkowski
  0 siblings, 1 reply; 52+ messages in thread
From: Daniel Borkmann @ 2022-04-21  9:45 UTC (permalink / raw)
  To: Stephen Rothwell, Alexei Starovoitov, Andrii Nakryiko
  Cc: bpf, Networking, Maciej Fijalkowski, Linux Kernel Mailing List,
	Linux Next Mailing List

On 4/21/22 2:32 AM, Stephen Rothwell wrote:
> Hi all,

Maciej, I presume you are already working on a follow-up for the below?

> On Tue, 19 Apr 2022 11:56:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the bpf-next tree, today's linux-next build
>> (x86_64 allmodconfig) failed like this:
>>
>> In file included from include/linux/compiler_types.h:73,
>>                   from <command-line>:
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function 'i40e_run_xdp_zc':
>> include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
>>    222 | # define fallthrough                    __attribute__((__fallthrough__))
>>        |                                         ^~~~~~~~~~~~~
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:192:17: note: in expansion of macro 'fallthrough'
>>    192 |                 fallthrough; /* handle aborts by dropping packet */
>>        |                 ^~~~~~~~~~~
>> cc1: all warnings being treated as errors
>> In file included from include/linux/compiler_types.h:73,
>>                   from <command-line>:
>> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c: In function 'ixgbe_run_xdp_zc':
>> include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
>>    222 | # define fallthrough                    __attribute__((__fallthrough__))
>>        |                                         ^~~~~~~~~~~~~
>> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c:147:17: note: in expansion of macro 'fallthrough'
>>    147 |                 fallthrough; /* handle aborts by dropping packet */
>>        |                 ^~~~~~~~~~~
>> cc1: all warnings being treated as errors
>>
>> Caused by commits
>>
>>    b8aef650e549 ("i40e, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
>>    c7dd09fd4628 ("ixgbe, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
>>
>> I have used the bpf-next tree from next-20220414 for today.
> 
> I am still getting these failures ...
> 


^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2022-04-19  1:56 Stephen Rothwell
@ 2022-04-21  0:32 ` Stephen Rothwell
  2022-04-21  9:45   ` Daniel Borkmann
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2022-04-21  0:32 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko
  Cc: bpf, Networking, Maciej Fijalkowski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]

Hi all,

On Tue, 19 Apr 2022 11:56:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the bpf-next tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
> 
> In file included from include/linux/compiler_types.h:73,
>                  from <command-line>:
> drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function 'i40e_run_xdp_zc':
> include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
>   222 | # define fallthrough                    __attribute__((__fallthrough__))
>       |                                         ^~~~~~~~~~~~~
> drivers/net/ethernet/intel/i40e/i40e_xsk.c:192:17: note: in expansion of macro 'fallthrough'
>   192 |                 fallthrough; /* handle aborts by dropping packet */
>       |                 ^~~~~~~~~~~
> cc1: all warnings being treated as errors
> In file included from include/linux/compiler_types.h:73,
>                  from <command-line>:
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c: In function 'ixgbe_run_xdp_zc':
> include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
>   222 | # define fallthrough                    __attribute__((__fallthrough__))
>       |                                         ^~~~~~~~~~~~~
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c:147:17: note: in expansion of macro 'fallthrough'
>   147 |                 fallthrough; /* handle aborts by dropping packet */
>       |                 ^~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commits
> 
>   b8aef650e549 ("i40e, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
>   c7dd09fd4628 ("ixgbe, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
> 
> I have used the bpf-next tree from next-20220414 for today.

I am still getting these failures ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2022-04-19  1:56 Stephen Rothwell
  2022-04-21  0:32 ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2022-04-19  1:56 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko
  Cc: bpf, Networking, Maciej Fijalkowski, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build
(x86_64 allmodconfig) failed like this:

In file included from include/linux/compiler_types.h:73,
                 from <command-line>:
drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function 'i40e_run_xdp_zc':
include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
  222 | # define fallthrough                    __attribute__((__fallthrough__))
      |                                         ^~~~~~~~~~~~~
drivers/net/ethernet/intel/i40e/i40e_xsk.c:192:17: note: in expansion of macro 'fallthrough'
  192 |                 fallthrough; /* handle aborts by dropping packet */
      |                 ^~~~~~~~~~~
cc1: all warnings being treated as errors
In file included from include/linux/compiler_types.h:73,
                 from <command-line>:
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c: In function 'ixgbe_run_xdp_zc':
include/linux/compiler_attributes.h:222:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
  222 | # define fallthrough                    __attribute__((__fallthrough__))
      |                                         ^~~~~~~~~~~~~
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c:147:17: note: in expansion of macro 'fallthrough'
  147 |                 fallthrough; /* handle aborts by dropping packet */
      |                 ^~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commits

  b8aef650e549 ("i40e, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
  c7dd09fd4628 ("ixgbe, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")

I have used the bpf-next tree from next-20220414 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2022-02-09  0:21 Stephen Rothwell
  0 siblings, 0 replies; 52+ messages in thread
From: Stephen Rothwell @ 2022-02-09  0:21 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, bpf, Networking
  Cc: Song Liu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/bpf/core.c:830:23: error: variably modified 'bitmap' at file scope
  830 |         unsigned long bitmap[BITS_TO_LONGS(BPF_PROG_CHUNK_COUNT)];
      |                       ^~~~~~

Caused by commit

  57631054fae6 ("bpf: Introduce bpf_prog_pack allocator")

I have used the bpf-next tree from next-20220208 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2021-12-03  0:15 Stephen Rothwell
  0 siblings, 0 replies; 52+ messages in thread
From: Stephen Rothwell @ 2021-12-03  0:15 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 7545 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (native perf)
failed like this:

tests/bpf.c: In function 'check_env':
tests/bpf.c:299:2: error: 'bpf_load_program' is deprecated: libbpf v0.7+: use bpf_prog_load() instead [-Werror=deprecated-declarations]
  299 |  err = bpf_load_program(BPF_PROG_TYPE_KPROBE, insns,
      |  ^~~
In file included from tests/bpf.c:28:
tools/lib/bpf/bpf.h:204:16: note: declared here
  204 | LIBBPF_API int bpf_load_program(enum bpf_prog_type type,
      |                ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
util/bpf-loader.c: In function 'bpf__clear':
util/bpf-loader.c:115:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
  115 |  bpf_object__for_each_safe(obj, tmp) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:115:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
  115 |  bpf_object__for_each_safe(obj, tmp) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:115:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
  115 |  bpf_object__for_each_safe(obj, tmp) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c: In function 'hook_load_preprocessor':
util/bpf-loader.c:621:2: error: 'bpf_program__set_prep' is deprecated: libbpf v0.7+: use bpf_program__insns() for getting bpf_program instructions [-Werror=deprecated-declarations]
  621 |  err = bpf_program__set_prep(prog, priv->nr_types,
      |  ^~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:467:16: note: declared here
  467 | LIBBPF_API int bpf_program__set_prep(struct bpf_program *prog, int nr_instance,
      |                ^~~~~~~~~~~~~~~~~~~~~
util/bpf-loader.c: In function 'bpf__foreach_event':
util/bpf-loader.c:776:5: error: 'bpf_program__nth_fd' is deprecated: libbpf v0.7+: multi-instance bpf_program support is deprecated [-Werror=deprecated-declarations]
  776 |     fd = bpf_program__nth_fd(prog, type);
      |     ^~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:471:16: note: declared here
  471 | LIBBPF_API int bpf_program__nth_fd(const struct bpf_program *prog, int n);
      |                ^~~~~~~~~~~~~~~~~~~
util/bpf-loader.c: In function 'bpf__apply_obj_config':
util/bpf-loader.c:1501:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1501 |  bpf_object__for_each_safe(obj, tmp) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1501:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1501 |  bpf_object__for_each_safe(obj, tmp) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1501:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1501 |  bpf_object__for_each_safe(obj, tmp) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c: In function 'bpf__setup_output_event':
util/bpf-loader.c:1529:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1529 |  bpf__for_each_map_named(map, obj, tmp, name) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1529:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1529 |  bpf__for_each_map_named(map, obj, tmp, name) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1529:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1529 |  bpf__for_each_map_named(map, obj, tmp, name) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1565:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1565 |  bpf__for_each_map_named(map, obj, tmp, name) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1565:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1565 |  bpf__for_each_map_named(map, obj, tmp, name) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
util/bpf-loader.c:1565:2: error: 'bpf_object__next' is deprecated: libbpf v0.7+: track bpf_objects in application code instead [-Werror=deprecated-declarations]
 1565 |  bpf__for_each_map_named(map, obj, tmp, name) {
      |  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:176:20: note: declared here
  176 | struct bpf_object *bpf_object__next(struct bpf_object *prev);
      |                    ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

I am not sure what caused this, but I have just used the bpf-next tree
from next-20211202 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-09-14 23:59       ` Stephen Rothwell
@ 2021-09-15  1:27         ` Alexei Starovoitov
  0 siblings, 0 replies; 52+ messages in thread
From: Alexei Starovoitov @ 2021-09-15  1:27 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Andrii Nakryiko, Daniel Borkmann, Alexei Starovoitov, Networking,
	Andrii Nakryiko, Quentin Monnet, Linux Kernel Mailing List,
	Linux Next Mailing List, Arnaldo Carvalho de Melo, Jiri Olsa,
	David Miller

On Tue, Sep 14, 2021 at 4:59 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Andrii,
>
> On Tue, 14 Sep 2021 16:40:37 -0700 Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> >
> > On Tue, Sep 14, 2021 at 4:38 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi Andrii,
> > >
> > > On Tue, 14 Sep 2021 16:25:55 -0700 Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> > > >
> > > > On Mon, Sep 13, 2021 at 6:37 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > > >
> > > > > After merging the bpf-next tree, today's linux-next build (perf) failed
> > > > > like this:
> > > > >
> > > > > util/bpf-event.c: In function 'btf__load_from_kernel_by_id':
> > > > > util/bpf-event.c:27:8: error: 'btf__get_from_id' is deprecated: libbpf v0.6+: use btf__load_from_kernel_by_id instead [-Werror=deprecated-declarations]
> > > > >    27 |        int err = btf__get_from_id(id, &btf);
> > > > >       |        ^~~
> > > > > In file included from util/bpf-event.c:5:
> > > > > /home/sfr/next/next/tools/lib/bpf/btf.h:54:16: note: declared here
> > > > >    54 | LIBBPF_API int btf__get_from_id(__u32 id, struct btf **btf);
> > > > >       |                ^~~~~~~~~~~~~~~~
> > > > > cc1: all warnings being treated as errors
> > > > >
> > > > > Caused by commit
> > > > >
> > > > >   0b46b7550560 ("libbpf: Add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations")
> > > >
> > > > Should be fixed by [0], when applied to perf tree. Thanks for reporting!
> > > >
> > > >   [0] https://patchwork.kernel.org/project/netdevbpf/patch/20210914170004.4185659-1-andrii@kernel.org/
> > >
> > > That really needs to be applied to the bpf-next tree (presumably with
> > > the appropriate Acks).
> > >
> >
> > This is perf code that's not in bpf-next yet.
>
> Then you need to think of a solution for the bpf-next tree, as it will
> not build (allmodconfig) when combined with Linus' current tree.  And
> when it is merged into the net-next tree, that tree will be broken as
> well.

It's not a problem of bpf-tree and it cannot be fixed in bpf-tree.
The bug is in perf tree.

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-09-14 23:40     ` Andrii Nakryiko
@ 2021-09-14 23:59       ` Stephen Rothwell
  2021-09-15  1:27         ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2021-09-14 23:59 UTC (permalink / raw)
  To: Andrii Nakryiko
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking, Andrii Nakryiko,
	Quentin Monnet, Linux Kernel Mailing List,
	Linux Next Mailing List, Arnaldo Carvalho de Melo, Jiri Olsa,
	David Miller

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

Hi Andrii,

On Tue, 14 Sep 2021 16:40:37 -0700 Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Sep 14, 2021 at 4:38 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Andrii,
> >
> > On Tue, 14 Sep 2021 16:25:55 -0700 Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:  
> > >
> > > On Mon, Sep 13, 2021 at 6:37 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > > >
> > > > After merging the bpf-next tree, today's linux-next build (perf) failed
> > > > like this:
> > > >
> > > > util/bpf-event.c: In function 'btf__load_from_kernel_by_id':
> > > > util/bpf-event.c:27:8: error: 'btf__get_from_id' is deprecated: libbpf v0.6+: use btf__load_from_kernel_by_id instead [-Werror=deprecated-declarations]
> > > >    27 |        int err = btf__get_from_id(id, &btf);
> > > >       |        ^~~
> > > > In file included from util/bpf-event.c:5:
> > > > /home/sfr/next/next/tools/lib/bpf/btf.h:54:16: note: declared here
> > > >    54 | LIBBPF_API int btf__get_from_id(__u32 id, struct btf **btf);
> > > >       |                ^~~~~~~~~~~~~~~~
> > > > cc1: all warnings being treated as errors
> > > >
> > > > Caused by commit
> > > >
> > > >   0b46b7550560 ("libbpf: Add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations")  
> > >
> > > Should be fixed by [0], when applied to perf tree. Thanks for reporting!
> > >
> > >   [0] https://patchwork.kernel.org/project/netdevbpf/patch/20210914170004.4185659-1-andrii@kernel.org/  
> >
> > That really needs to be applied to the bpf-next tree (presumably with
> > the appropriate Acks).
> >  
> 
> This is perf code that's not in bpf-next yet.

Then you need to think of a solution for the bpf-next tree, as it will
not build (allmodconfig) when combined with Linus' current tree.  And
when it is merged into the net-next tree, that tree will be broken as
well.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-09-14 23:38   ` Stephen Rothwell
@ 2021-09-14 23:40     ` Andrii Nakryiko
  2021-09-14 23:59       ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Andrii Nakryiko @ 2021-09-14 23:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking, Andrii Nakryiko,
	Quentin Monnet, Linux Kernel Mailing List,
	Linux Next Mailing List, Arnaldo Carvalho de Melo, Jiri Olsa

On Tue, Sep 14, 2021 at 4:38 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Andrii,
>
> On Tue, 14 Sep 2021 16:25:55 -0700 Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> >
> > On Mon, Sep 13, 2021 at 6:37 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the bpf-next tree, today's linux-next build (perf) failed
> > > like this:
> > >
> > > util/bpf-event.c: In function 'btf__load_from_kernel_by_id':
> > > util/bpf-event.c:27:8: error: 'btf__get_from_id' is deprecated: libbpf v0.6+: use btf__load_from_kernel_by_id instead [-Werror=deprecated-declarations]
> > >    27 |        int err = btf__get_from_id(id, &btf);
> > >       |        ^~~
> > > In file included from util/bpf-event.c:5:
> > > /home/sfr/next/next/tools/lib/bpf/btf.h:54:16: note: declared here
> > >    54 | LIBBPF_API int btf__get_from_id(__u32 id, struct btf **btf);
> > >       |                ^~~~~~~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > >   0b46b7550560 ("libbpf: Add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations")
> >
> > Should be fixed by [0], when applied to perf tree. Thanks for reporting!
> >
> >   [0] https://patchwork.kernel.org/project/netdevbpf/patch/20210914170004.4185659-1-andrii@kernel.org/
>
> That really needs to be applied to the bpf-next tree (presumably with
> the appropriate Acks).
>

This is perf code that's not in bpf-next yet.


> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-09-14 23:25 ` Andrii Nakryiko
@ 2021-09-14 23:38   ` Stephen Rothwell
  2021-09-14 23:40     ` Andrii Nakryiko
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2021-09-14 23:38 UTC (permalink / raw)
  To: Andrii Nakryiko
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking, Andrii Nakryiko,
	Quentin Monnet, Linux Kernel Mailing List,
	Linux Next Mailing List, Arnaldo Carvalho de Melo, Jiri Olsa

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

Hi Andrii,

On Tue, 14 Sep 2021 16:25:55 -0700 Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Sep 13, 2021 at 6:37 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the bpf-next tree, today's linux-next build (perf) failed
> > like this:
> >
> > util/bpf-event.c: In function 'btf__load_from_kernel_by_id':
> > util/bpf-event.c:27:8: error: 'btf__get_from_id' is deprecated: libbpf v0.6+: use btf__load_from_kernel_by_id instead [-Werror=deprecated-declarations]
> >    27 |        int err = btf__get_from_id(id, &btf);
> >       |        ^~~
> > In file included from util/bpf-event.c:5:
> > /home/sfr/next/next/tools/lib/bpf/btf.h:54:16: note: declared here
> >    54 | LIBBPF_API int btf__get_from_id(__u32 id, struct btf **btf);
> >       |                ^~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> >   0b46b7550560 ("libbpf: Add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations")  
> 
> Should be fixed by [0], when applied to perf tree. Thanks for reporting!
> 
>   [0] https://patchwork.kernel.org/project/netdevbpf/patch/20210914170004.4185659-1-andrii@kernel.org/

That really needs to be applied to the bpf-next tree (presumably with
the appropriate Acks).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-09-14  1:37 Stephen Rothwell
@ 2021-09-14 23:25 ` Andrii Nakryiko
  2021-09-14 23:38   ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Andrii Nakryiko @ 2021-09-14 23:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking, Andrii Nakryiko,
	Quentin Monnet, Linux Kernel Mailing List,
	Linux Next Mailing List, Arnaldo Carvalho de Melo, Jiri Olsa

On Mon, Sep 13, 2021 at 6:37 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (perf) failed
> like this:
>
> util/bpf-event.c: In function 'btf__load_from_kernel_by_id':
> util/bpf-event.c:27:8: error: 'btf__get_from_id' is deprecated: libbpf v0.6+: use btf__load_from_kernel_by_id instead [-Werror=deprecated-declarations]
>    27 |        int err = btf__get_from_id(id, &btf);
>       |        ^~~
> In file included from util/bpf-event.c:5:
> /home/sfr/next/next/tools/lib/bpf/btf.h:54:16: note: declared here
>    54 | LIBBPF_API int btf__get_from_id(__u32 id, struct btf **btf);
>       |                ^~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   0b46b7550560 ("libbpf: Add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations")

Should be fixed by [0], when applied to perf tree. Thanks for reporting!

  [0] https://patchwork.kernel.org/project/netdevbpf/patch/20210914170004.4185659-1-andrii@kernel.org/

>
> I have used the bpf-next tree from next-20210913 for today.
>
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2021-09-14  1:37 Stephen Rothwell
  2021-09-14 23:25 ` Andrii Nakryiko
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2021-09-14  1:37 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Andrii Nakryiko, Quentin Monnet, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (perf) failed
like this:

util/bpf-event.c: In function 'btf__load_from_kernel_by_id':
util/bpf-event.c:27:8: error: 'btf__get_from_id' is deprecated: libbpf v0.6+: use btf__load_from_kernel_by_id instead [-Werror=deprecated-declarations]
   27 |        int err = btf__get_from_id(id, &btf);
      |        ^~~
In file included from util/bpf-event.c:5:
/home/sfr/next/next/tools/lib/bpf/btf.h:54:16: note: declared here
   54 | LIBBPF_API int btf__get_from_id(__u32 id, struct btf **btf);
      |                ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  0b46b7550560 ("libbpf: Add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations")

I have used the bpf-next tree from next-20210913 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-03-12  1:00   ` Stephen Rothwell
@ 2021-03-26  1:18     ` Stephen Rothwell
  0 siblings, 0 replies; 52+ messages in thread
From: Stephen Rothwell @ 2021-03-26  1:18 UTC (permalink / raw)
  To: Björn Töpel
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking, Andrii Nakryiko,
	Björn Töpel, Linux Kernel Mailing List,
	Linux Next Mailing List, David Miller, Jakub Kicinski,
	Masahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

Hi all,

On Fri, 12 Mar 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> [Cc'ing a few (maybe) interested parties]
> 
> On Thu, 11 Mar 2021 07:47:03 +0100 Björn Töpel <bjorn.topel@intel.com> wrote:
> >
> > On 2021-03-11 01:47, Stephen Rothwell wrote:  
> > > 
> > > After merging the bpf-next tree, today's linux-next build (perf) failed
> > > like this:
> > > 
> > > make[3]: *** No rule to make target 'libbpf_util.h', needed by '/home/sfr/next/perf/staticobjs/xsk.o'.  Stop.  
> > 
> > It's an incremental build issue, as pointed out here [1], that is
> > resolved by cleaning the build.  
> 
> Does this mean there is a deficiency in the dependencies in our build system?
> 
> > [1] https://lore.kernel.org/bpf/CAEf4BzYPDF87At4=_gsndxof84OiqyJxgAHL7_jvpuntovUQ8w@mail.gmail.com/
> >   
> > > Caused by commit
> > > 
> > >    7e8bbe24cb8b ("libbpf: xsk: Move barriers from libbpf_util.h to xsk.h")
> > > 
> > > I have used the bpf tree from next-20210310 for today.  
> 
> I have set my system to remove the object directory before building
> after merging the bpf-next tree for now.

I now get this build failure after I merge the net-next tree :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-03-11  6:47 ` Björn Töpel
@ 2021-03-12  1:00   ` Stephen Rothwell
  2021-03-26  1:18     ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2021-03-12  1:00 UTC (permalink / raw)
  To: Björn Töpel
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking, Andrii Nakryiko,
	Björn Töpel, Linux Kernel Mailing List,
	Linux Next Mailing List, David Miller, Jakub Kicinski,
	Masahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

Hi Björn,

[Cc'ing a few (maybe) interested parties]

On Thu, 11 Mar 2021 07:47:03 +0100 Björn Töpel <bjorn.topel@intel.com> wrote:
>
> On 2021-03-11 01:47, Stephen Rothwell wrote:
> > 
> > After merging the bpf-next tree, today's linux-next build (perf) failed
> > like this:
> > 
> > make[3]: *** No rule to make target 'libbpf_util.h', needed by '/home/sfr/next/perf/staticobjs/xsk.o'.  Stop.
> 
> It's an incremental build issue, as pointed out here [1], that is
> resolved by cleaning the build.

Does this mean there is a deficiency in the dependencies in our build system?

> [1] https://lore.kernel.org/bpf/CAEf4BzYPDF87At4=_gsndxof84OiqyJxgAHL7_jvpuntovUQ8w@mail.gmail.com/
> 
> > Caused by commit
> > 
> >    7e8bbe24cb8b ("libbpf: xsk: Move barriers from libbpf_util.h to xsk.h")
> > 
> > I have used the bpf tree from next-20210310 for today.

I have set my system to remove the object directory before building
after merging the bpf-next tree for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2021-03-11  0:47 Stephen Rothwell
@ 2021-03-11  6:47 ` Björn Töpel
  2021-03-12  1:00   ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Björn Töpel @ 2021-03-11  6:47 UTC (permalink / raw)
  To: Stephen Rothwell, Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Andrii Nakryiko, Björn Töpel,
	Linux Kernel Mailing List, Linux Next Mailing List

On 2021-03-11 01:47, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (perf) failed
> like this:
> 
> make[3]: *** No rule to make target 'libbpf_util.h', needed by '/home/sfr/next/perf/staticobjs/xsk.o'.  Stop.
>

Hi Stephen,

It's an incremental build issue, as pointed out here [1], that is
resolved by cleaning the build.


Cheers,
Björn

[1] 
https://lore.kernel.org/bpf/CAEf4BzYPDF87At4=_gsndxof84OiqyJxgAHL7_jvpuntovUQ8w@mail.gmail.com/


> Caused by commit
> 
>    7e8bbe24cb8b ("libbpf: xsk: Move barriers from libbpf_util.h to xsk.h")
> 
> I have used the bpf tree from next-20210310 for today.
> 

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2021-03-11  0:47 Stephen Rothwell
  2021-03-11  6:47 ` Björn Töpel
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2021-03-11  0:47 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Andrii Nakryiko, Björn Töpel, Björn Töpel,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (perf) failed
like this:

make[3]: *** No rule to make target 'libbpf_util.h', needed by '/home/sfr/next/perf/staticobjs/xsk.o'.  Stop.

Caused by commit

  7e8bbe24cb8b ("libbpf: xsk: Move barriers from libbpf_util.h to xsk.h")

I have used the bpf tree from next-20210310 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-12-01  8:07 Stephen Rothwell
@ 2020-12-01 14:55 ` Daniel Borkmann
  0 siblings, 0 replies; 52+ messages in thread
From: Daniel Borkmann @ 2020-12-01 14:55 UTC (permalink / raw)
  To: Stephen Rothwell, Alexei Starovoitov, Networking
  Cc: Björn Töpel, Linux Kernel Mailing List,
	Linux Next Mailing List

On 12/1/20 9:07 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (x86_64
> allnoconfig) failed like this:
> 
> In file included from fs/select.c:32:
> include/net/busy_poll.h: In function 'sk_mark_napi_id_once':
> include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id'
>    150 |  __sk_mark_napi_id_once_xdp(sk, skb->napi_id);
>        |                                    ^~
> 
> Caused by commit
> 
>    b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")
> 

Fixed it up in bpf-next, thanks for reporting!

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2020-12-01  8:07 Stephen Rothwell
  2020-12-01 14:55 ` Daniel Borkmann
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-12-01  8:07 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Björn Töpel, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (x86_64
allnoconfig) failed like this:

In file included from fs/select.c:32:
include/net/busy_poll.h: In function 'sk_mark_napi_id_once':
include/net/busy_poll.h:150:36: error: 'const struct sk_buff' has no member named 'napi_id'
  150 |  __sk_mark_napi_id_once_xdp(sk, skb->napi_id);
      |                                    ^~

Caused by commit

  b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")

sk_buff only has a napi_id if defined(CONFIG_NET_RX_BUSY_POLL) ||
defined(CONFIG_XPS).

I have applied the following patch for today.

From bd2a1a4a773c1f306460b4309b12cad245a5edad Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 1 Dec 2020 19:02:58 +1100
Subject: [PATCH] fix for "xsk: Propagate napi_id to XDP socket Rx path"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/net/busy_poll.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/net/busy_poll.h b/include/net/busy_poll.h
index 45b3e04b99d3..07a88f592e72 100644
--- a/include/net/busy_poll.h
+++ b/include/net/busy_poll.h
@@ -147,7 +147,9 @@ static inline void __sk_mark_napi_id_once_xdp(struct sock *sk, unsigned int napi
 static inline void sk_mark_napi_id_once(struct sock *sk,
 					const struct sk_buff *skb)
 {
+#ifdef CONFIG_NET_RX_BUSY_POLL
 	__sk_mark_napi_id_once_xdp(sk, skb->napi_id);
+#endif
 }
 
 static inline void sk_mark_napi_id_once_xdp(struct sock *sk,
-- 
2.29.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-09-08  3:08 Stephen Rothwell
@ 2020-09-08 17:54 ` Andrii Nakryiko
  0 siblings, 0 replies; 52+ messages in thread
From: Andrii Nakryiko @ 2020-09-08 17:54 UTC (permalink / raw)
  To: Stephen Rothwell, Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 9/7/20 8:08 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (powerpcle perf)
> failed like this:
> 
> util/bpf-loader.c: In function 'config_bpf_program':
> util/bpf-loader.c:331:2: error: 'bpf_program__title' is deprecated: BPF program title is confusing term; please use bpf_program__section_name() instead [-Werror=deprecated-declarations]
>    331 |  config_str = bpf_program__title(prog, false);
>        |  ^~~~~~~~~~
> In file included from util/bpf-loader.c:10:
> tools/lib/bpf/libbpf.h:203:13: note: declared here
>    203 | const char *bpf_program__title(const struct bpf_program *prog, bool needs_copy);
>        |             ^~~~~~~~~~~~~~~~~~
> util/bpf-loader.c: In function 'preproc_gen_prologue':
> util/bpf-loader.c:457:3: error: 'bpf_program__title' is deprecated: BPF program title is confusing term; please use bpf_program__section_name() instead [-Werror=deprecated-declarations]
>    457 |   title = bpf_program__title(prog, false);
>        |   ^~~~~
> In file included from util/bpf-loader.c:10:
> tools/lib/bpf/libbpf.h:203:13: note: declared here
>    203 | const char *bpf_program__title(const struct bpf_program *prog, bool needs_copy);
>        |             ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused or exposed by commit
> 
>    521095842027 ("libbpf: Deprecate notion of BPF program "title" in favor of "section name"")
> 
> I have used the bpf-next tree from next-20200903 for today.
> 

perf code is using deprecated bpf_program__title() API. I'll send a 
patch for bpf-next to replace it with bpf_program__section_name(). 
Thanks for letting me know about build warning!

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2020-09-08  3:08 Stephen Rothwell
  2020-09-08 17:54 ` Andrii Nakryiko
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-09-08  3:08 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Andrii Nakryiko, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpcle perf)
failed like this:

util/bpf-loader.c: In function 'config_bpf_program':
util/bpf-loader.c:331:2: error: 'bpf_program__title' is deprecated: BPF program title is confusing term; please use bpf_program__section_name() instead [-Werror=deprecated-declarations]
  331 |  config_str = bpf_program__title(prog, false);
      |  ^~~~~~~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:203:13: note: declared here
  203 | const char *bpf_program__title(const struct bpf_program *prog, bool needs_copy);
      |             ^~~~~~~~~~~~~~~~~~
util/bpf-loader.c: In function 'preproc_gen_prologue':
util/bpf-loader.c:457:3: error: 'bpf_program__title' is deprecated: BPF program title is confusing term; please use bpf_program__section_name() instead [-Werror=deprecated-declarations]
  457 |   title = bpf_program__title(prog, false);
      |   ^~~~~
In file included from util/bpf-loader.c:10:
tools/lib/bpf/libbpf.h:203:13: note: declared here
  203 | const char *bpf_program__title(const struct bpf_program *prog, bool needs_copy);
      |             ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused or exposed by commit

  521095842027 ("libbpf: Deprecate notion of BPF program "title" in favor of "section name"")

I have used the bpf-next tree from next-20200903 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25 22:34               ` Alexei Starovoitov
@ 2020-08-25 23:09                 ` Stephen Rothwell
  0 siblings, 0 replies; 52+ messages in thread
From: Stephen Rothwell @ 2020-08-25 23:09 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

Hi Alexei,

On Tue, 25 Aug 2020 15:34:52 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Aug 25, 2020 at 2:10 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Alexei,
> >
> > On Tue, 25 Aug 2020 07:33:51 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:  
> > >
> > > what do you suggest to use to make it 'manually enabled' ?
> > > All I could think of is to add:
> > > depends on !COMPILE_TEST
> > > so that allmodconfig doesn't pick it up.  
> >
> > That is probably sufficient.  Some gcc plugins and kasan bits, etc use
> > just that.  
> 
> Ok. Pushed the silencing 'fix':
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=2532f849b5134c4c62a20e5aaca33d9fb08af528

Thanks for that.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25 21:10             ` Stephen Rothwell
@ 2020-08-25 22:34               ` Alexei Starovoitov
  2020-08-25 23:09                 ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Alexei Starovoitov @ 2020-08-25 22:34 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

On Tue, Aug 25, 2020 at 2:10 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Alexei,
>
> On Tue, 25 Aug 2020 07:33:51 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> >
> > what do you suggest to use to make it 'manually enabled' ?
> > All I could think of is to add:
> > depends on !COMPILE_TEST
> > so that allmodconfig doesn't pick it up.
>
> That is probably sufficient.  Some gcc plugins and kasan bits, etc use
> just that.

Ok. Pushed the silencing 'fix':
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=2532f849b5134c4c62a20e5aaca33d9fb08af528

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25 14:33           ` Alexei Starovoitov
@ 2020-08-25 21:10             ` Stephen Rothwell
  2020-08-25 22:34               ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-08-25 21:10 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Hi Alexei,

On Tue, 25 Aug 2020 07:33:51 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> what do you suggest to use to make it 'manually enabled' ?
> All I could think of is to add:
> depends on !COMPILE_TEST
> so that allmodconfig doesn't pick it up.

That is probably sufficient.  Some gcc plugins and kasan bits, etc use
just that.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25  6:50         ` Stephen Rothwell
@ 2020-08-25 14:33           ` Alexei Starovoitov
  2020-08-25 21:10             ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Alexei Starovoitov @ 2020-08-25 14:33 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

On Mon, Aug 24, 2020 at 11:50 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Alexei,
>
> On Mon, 24 Aug 2020 20:27:28 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> >
> > I didn't receive the first email you've replied to.
> > The build error is:
> > "
> > No libelf found
> > make[5]: *** [Makefile:284: elfdep] Error 1
> > "
> > and build process stops because libelf is not found, right?
> > That is expected and necessary.
> > bpf_preload needs libbpf that depends on libelf.
> > The only 'fix' is to turn off bpf_preload.
> > It's off by default.
> > allmodconfig cannot build bpf_preload umd if there is no libelf.
> > There is CC_CAN_LINK that does feature detection.
> > We can extend scripts/cc-can-link.sh or add another script that
> > will do CC_CAN_LINK_LIBELF, but such approach doesn't scale.
> > imo it's cleaner to rely on feature detection by libbpf Makefile with
> > an error above instead of adding such knobs to top Kconfig.
> > Does it make sense?
>
> Sorry, but if this is not necessary to build the kernel, then an
> allmodconfig build needs to succeed so you need to do the detection and
> turn it off automatically.  Or you could make it so that it has to be
> manually enabled in all circumstances.

what do you suggest to use to make it 'manually enabled' ?
All I could think of is to add:
depends on !COMPILE_TEST
so that allmodconfig doesn't pick it up.

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25  3:27       ` Alexei Starovoitov
@ 2020-08-25  6:50         ` Stephen Rothwell
  2020-08-25 14:33           ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-08-25  6:50 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

Hi Alexei,

On Mon, 24 Aug 2020 20:27:28 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> I didn't receive the first email you've replied to.
> The build error is:
> "
> No libelf found
> make[5]: *** [Makefile:284: elfdep] Error 1
> "
> and build process stops because libelf is not found, right?
> That is expected and necessary.
> bpf_preload needs libbpf that depends on libelf.
> The only 'fix' is to turn off bpf_preload.
> It's off by default.
> allmodconfig cannot build bpf_preload umd if there is no libelf.
> There is CC_CAN_LINK that does feature detection.
> We can extend scripts/cc-can-link.sh or add another script that
> will do CC_CAN_LINK_LIBELF, but such approach doesn't scale.
> imo it's cleaner to rely on feature detection by libbpf Makefile with
> an error above instead of adding such knobs to top Kconfig.
> Does it make sense?

Sorry, but if this is not necessary to build the kernel, then an
allmodconfig build needs to succeed so you need to do the detection and
turn it off automatically.  Or you could make it so that it has to be
manually enabled in all circumstances.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25  3:04     ` Stephen Rothwell
@ 2020-08-25  3:27       ` Alexei Starovoitov
  2020-08-25  6:50         ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Alexei Starovoitov @ 2020-08-25  3:27 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

On Mon, Aug 24, 2020 at 8:04 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Alexei,
>
> On Mon, 24 Aug 2020 18:25:44 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> >
> > On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the bpf-next tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > Auto-detecting system features:
> > > > ...                        libelf: [  [31mOFF [m ]
> > > > ...                          zlib: [  [31mOFF [m ]
> > > > ...                           bpf: [  [32mon [m  ]
> > > >
> > > > No libelf found
> > > > make[5]: *** [Makefile:284: elfdep] Error 1
> > > >
> > > > Caused by commit
> > > >
> > > >   d71fa5c9763c ("bpf: Add kernel module with user mode driver that populates bpffs.")
> > > >
> > > > [For a start, can we please *not* add this verbose feature detection
> > > > output to the nrormal build?]
> > > >
> > > > This is a PowerPC hosted cross build.
> > > >
> > > > I have marked BPF_PRELOAD as BROKEN for now.
> > >
> > > Still getting this failure ...
> >
> > I don't have powerpc with crosscompiler to x86 to reproduce.
> > What exactly the error?
>
> Just as above.

I didn't receive the first email you've replied to.
The build error is:
"
No libelf found
make[5]: *** [Makefile:284: elfdep] Error 1
"
and build process stops because libelf is not found, right?
That is expected and necessary.
bpf_preload needs libbpf that depends on libelf.
The only 'fix' is to turn off bpf_preload.
It's off by default.
allmodconfig cannot build bpf_preload umd if there is no libelf.
There is CC_CAN_LINK that does feature detection.
We can extend scripts/cc-can-link.sh or add another script that
will do CC_CAN_LINK_LIBELF, but such approach doesn't scale.
imo it's cleaner to rely on feature detection by libbpf Makefile with
an error above instead of adding such knobs to top Kconfig.
Does it make sense?

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25  1:25   ` Alexei Starovoitov
@ 2020-08-25  3:04     ` Stephen Rothwell
  2020-08-25  3:27       ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-08-25  3:04 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

Hi Alexei,

On Mon, 24 Aug 2020 18:25:44 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the bpf-next tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > Auto-detecting system features:
> > > ...                        libelf: [  [31mOFF [m ]
> > > ...                          zlib: [  [31mOFF [m ]
> > > ...                           bpf: [  [32mon [m  ]
> > >
> > > No libelf found
> > > make[5]: *** [Makefile:284: elfdep] Error 1
> > >
> > > Caused by commit
> > >
> > >   d71fa5c9763c ("bpf: Add kernel module with user mode driver that populates bpffs.")
> > >
> > > [For a start, can we please *not* add this verbose feature detection
> > > output to the nrormal build?]
> > >
> > > This is a PowerPC hosted cross build.
> > >
> > > I have marked BPF_PRELOAD as BROKEN for now.  
> >
> > Still getting this failure ...  
> 
> I don't have powerpc with crosscompiler to x86 to reproduce.
> What exactly the error?

Just as above.

> bpf_preload has:
> "depends on CC_CAN_LINK"
> which is exactly the same as bpfilter.
> You should have seen this issue with bpfilter for years now.

Well, I haven't :-)  It just started the other day when that commit
appeared.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-25  1:20 ` Stephen Rothwell
@ 2020-08-25  1:25   ` Alexei Starovoitov
  2020-08-25  3:04     ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Alexei Starovoitov @ 2020-08-25  1:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, David Miller

On Mon, Aug 24, 2020 at 6:20 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the bpf-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > Auto-detecting system features:
> > ...                        libelf: [  [31mOFF [m ]
> > ...                          zlib: [  [31mOFF [m ]
> > ...                           bpf: [  [32mon [m  ]
> >
> > No libelf found
> > make[5]: *** [Makefile:284: elfdep] Error 1
> >
> > Caused by commit
> >
> >   d71fa5c9763c ("bpf: Add kernel module with user mode driver that populates bpffs.")
> >
> > [For a start, can we please *not* add this verbose feature detection
> > output to the nrormal build?]
> >
> > This is a PowerPC hosted cross build.
> >
> > I have marked BPF_PRELOAD as BROKEN for now.
>
> Still getting this failure ...

I don't have powerpc with crosscompiler to x86 to reproduce.
What exactly the error?
bpf_preload has:
"depends on CC_CAN_LINK"
which is exactly the same as bpfilter.
You should have seen this issue with bpfilter for years now.

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-08-21  1:11 Stephen Rothwell
@ 2020-08-25  1:20 ` Stephen Rothwell
  2020-08-25  1:25   ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-08-25  1:20 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, David Miller

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Hi all,

On Fri, 21 Aug 2020 11:11:11 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> Auto-detecting system features:
> ...                        libelf: [ ^[[31mOFF^[[m ]
> ...                          zlib: [ ^[[31mOFF^[[m ]
> ...                           bpf: [ ^[[32mon^[[m  ]
> 
> No libelf found
> make[5]: *** [Makefile:284: elfdep] Error 1
> 
> Caused by commit
> 
>   d71fa5c9763c ("bpf: Add kernel module with user mode driver that populates bpffs.")
> 
> [For a start, can we please *not* add this verbose feature detection
> output to the nrormal build?]
> 
> This is a PowerPC hosted cross build.
> 
> I have marked BPF_PRELOAD as BROKEN for now.

Still getting this failure ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2020-08-21  1:11 Stephen Rothwell
  2020-08-25  1:20 ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-08-21  1:11 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

Auto-detecting system features:
...                        libelf: [ ^[[31mOFF^[[m ]
...                          zlib: [ ^[[31mOFF^[[m ]
...                           bpf: [ ^[[32mon^[[m  ]

No libelf found
make[5]: *** [Makefile:284: elfdep] Error 1

Caused by commit

  d71fa5c9763c ("bpf: Add kernel module with user mode driver that populates bpffs.")

[For a start, can we please *not* add this verbose feature detection
output to the nrormal build?]

This is a PowerPC hosted cross build.

I have marked BPF_PRELOAD as BROKEN for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-07-14  8:31   ` Jiri Olsa
@ 2020-07-14  9:19     ` Geert Uytterhoeven
  0 siblings, 0 replies; 52+ messages in thread
From: Geert Uytterhoeven @ 2020-07-14  9:19 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: Stephen Rothwell, Daniel Borkmann, Alexei Starovoitov,
	Networking, Linux Next Mailing List, Linux Kernel Mailing List,
	Jiri Olsa

Hi Jiri,

On Tue, Jul 14, 2020 at 10:33 AM Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Jul 14, 2020 at 08:16:54AM +0200, Jiri Olsa wrote:
> > On Tue, Jul 14, 2020 at 12:22:47PM +1000, Stephen Rothwell wrote:
> > > After merging the bpf-next tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > tmp/ccsqpVCY.s: Assembler messages:
> > > tmp/ccsqpVCY.s:78: Error: unrecognized symbol type ""
> > > tmp/ccsqpVCY.s:91: Error: unrecognized symbol type ""
> > >
> > > I don't know what has caused this (I guess maybe the resolve_btfids
> > > branch).
> > >
> > > I have used the bpf-next tree from next-20200713 for today.

Bummer, didn't find this report before I had bisected this to
c9a0f3b85e09dd16 ("bpf: Resolve BTF IDs in vmlinux image"), and
investigated the root cause (@object) myself, as the failing file path
(net/core/filter.o) was not mentioned...

> > ok, trying to reproduce
>
> damn crossbuilds.. change below fixes it for me,
> will do some more testing and post it today

Thanks, this fixes my (cross)arm32 build, and the (cross)arm64 build
keeps working, and everything boots, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-07-14  6:16 ` Jiri Olsa
@ 2020-07-14  8:31   ` Jiri Olsa
  2020-07-14  9:19     ` Geert Uytterhoeven
  0 siblings, 1 reply; 52+ messages in thread
From: Jiri Olsa @ 2020-07-14  8:31 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, Jiri Olsa

On Tue, Jul 14, 2020 at 08:16:54AM +0200, Jiri Olsa wrote:
> On Tue, Jul 14, 2020 at 12:22:47PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the bpf-next tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > tmp/ccsqpVCY.s: Assembler messages:
> > tmp/ccsqpVCY.s:78: Error: unrecognized symbol type ""
> > tmp/ccsqpVCY.s:91: Error: unrecognized symbol type ""
> > 
> > I don't know what has caused this (I guess maybe the resolve_btfids
> > branch).
> > 
> > I have used the bpf-next tree from next-20200713 for today.
> 
> ok, trying to reproduce

damn crossbuilds.. change below fixes it for me,
will do some more testing and post it today

jirka


---
diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
index fe019774f8a7..8b9194e22c7c 100644
--- a/include/linux/btf_ids.h
+++ b/include/linux/btf_ids.h
@@ -21,7 +21,7 @@
 asm(							\
 ".pushsection " BTF_IDS_SECTION ",\"a\";       \n"	\
 ".local " #symbol " ;                          \n"	\
-".type  " #symbol ", @object;                  \n"	\
+".type  " #symbol ", STT_OBJECT;               \n"	\
 ".size  " #symbol ", 4;                        \n"	\
 #symbol ":                                     \n"	\
 ".zero 4                                       \n"	\
diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile
index 948378ca73d4..a88cd4426398 100644
--- a/tools/bpf/resolve_btfids/Makefile
+++ b/tools/bpf/resolve_btfids/Makefile
@@ -16,6 +16,20 @@ else
   MAKEFLAGS=--no-print-directory
 endif
 
+# always use the host compiler
+ifneq ($(LLVM),)
+HOSTAR  ?= llvm-ar
+HOSTCC  ?= clang
+HOSTLD  ?= ld.lld
+else
+HOSTAR  ?= ar
+HOSTCC  ?= gcc
+HOSTLD  ?= ld
+endif
+AR       = $(HOSTAR)
+CC       = $(HOSTCC)
+LD       = $(HOSTLD)
+
 OUTPUT ?= $(srctree)/tools/bpf/resolve_btfids/
 
 LIBBPF_SRC := $(srctree)/tools/lib/bpf/


^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2020-07-14  2:22 Stephen Rothwell
@ 2020-07-14  6:16 ` Jiri Olsa
  2020-07-14  8:31   ` Jiri Olsa
  0 siblings, 1 reply; 52+ messages in thread
From: Jiri Olsa @ 2020-07-14  6:16 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List, Jiri Olsa

On Tue, Jul 14, 2020 at 12:22:47PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> tmp/ccsqpVCY.s: Assembler messages:
> tmp/ccsqpVCY.s:78: Error: unrecognized symbol type ""
> tmp/ccsqpVCY.s:91: Error: unrecognized symbol type ""
> 
> I don't know what has caused this (I guess maybe the resolve_btfids
> branch).
> 
> I have used the bpf-next tree from next-20200713 for today.

ok, trying to reproduce

thanks,
jirka


^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2020-07-14  2:22 Stephen Rothwell
  2020-07-14  6:16 ` Jiri Olsa
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2020-07-14  2:22 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jiri Olsa

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

tmp/ccsqpVCY.s: Assembler messages:
tmp/ccsqpVCY.s:78: Error: unrecognized symbol type ""
tmp/ccsqpVCY.s:91: Error: unrecognized symbol type ""

I don't know what has caused this (I guess maybe the resolve_btfids
branch).

I have used the bpf-next tree from next-20200713 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2019-07-01  4:57 Stephen Rothwell
@ 2019-07-01  5:01 ` Stephen Rothwell
  0 siblings, 0 replies; 52+ messages in thread
From: Stephen Rothwell @ 2019-07-01  5:01 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking, David Miller
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Maxim Mikityanskiy, Tal Gilboa, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 3664 bytes --]

Hi all,

On Mon, 1 Jul 2019 14:57:22 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the bpf-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:1605:5: error: conflicting types for 'mlx5e_open_cq'
>  int mlx5e_open_cq(struct mlx5e_channel *c, struct dim_cq_moder moder,
>      ^~~~~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:43:
> drivers/net/ethernet/mellanox/mlx5/core/en.h:977:5: note: previous declaration of 'mlx5e_open_cq' was here
>  int mlx5e_open_cq(struct mlx5e_channel *c, struct net_dim_cq_moder moder,
>      ^~~~~~~~~~~~~
> 
> Caused by commit
> 
>   8960b38932be ("linux/dim: Rename externally used net_dim members")
> 
> from the net-next tree interacting with commit
> 
>   db05815b36cb ("net/mlx5e: Add XSK zero-copy support")
> 
> I have applied the following merge fix patch.
> 
> From 8e92dbee0daa6bac412daebd08073ba9ca31c7a6 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 1 Jul 2019 14:55:02 +1000
> Subject: [PATCH] net/mlx5e: fix up for "linux/dim: Rename externally used
>  net_dim members"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index 9cebaa642727..f0d77eb66acf 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> @@ -974,7 +974,7 @@ int mlx5e_open_xdpsq(struct mlx5e_channel *c, struct mlx5e_params *params,
>  void mlx5e_close_xdpsq(struct mlx5e_xdpsq *sq);
>  
>  struct mlx5e_cq_param;
> -int mlx5e_open_cq(struct mlx5e_channel *c, struct net_dim_cq_moder moder,
> +int mlx5e_open_cq(struct mlx5e_channel *c, struct dim_cq_moder moder,
>  		  struct mlx5e_cq_param *param, struct mlx5e_cq *cq);
>  void mlx5e_close_cq(struct mlx5e_cq *cq);
>  

Also, this:

drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c: In function 'mlx5e_open_xsk':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c:64:9: error: variable 'icocq_moder' has initializer but incomplete type
  struct net_dim_cq_moder icocq_moder = {};
         ^~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c:64:26: error: storage size of 'icocq_moder' isn't known
  struct net_dim_cq_moder icocq_moder = {};
                          ^~~~~~~~~~~

For which I applied this:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 1 Jul 2019 15:00:08 +1000
Subject: [PATCH] another fix for "linux/dim: Rename externally used net_dim
 members"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
index 9b4d47c47c92..aaffa6f68dc0 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
@@ -61,7 +61,7 @@ int mlx5e_open_xsk(struct mlx5e_priv *priv, struct mlx5e_params *params,
 		   struct mlx5e_channel *c)
 {
 	struct mlx5e_channel_param cparam = {};
-	struct net_dim_cq_moder icocq_moder = {};
+	struct dim_cq_moder icocq_moder = {};
 	int err;
 
 	if (!mlx5e_validate_xsk_param(params, xsk, priv->mdev))
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2019-07-01  4:57 Stephen Rothwell
  2019-07-01  5:01 ` Stephen Rothwell
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2019-07-01  4:57 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking, David Miller
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Maxim Mikityanskiy, Tal Gilboa, Saeed Mahameed

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/net/ethernet/mellanox/mlx5/core/en_main.c:1605:5: error: conflicting types for 'mlx5e_open_cq'
 int mlx5e_open_cq(struct mlx5e_channel *c, struct dim_cq_moder moder,
     ^~~~~~~~~~~~~
In file included from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:43:
drivers/net/ethernet/mellanox/mlx5/core/en.h:977:5: note: previous declaration of 'mlx5e_open_cq' was here
 int mlx5e_open_cq(struct mlx5e_channel *c, struct net_dim_cq_moder moder,
     ^~~~~~~~~~~~~

Caused by commit

  8960b38932be ("linux/dim: Rename externally used net_dim members")

from the net-next tree interacting with commit

  db05815b36cb ("net/mlx5e: Add XSK zero-copy support")

I have applied the following merge fix patch.

From 8e92dbee0daa6bac412daebd08073ba9ca31c7a6 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 1 Jul 2019 14:55:02 +1000
Subject: [PATCH] net/mlx5e: fix up for "linux/dim: Rename externally used
 net_dim members"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
index 9cebaa642727..f0d77eb66acf 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
@@ -974,7 +974,7 @@ int mlx5e_open_xdpsq(struct mlx5e_channel *c, struct mlx5e_params *params,
 void mlx5e_close_xdpsq(struct mlx5e_xdpsq *sq);
 
 struct mlx5e_cq_param;
-int mlx5e_open_cq(struct mlx5e_channel *c, struct net_dim_cq_moder moder,
+int mlx5e_open_cq(struct mlx5e_channel *c, struct dim_cq_moder moder,
 		  struct mlx5e_cq_param *param, struct mlx5e_cq *cq);
 void mlx5e_close_cq(struct mlx5e_cq *cq);
 
-- 
2.20.1



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2019-04-18  1:57 Stephen Rothwell
  0 siblings, 0 replies; 52+ messages in thread
From: Stephen Rothwell @ 2019-04-18  1:57 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Magnus Karlsson

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc perf)
failed like this:

In file included from xsk.c:32:
libbpf_util.h:49:3: error: #warning Architecture missing native barrier functions in libbpf_util.h. [-Werror=cpp]
 # warning Architecture missing native barrier functions in libbpf_util.h.
   ^~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xsk.h")

I have applied the following patch for today ... please fix this.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 18 Apr 2019 11:54:56 +1000
Subject: [PATCH] suppress warning in tools/lib/bpf/libbpf_util.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 tools/lib/bpf/libbpf_util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/libbpf_util.h b/tools/lib/bpf/libbpf_util.h
index 172b707e007b..a54eb2cdbdd6 100644
--- a/tools/lib/bpf/libbpf_util.h
+++ b/tools/lib/bpf/libbpf_util.h
@@ -46,7 +46,7 @@ do {				\
 # define libbpf_smp_mb() asm volatile("dmb ish" : : : "memory")
 # define libbpf_smp_rwmb() libbpf_smp_mb()
 #else
-# warning Architecture missing native barrier functions in libbpf_util.h.
+//# warning Architecture missing native barrier functions in libbpf_util.h.
 # define libbpf_smp_rmb() __sync_synchronize()
 # define libbpf_smp_wmb() __sync_synchronize()
 # define libbpf_smp_mb() __sync_synchronize()
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2019-02-28  1:31 Stephen Rothwell
@ 2019-02-28  2:18 ` Alexei Starovoitov
  0 siblings, 0 replies; 52+ messages in thread
From: Alexei Starovoitov @ 2019-02-28  2:18 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List

On Wed, Feb 27, 2019 at 5:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> kernel/sysctl.c:1238:13: error: 'sysctl_bpf_stats_enabled' undeclared here (not in a function); did you mean 'sysctl_base_table'?
>    .data  = &sysctl_bpf_stats_enabled,
>              ^~~~~~~~~~~~~~~~~~~~~~~~
>              sysctl_base_table
>
> Caused by commit
>
>   492ecee892c2 ("bpf: enable program stats")
>
> CONFIG_BPF=y
> # CONFIG_BPF_SYSCALL is not set
>
> I applied the following patch for today, but it should be done
> properly. Also this patch leaves proc_dointvec_minmax_bpf_stats() as an
> unused function.

thanks for the report.
working on the fix.

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2019-02-28  1:31 Stephen Rothwell
  2019-02-28  2:18 ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2019-02-28  1:31 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

kernel/sysctl.c:1238:13: error: 'sysctl_bpf_stats_enabled' undeclared here (not in a function); did you mean 'sysctl_base_table'?
   .data  = &sysctl_bpf_stats_enabled,
             ^~~~~~~~~~~~~~~~~~~~~~~~
             sysctl_base_table

Caused by commit

  492ecee892c2 ("bpf: enable program stats")

CONFIG_BPF=y
# CONFIG_BPF_SYSCALL is not set

I applied the following patch for today, but it should be done
properly. Also this patch leaves proc_dointvec_minmax_bpf_stats() as an
unused function.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Feb 2019 12:26:58 +1100
Subject: [PATCH] bpf: hack to make "enable program stats" build

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 kernel/sysctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 86e0771352f2..80a70f69cbd5 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1232,7 +1232,6 @@ static struct ctl_table kern_table[] = {
 		.extra1		= &one,
 		.extra2		= &one,
 	},
-#endif
 	{
 		.procname	= "bpf_stats_enabled",
 		.data		= &sysctl_bpf_stats_enabled,
@@ -1242,6 +1241,7 @@ static struct ctl_table kern_table[] = {
 		.extra1		= &zero,
 		.extra2		= &one,
 	},
+#endif
 #if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU)
 	{
 		.procname	= "panic_on_rcu_stall",
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2018-10-03  3:18 Stephen Rothwell
@ 2018-10-03  5:29 ` Joe Stringer
  0 siblings, 0 replies; 52+ messages in thread
From: Joe Stringer @ 2018-10-03  5:29 UTC (permalink / raw)
  To: sfr; +Cc: daniel, ast, netdev, linux-next, LKML, Joe Stringer

On Tue, 2 Oct 2018 at 20:19, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> x86_64-linux-gnu-ld: net/core/filter.o: in function `sk_lookup':
> (.text+0x19219): undefined reference to `__udp6_lib_lookup'
>
> Caused by commit
>
>   6acc9b432e67 ("bpf: Add helper to retrieve socket in BPF")
>
> I assume that __udp6_lib_lookup ended up in the IPv6 module.
>
> I used the bpf-next tree from next-20181002 for today.

My mistake, will send out a fix shortly.

Cheers,
Joe

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2018-10-03  3:18 Stephen Rothwell
  2018-10-03  5:29 ` Joe Stringer
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2018-10-03  3:18 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Joe Stringer

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

x86_64-linux-gnu-ld: net/core/filter.o: in function `sk_lookup':
(.text+0x19219): undefined reference to `__udp6_lib_lookup'

Caused by commit

  6acc9b432e67 ("bpf: Add helper to retrieve socket in BPF")

I assume that __udp6_lib_lookup ended up in the IPv6 module.

I used the bpf-next tree from next-20181002 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2018-09-07  5:21   ` Björn Töpel
@ 2018-09-07  5:45     ` Alexei Starovoitov
  0 siblings, 0 replies; 52+ messages in thread
From: Alexei Starovoitov @ 2018-09-07  5:45 UTC (permalink / raw)
  To: Björn Töpel
  Cc: sfr, Daniel Borkmann, ast, Netdev, linux-next, LKML,
	Björn Töpel

On Fri, Sep 07, 2018 at 07:21:05AM +0200, Björn Töpel wrote:
> Den fre 7 sep. 2018 kl 02:23 skrev Alexei Starovoitov
> <alexei.starovoitov@gmail.com>:
> >
> > On Fri, Sep 07, 2018 at 10:19:23AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the bpf-next tree, today's linux-next build (powerpc
> > > ppc64_defconfig) failed like this:
> > >
> > > ERROR: ".xsk_reuseq_swap" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
> > > ERROR: ".xsk_reuseq_free" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
> > > ERROR: ".xsk_reuseq_prepare" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined
> > >
> > > Caused by commit
> > >
> > >   9654bd10da60 ("i40e: clean zero-copy XDP Rx ring on shutdown/reset")
> > >
> > > CONFIG_XDP_SOCKETS is not set for this build.
> > >
> > > I have used the version of the bfp-next tree from next-20180906 for today.
> >
> > merge conflict and build error...
> > Bjorn, I'm thinking to toss the patches out of bpf-next and reapply
> > cleaned up version of the patches...
> > what do you think?
> >
> 
> Yes, do that. I'll get back with a cleaned up v2.

Done.

Unfortunately during interactive rebase that removed your commits git didn't
preserve merge commits that came after yours,
so Jesper's and Yonghong's cover letters are not in the git history.
Yet all patches are in the same order.
Explicit revert with trail in the git history would have been worse.
patchworks + git isn't the most convenient workflow. sigh.


^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2018-09-07  0:22 ` Alexei Starovoitov
@ 2018-09-07  5:21   ` Björn Töpel
  2018-09-07  5:45     ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Björn Töpel @ 2018-09-07  5:21 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: sfr, Daniel Borkmann, ast, Netdev, linux-next, LKML,
	Björn Töpel

Den fre 7 sep. 2018 kl 02:23 skrev Alexei Starovoitov
<alexei.starovoitov@gmail.com>:
>
> On Fri, Sep 07, 2018 at 10:19:23AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the bpf-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > ERROR: ".xsk_reuseq_swap" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
> > ERROR: ".xsk_reuseq_free" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
> > ERROR: ".xsk_reuseq_prepare" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined
> >
> > Caused by commit
> >
> >   9654bd10da60 ("i40e: clean zero-copy XDP Rx ring on shutdown/reset")
> >
> > CONFIG_XDP_SOCKETS is not set for this build.
> >
> > I have used the version of the bfp-next tree from next-20180906 for today.
>
> merge conflict and build error...
> Bjorn, I'm thinking to toss the patches out of bpf-next and reapply
> cleaned up version of the patches...
> what do you think?
>

Yes, do that. I'll get back with a cleaned up v2.


Thanks,
Björn

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2018-09-07  0:19 Stephen Rothwell
@ 2018-09-07  0:22 ` Alexei Starovoitov
  2018-09-07  5:21   ` Björn Töpel
  0 siblings, 1 reply; 52+ messages in thread
From: Alexei Starovoitov @ 2018-09-07  0:22 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux-Next Mailing List, Linux Kernel Mailing List,
	Björn Töpel

On Fri, Sep 07, 2018 at 10:19:23AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ERROR: ".xsk_reuseq_swap" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
> ERROR: ".xsk_reuseq_free" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
> ERROR: ".xsk_reuseq_prepare" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined
> 
> Caused by commit
> 
>   9654bd10da60 ("i40e: clean zero-copy XDP Rx ring on shutdown/reset")
> 
> CONFIG_XDP_SOCKETS is not set for this build.
> 
> I have used the version of the bfp-next tree from next-20180906 for today.

merge conflict and build error...
Bjorn, I'm thinking to toss the patches out of bpf-next and reapply
cleaned up version of the patches...
what do you think?


^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2018-09-07  0:19 Stephen Rothwell
  2018-09-07  0:22 ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2018-09-07  0:19 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Björn Töpel

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".xsk_reuseq_swap" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
ERROR: ".xsk_reuseq_free" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
ERROR: ".xsk_reuseq_prepare" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined

Caused by commit

  9654bd10da60 ("i40e: clean zero-copy XDP Rx ring on shutdown/reset")

CONFIG_XDP_SOCKETS is not set for this build.

I have used the version of the bfp-next tree from next-20180906 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 52+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2017-12-13  1:32 Stephen Rothwell
@ 2017-12-13  1:47 ` Alexei Starovoitov
  0 siblings, 0 replies; 52+ messages in thread
From: Alexei Starovoitov @ 2017-12-13  1:47 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Networking,
	Linux-Next Mailing List, Linux Kernel Mailing List,
	Yonghong Song

On Wed, Dec 13, 2017 at 12:32:45PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> kernel/events/core.o: In function `perf_ioctl':
> core.c:(.text+0x98c4): undefined reference to `bpf_event_query_prog_array'
> 
> Caused by commit
> 
>   f371b304f12e ("bpf/tracing: allow user space to query prog array on the same tp")
> 
> CONFIG_BPF_SYSCALL is not set for this build.
> 
> I have used the bpf-next tree from next-20171212 for today.

Thanks for the report.
Yonghong, please take a look and send a followup fix based on bpf-next tree.

^ permalink raw reply	[flat|nested] 52+ messages in thread

* linux-next: build failure after merge of the bpf-next tree
@ 2017-12-13  1:32 Stephen Rothwell
  2017-12-13  1:47 ` Alexei Starovoitov
  0 siblings, 1 reply; 52+ messages in thread
From: Stephen Rothwell @ 2017-12-13  1:32 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Yonghong Song

Hi all,

After merging the bpf-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

kernel/events/core.o: In function `perf_ioctl':
core.c:(.text+0x98c4): undefined reference to `bpf_event_query_prog_array'

Caused by commit

  f371b304f12e ("bpf/tracing: allow user space to query prog array on the same tp")

CONFIG_BPF_SYSCALL is not set for this build.

I have used the bpf-next tree from next-20171212 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 52+ messages in thread

end of thread, other threads:[~2022-07-20  3:44 UTC | newest]

Thread overview: 52+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26  1:50 linux-next: build failure after merge of the bpf-next tree Stephen Rothwell
2021-08-26  2:01 ` Daniel Xu
  -- strict thread matches above, loose matches on Subject: below --
2022-07-20  1:59 Stephen Rothwell
2022-07-20  3:42 ` Alexei Starovoitov
2022-07-20  3:44   ` Stanislav Fomichev
2022-04-19  1:56 Stephen Rothwell
2022-04-21  0:32 ` Stephen Rothwell
2022-04-21  9:45   ` Daniel Borkmann
2022-04-21 10:40     ` Maciej Fijalkowski
2022-02-09  0:21 Stephen Rothwell
2021-12-03  0:15 Stephen Rothwell
2021-09-14  1:37 Stephen Rothwell
2021-09-14 23:25 ` Andrii Nakryiko
2021-09-14 23:38   ` Stephen Rothwell
2021-09-14 23:40     ` Andrii Nakryiko
2021-09-14 23:59       ` Stephen Rothwell
2021-09-15  1:27         ` Alexei Starovoitov
2021-03-11  0:47 Stephen Rothwell
2021-03-11  6:47 ` Björn Töpel
2021-03-12  1:00   ` Stephen Rothwell
2021-03-26  1:18     ` Stephen Rothwell
2020-12-01  8:07 Stephen Rothwell
2020-12-01 14:55 ` Daniel Borkmann
2020-09-08  3:08 Stephen Rothwell
2020-09-08 17:54 ` Andrii Nakryiko
2020-08-21  1:11 Stephen Rothwell
2020-08-25  1:20 ` Stephen Rothwell
2020-08-25  1:25   ` Alexei Starovoitov
2020-08-25  3:04     ` Stephen Rothwell
2020-08-25  3:27       ` Alexei Starovoitov
2020-08-25  6:50         ` Stephen Rothwell
2020-08-25 14:33           ` Alexei Starovoitov
2020-08-25 21:10             ` Stephen Rothwell
2020-08-25 22:34               ` Alexei Starovoitov
2020-08-25 23:09                 ` Stephen Rothwell
2020-07-14  2:22 Stephen Rothwell
2020-07-14  6:16 ` Jiri Olsa
2020-07-14  8:31   ` Jiri Olsa
2020-07-14  9:19     ` Geert Uytterhoeven
2019-07-01  4:57 Stephen Rothwell
2019-07-01  5:01 ` Stephen Rothwell
2019-04-18  1:57 Stephen Rothwell
2019-02-28  1:31 Stephen Rothwell
2019-02-28  2:18 ` Alexei Starovoitov
2018-10-03  3:18 Stephen Rothwell
2018-10-03  5:29 ` Joe Stringer
2018-09-07  0:19 Stephen Rothwell
2018-09-07  0:22 ` Alexei Starovoitov
2018-09-07  5:21   ` Björn Töpel
2018-09-07  5:45     ` Alexei Starovoitov
2017-12-13  1:32 Stephen Rothwell
2017-12-13  1:47 ` Alexei Starovoitov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).