LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] mm: don't allow executable ioremap mappings
Date: Thu, 26 Aug 2021 07:37:19 +0200	[thread overview]
Message-ID: <20210826053719.GA17085@lst.de> (raw)
In-Reply-To: <1629945413.hwbzjjtfbl.astroid@bobo.none>

On Thu, Aug 26, 2021 at 12:46:34PM +1000, Nicholas Piggin wrote:
> I can't see why this is a problem. powerpcs can but it seems like a bad 
> idea anyway.
> 
> Any point to a WARN_ON or return -EINVAL? Hmm, maybe that doesn't work 
> for archs that don't support NX. We could add a check for ones that do 
> support it though... But that's for another patch.

This is the same as we do for regular vmap.  I can't remember why we
decided on this particular approach, as it's been a while.

      reply	other threads:[~2021-08-26  5:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  9:12 small ioremap cleanups Christoph Hellwig
2021-08-24  9:12 ` [PATCH 1/2] mm: move ioremap_page_range to vmalloc.c Christoph Hellwig
2021-08-24 19:51   ` kernel test robot
2021-08-26  2:36   ` Nicholas Piggin
2021-08-24  9:12 ` [PATCH 2/2] mm: don't allow executable ioremap mappings Christoph Hellwig
2021-08-26  2:46   ` Nicholas Piggin
2021-08-26  5:37     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210826053719.GA17085@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --subject='Re: [PATCH 2/2] mm: don'\''t allow executable ioremap mappings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).