LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Michal Koutný" <mkoutny@suse.com>
To: brookxu <brookxu.cn@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
	lizefan.x@bytedance.com, hannes@cmpxchg.org, vipinsh@google.com,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures
Date: Thu, 26 Aug 2021 13:29:54 +0200	[thread overview]
Message-ID: <20210826112954.GD4520@blackbody.suse.cz> (raw)
In-Reply-To: <4ed67493-e595-e002-69f9-1f53662ba189@gmail.com>

On Thu, Aug 26, 2021 at 09:34:45AM +0800, brookxu <brookxu.cn@gmail.com> wrote:
> The core logic of pids cgroup and misc cgroup is similar.

Yes, the latter is conceptually a generalization of the former and it can
be tempting to use the general form. Beware that pids controller would
need to retain its existing API (and the behavior of being an
independent controller) and that would be IMO exceptions
counterweighting the generalization.

> Is it possible for us to merge pids cgroup into misc cgroup?

Technically it might be possible but I can't see the benefit (but maybe
you envisioned something else where my reasoning won't apply).

Michal

  reply	other threads:[~2021-08-26 11:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14  0:15 brookxu
2021-08-14  1:16 ` Vipin Sharma
2021-08-24 16:44 ` Michal Koutný
2021-08-24 19:08   ` Tejun Heo
2021-08-25  6:50     ` brookxu
2021-08-26  1:34     ` brookxu
2021-08-26 11:29       ` Michal Koutný [this message]
2021-09-08  5:29         ` brookxu
2021-09-09 15:01           ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210826112954.GD4520@blackbody.suse.cz \
    --to=mkoutny@suse.com \
    --cc=brookxu.cn@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=tj@kernel.org \
    --cc=vipinsh@google.com \
    --subject='Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).