LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Isabella Basso <isabellabdoamaral@usp.br>,
	linux@sciencehorizons.net, geert@linux-m68k.org
Cc: kbuild-all@lists.01.org, ferreiraenzoa@gmail.com,
	augusto.duraes33@gmail.com, brendanhiggins@google.com,
	dlatypov@google.com, davidgow@google.com,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	kunit-dev@googlegroups.com
Subject: Re: [PATCH 6/6] test_hash.c: refactor into kunit
Date: Thu, 26 Aug 2021 14:00:14 +0800	[thread overview]
Message-ID: <202108261301.WGyZ8xI6-lkp@intel.com> (raw)
In-Reply-To: <20210826012626.1163705-7-isabellabdoamaral@usp.br>

[-- Attachment #1: Type: text/plain, Size: 3896 bytes --]

Hi Isabella,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc7 next-20210825]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Isabella-Basso/test_hash-c-refactor-into-KUnit/20210826-092911
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 73f3af7b4611d77bdaea303fb639333eb28e37d7
config: m68k-randconfig-r013-20210826 (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/89fe4c8eec63dcabd6d3e8f3f71f3c2248d18dab
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Isabella-Basso/test_hash-c-refactor-into-KUnit/20210826-092911
        git checkout 89fe4c8eec63dcabd6d3e8f3f71f3c2248d18dab
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   lib/test_hash.c: In function 'test_int_hash32':
>> lib/test_hash.c:62:50: warning: passing argument 1 of '__hash_32_generic' makes integer from pointer without a cast [-Wint-conversion]
      62 |         hash_or[1][0] |= *h2 = __hash_32_generic(h0);
         |                                                  ^~
         |                                                  |
         |                                                  u32 * {aka unsigned int *}
   In file included from lib/test_hash.c:18:
   include/linux/hash.h:60:41: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'u32 *' {aka 'unsigned int *'}
      60 | static inline u32 __hash_32_generic(u32 val)
         |                                     ~~~~^~~
   lib/test_hash.c:68:1: error: no return statement in function returning non-void [-Werror=return-type]
      68 | }
         | ^
   lib/test_hash.c: In function 'test_int_hash':
   lib/test_hash.c:110:24: error: 'return' with a value, in function returning void [-Werror=return-type]
     110 |                 return false;
         |                        ^~~~~
   lib/test_hash.c:97:13: note: declared here
      97 | static void test_int_hash(struct kunit *test, unsigned long long h64)
         |             ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/__hash_32_generic +62 lib/test_hash.c

468a9428521e7d00 George Spelvin 2016-05-26  58  
7d8047a5cceb3123 Isabella Basso 2021-08-25  59  #ifdef HAVE_ARCH__HASH_32
89fe4c8eec63dcab Isabella Basso 2021-08-25  60  static bool test_int_hash32(struct kunit *test, u32 *h0, u32 *h1, u32 *h2)
7d8047a5cceb3123 Isabella Basso 2021-08-25  61  {
7d8047a5cceb3123 Isabella Basso 2021-08-25 @62  	hash_or[1][0] |= *h2 = __hash_32_generic(h0);
7d8047a5cceb3123 Isabella Basso 2021-08-25  63  #if HAVE_ARCH__HASH_32 == 1
89fe4c8eec63dcab Isabella Basso 2021-08-25  64  	KUNIT_ASSERT_EQ_MSG(test, *h1, *h2,
89fe4c8eec63dcab Isabella Basso 2021-08-25  65  			    "__hash_32(%#x) = %#x != __hash_32_generic() = %#x",
7d8047a5cceb3123 Isabella Basso 2021-08-25  66  			    *h0, *h1, *h2);
7d8047a5cceb3123 Isabella Basso 2021-08-25  67  #endif
7d8047a5cceb3123 Isabella Basso 2021-08-25  68  }
7d8047a5cceb3123 Isabella Basso 2021-08-25  69  #endif
7d8047a5cceb3123 Isabella Basso 2021-08-25  70  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27762 bytes --]

  parent reply	other threads:[~2021-08-26  6:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26  1:26 [PATCH 0/6] test_hash.c: refactor into KUnit Isabella Basso
2021-08-26  1:26 ` [PATCH 1/6] hash.h: remove unused define directive Isabella Basso
2021-08-26  4:01   ` David Gow
2021-09-05 22:31     ` Isabella B do Amaral
2021-08-26  1:26 ` [PATCH 2/6] test_hash.c: move common definitions to top of file Isabella Basso
2021-08-26 14:36   ` Marco Elver
2021-09-05 22:40     ` Isabella B do Amaral
2021-08-26  1:26 ` [PATCH 3/6] test_hash.c: split test_int_hash into arch-specific functions Isabella Basso
2021-08-26  4:21   ` David Gow
2021-09-05 22:53     ` Isabella B do Amaral
2021-08-26  1:26 ` [PATCH 4/6] test_hash.c: split test_hash_init Isabella Basso
2021-08-26  1:26 ` [PATCH 5/6] lib/Kconfig.debug: properly split hash test kernel entries Isabella Basso
2021-08-26  1:26 ` [PATCH 6/6] test_hash.c: refactor into kunit Isabella Basso
2021-08-26  4:26   ` David Gow
2021-09-05 23:32     ` Isabella B do Amaral
2021-08-26  6:00   ` kernel test robot [this message]
2021-08-26 10:10   ` kernel test robot
2021-08-26  1:36 ` [PATCH 0/6] test_hash.c: refactor into KUnit Daniel Latypov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108261301.WGyZ8xI6-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=augusto.duraes33@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=ferreiraenzoa@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=isabellabdoamaral@usp.br \
    --cc=kbuild-all@lists.01.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@sciencehorizons.net \
    --subject='Re: [PATCH 6/6] test_hash.c: refactor into kunit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).