LKML Archive on
help / color / mirror / Atom feed
From: "F.A.Sulaiman" <>
Cc: "F.A.Sulaiman" <>,,
Subject: [PATCH] ATA:libata-pmp: fix warn: missing error code
Date: Thu, 26 Aug 2021 23:13:01 +0530	[thread overview]
Message-ID: <> (raw)

smatch reported 'sata_pmp_eh_recover() warn: missing error code 'rc''.
This patch resolve it by adding I/O error code to 'rc'.

Signed-off-by: F.A. SULAIMAN <>
 drivers/ata/libata-pmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index ba7be3f38617..2ea7b9986f4e 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -977,6 +977,7 @@ static int sata_pmp_eh_recover(struct ata_port *ap)
 				"failed to disable NOTIFY (err_mask=0x%x)\n",
+			rc = -EIO;
 			goto pmp_fail;

                 reply	other threads:[~2021-08-26 17:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] ATA:libata-pmp: fix warn: missing error code' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).