LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Adam Manzanares <a.manzanares@samsung.com>
Cc: "axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Make nvmet_init_cap dependent on passthru controller
Date: Thu, 26 Aug 2021 15:50:07 -0600	[thread overview]
Message-ID: <20210826215007.GA58085@C02WT3WMHTD6> (raw)
In-Reply-To: <20210826211522.308649-1-a.manzanares@samsung.com>

On Thu, Aug 26, 2021 at 09:15:45PM +0000, Adam Manzanares wrote:
> nvme_init_cap unconditionally sets support for one or more command sets. When
> using a passthru controller this may cause a conventional namespace to be
> ignored when checking the namespace identification descriptors which must
> include the command set identifier when the cap is set to support one or more
> command sets. Since the namespace identification descriptors come from the
> passthru controller they may not include the command set identifier causing the
> namespace to be ignored.
> 
> Adam Manzanares (2):
>   nvme: move nvme_multi_css into nvme.h
>   nvmet: use passthru cntrl in nvmet_init_cap

Looks good to me.

Reviewed-by: Keith Busch <kbusch@kernel.org>

      parent reply	other threads:[~2021-08-26 21:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210826211546uscas1p1fc876392e5aaf990eeb480cc74508852@uscas1p1.samsung.com>
2021-08-26 21:15 ` Adam Manzanares
     [not found]   ` <CGME20210826211546uscas1p2488ecd33269aa6f71f1fe8271fad3cec@uscas1p2.samsung.com>
2021-08-26 21:15     ` [PATCH 1/2] nvme: move nvme_multi_css into nvme.h Adam Manzanares
     [not found]   ` <CGME20210826211546uscas1p1e181ca820e506c7c195b933168301dd0@uscas1p1.samsung.com>
2021-08-26 21:15     ` [PATCH 2/2] nvmet: use passthru cntrl in nvmet_init_cap Adam Manzanares
2021-08-27  6:17       ` hch
2021-08-27 16:19         ` Adam Manzanares
2021-08-26 21:50   ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210826215007.GA58085@C02WT3WMHTD6 \
    --to=kbusch@kernel.org \
    --cc=a.manzanares@samsung.com \
    --cc=axboe@fb.com \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --subject='Re: [PATCH 0/2] Make nvmet_init_cap dependent on passthru controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).