From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32FCC4320A for ; Fri, 27 Aug 2021 18:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8750C60EFE for ; Fri, 27 Aug 2021 18:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbhH0SZz (ORCPT ); Fri, 27 Aug 2021 14:25:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:37702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhH0SZy (ORCPT ); Fri, 27 Aug 2021 14:25:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F60360E97; Fri, 27 Aug 2021 18:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630088705; bh=0eihSNf8es7K3C0a79CBft7H81KwqClcVqGKE0UUf04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r3PyBRg4sofODZCEjej7KHFoZXCVjj9rmLvZgi+o/u/j9NWWASRxONaVm6WqbLMhM UAgwNnfQwMo56SGKbrLl6mYvJkUmzZ24gCi3zXCJVQ4vOFCDv+M/RH4EjYXNwRFcS1 RmIUwtCAVjtoNwr+HqtiRv1SYGwzi1PdTshnhr7dYmyj7Hbo1mEVrH7qmCR96cjps1 ZylsQULgzSxblrYG9FbwqBQNosiSzd3GXqEDmu297zOcXb27VCF5zt8KukI+y4bywh N8w5f36qiglKvcCkdAu/25w6lpNVIWdYkSJjhvzb3CJb3KudmnLuDMxq8BIJ5mFHeE SiuTa77mkKKtw== Received: by pali.im (Postfix) id B7971617; Fri, 27 Aug 2021 20:25:02 +0200 (CEST) Date: Fri, 27 Aug 2021 20:25:02 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Miquel Raynal , Kishon Vijay Abraham I , Vinod Koul , Russell King , Andrew Lunn , Rob Herring , linux-phy@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] phy: marvell: phy-mvebu-a3700-comphy: Remove unsupported modes Message-ID: <20210827182502.vdapjcqimq4ulkg2@pali> References: <20210827092753.2359-1-pali@kernel.org> <20210827092753.2359-3-pali@kernel.org> <20210827132713.61ef86f0@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210827132713.61ef86f0@thinkpad> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 27 August 2021 13:27:13 Marek Behún wrote: > On Fri, 27 Aug 2021 11:27:53 +0200 > Pali Rohár wrote: > > > Armada 3700 does not support RXAUI, XFI and neither SFI. Remove unused > > macros for these unsupported modes. > > > > Signed-off-by: Pali Rohár > > Fixes: 9695375a3f4a ("phy: add A3700 COMPHY support") > > BTW I was thinking about merging some parts of these 2 drivers into > common code. Not entirely sure if I should follow, though. cp110-comphy and a3700-comphy are just RPC drivers which calls SMC and relay on firmware support which implements real work. And both uses same RPC / SMC API. So merging drivers into one is possible. But I do not think that it is a good idea that Linux kernel depends on some external firmware which implements RPC API for configuring HW. Rather kernel should implements its native drivers without dependency on external firmware. We know from history that kernel tried to avoid using x86 BIOS/firmware due to bugs and all functionality (re)-implemented itself without using firmware RPC functionality. Kernel has already "hacks" in other drivers which are using these comphy drivers, just because older versions of firmware do not support all necessary functionality and upgrading this firmware is not easy step (and sometimes even not possible; e.g. when is cryptographically signed).