From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9363C4320A for ; Mon, 30 Aug 2021 17:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C17B160ED6 for ; Mon, 30 Aug 2021 17:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238257AbhH3RhE (ORCPT ); Mon, 30 Aug 2021 13:37:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:50102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238117AbhH3RhD (ORCPT ); Mon, 30 Aug 2021 13:37:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 43AA760F3A; Mon, 30 Aug 2021 17:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630344969; bh=mBCLjTq+slwrTN0PgRGiG1Cp1vN3TjIt/HY5SniWLqQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hy9jp3yXzE1HgymdQKBR/PeDFaOgNrUzsLvzBVUFBRls/iFFxm3UdobZzNaGwIUp0 vajsKv1I/8925Q/dPpfxQFXnJ/JgUFigEjw+ue4fdEwSrjq8Mw5OAUGq22ODoYE1MK k3igzx6eYB46j+K3vbaUvs49Z8oSSWu8SdNQLoO0KtQw09cQblCGd2bK61sf+UrK5+ Tn2Iy9pk83qPZB9DGCturzWGZSKk2Fkd0yVCNw6RBbPb2THjVpH3uEmN+ckFO8Hx3d aahrWmRDgeWW0Wj8KbwMyaEn3fmTWnNeIMQF8rMZ7VyceT7/OuWky9zojOjkbB3SAA ckVewkbRHjLmA== Date: Mon, 30 Aug 2021 10:36:08 -0700 From: Jakub Kicinski To: CGEL Cc: Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Changcheng Deng , Zeal Robot Subject: Re: [PATCH linux-next] net: bonding: bond_alb: Replace if (cond) BUG() with BUG_ON() Message-ID: <20210830103608.5e0394f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210828010230.11022-1-deng.changcheng@zte.com.cn> References: <20210828010230.11022-1-deng.changcheng@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Aug 2021 18:02:30 -0700 CGEL wrote: > From: Changcheng Deng > > Fix the following coccinelle reports: > > ./drivers/net/bonding/bond_alb.c:976:3-6 WARNING: Use BUG_ON instead of > if condition followed by BUG. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > drivers/net/bonding/bond_alb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c > index 7d3752c..3288022 100644 > --- a/drivers/net/bonding/bond_alb.c > +++ b/drivers/net/bonding/bond_alb.c > @@ -972,8 +972,7 @@ static int alb_upper_dev_walk(struct net_device *upper, > */ > if (netif_is_macvlan(upper) && !strict_match) { > tags = bond_verify_device_path(bond->dev, upper, 0); > - if (IS_ERR_OR_NULL(tags)) > - BUG(); > + BUG_ON(IS_ERR_OR_NULL(tags)); > alb_send_lp_vid(slave, upper->dev_addr, > tags[0].vlan_proto, tags[0].vlan_id); > kfree(tags); The fact this code using is BUG() in the first place is more problematic than not using BUG_ON(). Can it be converted to WARN_ON() + return? Looks like alb_upper_dev_walk() returns int.