LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
@ 2021-08-30 1:24 zhaoxiao
2021-08-30 18:26 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: zhaoxiao @ 2021-08-30 1:24 UTC (permalink / raw)
To: davem, kuba, mcoquelin.stm32
Cc: peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, zhaoxiao
Change the pr_info to dev_err.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
v2: Remove the adding a return.
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..abcb55f87579 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -54,14 +54,13 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
bool mdio = false;
np = dev_of_node(&pdev->dev);
-
if (!np) {
- pr_info("dwmac_loongson_pci: No OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
return -ENODEV;
}
if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
- pr_info("dwmac_loongson_pci: Incompatible OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
return -ENODEV;
}
@@ -69,6 +68,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
if (!plat)
return -ENOMEM;
+
if (plat->mdio_node) {
dev_err(&pdev->dev, "Found MDIO subnode\n");
mdio = true;
@@ -111,6 +111,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
phy_mode = device_get_phy_mode(&pdev->dev);
if (phy_mode < 0)
dev_err(&pdev->dev, "phy_mode not found\n");
+
plat->phy_interface = phy_mode;
plat->interface = PHY_INTERFACE_MODE_GMII;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
2021-08-30 1:24 [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() zhaoxiao
@ 2021-08-30 18:26 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-08-30 18:26 UTC (permalink / raw)
To: zhaoxiao
Cc: davem, mcoquelin.stm32, peppe.cavallaro, alexandre.torgue,
joabreu, netdev, linux-stm32, linux-arm-kernel, linux-kernel
On Mon, 30 Aug 2021 09:24:17 +0800 zhaoxiao wrote:
> @@ -69,6 +68,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> if (!plat)
> return -ENOMEM;
>
> +
> if (plat->mdio_node) {
> dev_err(&pdev->dev, "Found MDIO subnode\n");
> mdio = true;
> @@ -111,6 +111,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> phy_mode = device_get_phy_mode(&pdev->dev);
> if (phy_mode < 0)
> dev_err(&pdev->dev, "phy_mode not found\n");
> +
>
> plat->phy_interface = phy_mode;
> plat->interface = PHY_INTERFACE_MODE_GMII;
Please remove these changes from the patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-30 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 1:24 [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() zhaoxiao
2021-08-30 18:26 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).