LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mingwei Zhang <mizhang@google.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sean Christopherson <seanjc@google.com>,
	David Matlack <dmatlack@google.com>,
	Jing Zhang <jingzhangos@google.com>, Peter Xu <peterx@redhat.com>,
	Ben Gardon <bgardon@google.com>,
	Mingwei Zhang <mizhang@google.com>
Subject: Re: [PATCH v2 2/2] selftests: KVM: use dirty logging to check if page stats work correctly
Date: Mon, 30 Aug 2021 12:02:20 +0800	[thread overview]
Message-ID: <202108301131.HmLTqoX4-lkp@intel.com> (raw)
In-Reply-To: <20210829182641.2505220-3-mizhang@google.com>

[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]

Hi Mingwei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kvm/queue]
[also build test ERROR on vhost/linux-next linux/master linus/master v5.14 next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mingwei-Zhang/selftests-verify-page-stats-in-kvm-x86-mmu/20210830-022817
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/0fafdf6b378c081631b13e89a550992c2ddcfd4a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mingwei-Zhang/selftests-verify-page-stats-in-kvm-x86-mmu/20210830-022817
        git checkout 0fafdf6b378c081631b13e89a550992c2ddcfd4a
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash -C tools/testing/selftests install

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   dirty_log_perf_test.c: In function 'run_test':
>> dirty_log_perf_test.c:236:28: error: macro "TEST_ASSERT" requires 3 arguments, but only 1 given
     236 |    "2M page number is zero");
         |                            ^
   In file included from include/kvm_util.h:10,
                    from dirty_log_perf_test.c:17:
   include/test_util.h:46: note: macro "TEST_ASSERT" defined here
      46 | #define TEST_ASSERT(e, fmt, ...) \
         | 
>> dirty_log_perf_test.c:235:3: error: 'TEST_ASSERT' undeclared (first use in this function)
     235 |   TEST_ASSERT(get_page_stats(X86_PAGE_SIZE_2M) > 0
         |   ^~~~~~~~~~~
   dirty_log_perf_test.c:235:3: note: each undeclared identifier is reported only once for each function it appears in

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42149 bytes --]

  reply	other threads:[~2021-08-30  4:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 18:26 [PATCH v2 0/2] selftests: verify page stats in kvm x86/mmu Mingwei Zhang
2021-08-29 18:26 ` [PATCH v2 1/2] selftests: KVM: align guest physical memory base address to 1GB Mingwei Zhang
2021-08-31 16:54   ` Sean Christopherson
2021-09-06 19:56     ` Mingwei Zhang
2021-08-29 18:26 ` [PATCH v2 2/2] selftests: KVM: use dirty logging to check if page stats work correctly Mingwei Zhang
2021-08-30  4:02   ` kernel test robot [this message]
2021-08-30  4:42     ` Mingwei Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108301131.HmLTqoX4-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bgardon@google.com \
    --cc=dmatlack@google.com \
    --cc=jingzhangos@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mizhang@google.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=seanjc@google.com \
    --subject='Re: [PATCH v2 2/2] selftests: KVM: use dirty logging to check if page stats work correctly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).