LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Luke D. Jones" <luke@ljones.dev>
To: linux-kernel@vger.kernel.org
Cc: hdegoede@redhat.com, pobrn@protonmail.com, linux@roeck-us.net,
platform-driver-x86@vger.kernel.org,
"Luke D. Jones" <luke@ljones.dev>
Subject: [PATCH v7 0/1] asus-wmi: Add support for custom fan curves
Date: Mon, 30 Aug 2021 23:31:36 +1200 [thread overview]
Message-ID: <20210830113137.1338683-1-luke@ljones.dev> (raw)
Add support for custom fan curves found on some ASUS ROG laptops.
- V1
+ Initial patch work
- V2
+ Don't fail and remove wmi driver if error from
asus_wmi_evaluate_method_buf() if error is -ENODEV
- V3
+ Store the "default" fan curves
+ Call throttle_thermal_policy_write() if a curve is erased to ensure
that the factory default for a profile is applied again
- V4
+ Do not apply default curves by default. Testers have found that the
default curves don't quite match actual no-curve behaviours
+ Add method to enable/disable curves for each profile
- V5
+ Remove an unrequired function left over from previous iterations
+ Ensure default curves are applied if user writes " " to a curve path
+ Rename "active_fan_curve_profiles" to "enabled_fan_curve_profiles" to
better reflect the behavious of this setting
+ Move throttle_thermal_policy_write_*pu_curves() and rename to
fan_curve_*pu_write()
+ Merge fan_curve_check_valid() and fan_curve_write()
+ Remove some leftover debug statements
- V6
+ Refactor data structs to store array or u8 instead of strings.
This affects the entire patch except the enabled_fan_curves block
+ Use sysfs_match_string in enabled_fan_curve block
+ Add some extra comments to describe things
+ Allow some variation in how fan curve input can be formatted
+ Use SENSOR_DEVICE_ATTR_2_RW() to reduce the amount of lines per
fan+profile combo drastically
- V7
+ Further refactor to use pwm1_auto_point1_temp + pwm1_auto_point1_pwm
format, creating two blocks of attributes for CPU and GPU fans
+ Remove storing of defualt curves and method to reset them. The
factory defaults are still populated in to structs on module load
so users have a starting point
Luke D. Jones (1):
asus-wmi: Add support for custom fan curves
drivers/platform/x86/asus-wmi.c | 602 ++++++++++++++++++++-
include/linux/platform_data/x86/asus-wmi.h | 2 +
2 files changed, 600 insertions(+), 4 deletions(-)
--
2.31.1
next reply other threads:[~2021-08-30 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 11:31 Luke D. Jones [this message]
2021-08-30 11:31 ` [PATCH v7] " Luke D. Jones
2021-08-30 21:28 ` Barnabás Pőcze
2021-08-30 23:51 ` Luke Jones
2021-09-01 15:24 ` Barnabás Pőcze
2021-09-01 22:01 ` Luke Jones
2021-09-02 15:55 ` Hans de Goede
2021-08-31 8:58 ` Luke Jones
2021-08-31 9:56 ` Luke Jones
2021-09-01 14:39 ` Barnabás Pőcze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830113137.1338683-1-luke@ljones.dev \
--to=luke@ljones.dev \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--subject='Re: [PATCH v7 0/1] asus-wmi: Add support for custom fan curves' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).