LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
@ 2021-08-30 15:16 Clément Bœsch
  2021-08-30 20:49 ` Jernej Škrabec
  2021-08-30 21:52 ` [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Andrew Lunn
  0 siblings, 2 replies; 13+ messages in thread
From: Clément Bœsch @ 2021-08-30 15:16 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec
  Cc: Willy Liu, Rob Herring, David S. Miller, Andrew Lunn,
	linux-arm-kernel, linux-sunxi, linux-kernel,
	Clément Bœsch

Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") network is broken on the NanoPi Neo 2.

This patch changes the phy-mode to use internal delays both for RX and
TX as has been done for other boards affected by the same commit.

Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
Signed-off-by: Clément Bœsch <u@pkh.me>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
index 02f8e72f0cad..05486cccee1c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
@@ -75,7 +75,7 @@ &emac {
 	pinctrl-0 = <&emac_rgmii_pins>;
 	phy-supply = <&reg_gmac_3v3>;
 	phy-handle = <&ext_rgmii_phy>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
 
-- 
2.33.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-30 15:16 [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Clément Bœsch
@ 2021-08-30 20:49 ` Jernej Škrabec
  2021-08-30 21:25   ` Clément Bœsch
                     ` (2 more replies)
  2021-08-30 21:52 ` [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Andrew Lunn
  1 sibling, 3 replies; 13+ messages in thread
From: Jernej Škrabec @ 2021-08-30 20:49 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Clément Bœsch
  Cc: Willy Liu, Rob Herring, David S. Miller, Andrew Lunn,
	linux-arm-kernel, linux-sunxi, linux-kernel,
	Clément Bœsch

Hi!

Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch napisal(a):
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") network is broken on the NanoPi Neo 2.
> 
> This patch changes the phy-mode to use internal delays both for RX and
> TX as has been done for other boards affected by the same commit.
> 
> Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")

This commit fixes DT issue, so "fixes" tag should be:
Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")

Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board DT.  

Other than that, this patch is fine and once fixes tag is fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

For next version, you should:
- change fixed tag
- add my review-by tag right above your signed-off-by tag
- mark patch as v2 (add "-v2" parameter to git format-patch)
- describe change right under "---" line

Note, if you borked something when sending, you should mark patch or patch 
series as "RESEND", so recipients don't look for changes in two subsequent e-
mails (--subject-prefix="RESEND PATCH").

Thanks for the fix!

Best regards,
Jernej

> Signed-off-by: Clément Bœsch <u@pkh.me>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts index
> 02f8e72f0cad..05486cccee1c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> @@ -75,7 +75,7 @@ &emac {
>  	pinctrl-0 = <&emac_rgmii_pins>;
>  	phy-supply = <&reg_gmac_3v3>;
>  	phy-handle = <&ext_rgmii_phy>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  	status = "okay";
>  };





^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-30 20:49 ` Jernej Škrabec
@ 2021-08-30 21:25   ` Clément Bœsch
  2021-08-31 20:17     ` Jernej Škrabec
  2021-08-30 21:50   ` Andrew Lunn
  2021-09-05  0:20   ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
  2 siblings, 1 reply; 13+ messages in thread
From: Clément Bœsch @ 2021-08-30 21:25 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Maxime Ripard, Chen-Yu Tsai, Willy Liu, Rob Herring,
	David S. Miller, Andrew Lunn, linux-arm-kernel, linux-sunxi,
	linux-kernel

On Mon, Aug 30, 2021 at 10:49:37PM +0200, Jernej Škrabec wrote:
> Hi!
> 

Hi,

> Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch napisal(a):
> > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") network is broken on the NanoPi Neo 2.
> > 
> > This patch changes the phy-mode to use internal delays both for RX and
> > TX as has been done for other boards affected by the same commit.
> > 
> > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> 
> This commit fixes DT issue, so "fixes" tag should be:
> Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> 
> Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board DT.  

Shouldn't I add it instead of replacing? I followed what I observed in
`git log --grep bbc4d71d63` where all the commits pretty much follow this
pattern: that commit is the one causing the actual observed regression,
while 44a94c7ef989 is much older, and while it's wrong, it wasn't causing
an issue in practice.

Or did I misunderstand something?

> Other than that, this patch is fine and once fixes tag is fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> 
> For next version, you should:
> - change fixed tag
> - add my review-by tag right above your signed-off-by tag
> - mark patch as v2 (add "-v2" parameter to git format-patch)
> - describe change right under "---" line
> 

Will do.

> Note, if you borked something when sending, you should mark patch or patch 
> series as "RESEND", so recipients don't look for changes in two subsequent e-
> mails (--subject-prefix="RESEND PATCH").

Not sure I follow you so before I disturb everyone with more noise I'd
just like to confirm: you mean a git send-email in-reply-to=[broken patch
attempt] (the one where I borked the --cc), right? But with what patch?
I'm a bit confused here.

> Thanks for the fix!

No problem; I really think a scan of all the other boards would be
meaningful though, it looks like a lot of them got fixed but there are
many other candidates and the issue feels pretty critical to me
(regression, and no network at all).

-- 
Clément B.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-30 20:49 ` Jernej Škrabec
  2021-08-30 21:25   ` Clément Bœsch
@ 2021-08-30 21:50   ` Andrew Lunn
  2021-08-31 19:53     ` Jernej Škrabec
  2021-09-05  0:20   ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
  2 siblings, 1 reply; 13+ messages in thread
From: Andrew Lunn @ 2021-08-30 21:50 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Maxime Ripard, Chen-Yu Tsai, Clément Bœsch, Willy Liu,
	Rob Herring, David S. Miller, linux-arm-kernel, linux-sunxi,
	linux-kernel

On Mon, Aug 30, 2021 at 10:49:37PM +0200, Jernej Škrabec wrote:
> Hi!
> 
> Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch napisal(a):
> > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") network is broken on the NanoPi Neo 2.
> > 
> > This patch changes the phy-mode to use internal delays both for RX and
> > TX as has been done for other boards affected by the same commit.
> > 
> > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> 
> This commit fixes DT issue, so "fixes" tag should be:
> Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> 
> Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board DT.  

Hi Jernej

I would say, it is debatable. The board broke when the driver started
acting on the value, which is commit bbc4d71d6354. It could be argued
it was always technically broken, since it has the wrong value, but
practically, it was not broken. One of the rules for stable is:

 - It must fix a real bug that bothers people (not a, "This could be a
   problem..." type thing).

So i would argue, anything before bbc4d71d6354 does not fulfil stable
requirements, since it does not bother anybody.

      Andrew

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-30 15:16 [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Clément Bœsch
  2021-08-30 20:49 ` Jernej Škrabec
@ 2021-08-30 21:52 ` Andrew Lunn
  1 sibling, 0 replies; 13+ messages in thread
From: Andrew Lunn @ 2021-08-30 21:52 UTC (permalink / raw)
  To: Clément Bœsch
  Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, Willy Liu,
	Rob Herring, David S. Miller, linux-arm-kernel, linux-sunxi,
	linux-kernel

On Mon, Aug 30, 2021 at 05:16:45PM +0200, Clément Bœsch wrote:
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") network is broken on the NanoPi Neo 2.
> 
> This patch changes the phy-mode to use internal delays both for RX and
> TX as has been done for other boards affected by the same commit.
> 
> Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> Signed-off-by: Clément Bœsch <u@pkh.me>

Cc: stable@vger.kernel.org
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-30 21:50   ` Andrew Lunn
@ 2021-08-31 19:53     ` Jernej Škrabec
  2021-08-31 20:53       ` Andrew Lunn
  0 siblings, 1 reply; 13+ messages in thread
From: Jernej Škrabec @ 2021-08-31 19:53 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Maxime Ripard, Chen-Yu Tsai, Clément Bœsch, Willy Liu,
	Rob Herring, David S. Miller, linux-arm-kernel, linux-sunxi,
	linux-kernel

Hi Andrew!

Dne ponedeljek, 30. avgust 2021 ob 23:50:42 CEST je Andrew Lunn napisal(a):
> On Mon, Aug 30, 2021 at 10:49:37PM +0200, Jernej Škrabec wrote:
> > Hi!
> > 
> > Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch 
napisal(a):
> > > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > > config") network is broken on the NanoPi Neo 2.
> > > 
> > > This patch changes the phy-mode to use internal delays both for RX and
> > > TX as has been done for other boards affected by the same commit.
> > > 
> > > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > 
> > This commit fixes DT issue, so "fixes" tag should be:
> > Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> > 
> > Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board 
DT.  
> 
> Hi Jernej
> 
> I would say, it is debatable. The board broke when the driver started
> acting on the value, which is commit bbc4d71d6354. It could be argued
> it was always technically broken, since it has the wrong value, but
> practically, it was not broken. One of the rules for stable is:
> 
>  - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).
> 
> So i would argue, anything before bbc4d71d6354 does not fulfil stable
> requirements, since it does not bother anybody.

True, but then again, DT is a bit special, since it's not used only by Linux. 
It's shared at least with BSDs and U-Boot, which most likely have independent 
driver implementation. That's why it's good to have DT fixes referencing DT 
related commits. As you said, DT described HW wrong.

Looking at past Allwinner related DT commits regarding this issue, we were not 
totally consistent. Most of them reference commit where emac node was 
introduced in DT. But I also found a couple of commits which indeed have fixes 
tag for bbc4d71d6354.

Best regards,
Jernej

> 
>       Andrew
> 



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-30 21:25   ` Clément Bœsch
@ 2021-08-31 20:17     ` Jernej Škrabec
  0 siblings, 0 replies; 13+ messages in thread
From: Jernej Škrabec @ 2021-08-31 20:17 UTC (permalink / raw)
  To: Clément Bœsch
  Cc: Maxime Ripard, Chen-Yu Tsai, Willy Liu, Rob Herring,
	David S. Miller, Andrew Lunn, linux-arm-kernel, linux-sunxi,
	linux-kernel

Hi!

Dne ponedeljek, 30. avgust 2021 ob 23:25:23 CEST je Clément Bœsch napisal(a):
> On Mon, Aug 30, 2021 at 10:49:37PM +0200, Jernej Škrabec wrote:
> > Hi!
> > 
> 
> Hi,
> 
> > Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch 
napisal(a):
> > > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > > config") network is broken on the NanoPi Neo 2.
> > > 
> > > This patch changes the phy-mode to use internal delays both for RX and
> > > TX as has been done for other boards affected by the same commit.
> > > 
> > > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > 
> > This commit fixes DT issue, so "fixes" tag should be:
> > Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> > 
> > Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board 
DT.  
> 
> Shouldn't I add it instead of replacing? I followed what I observed in
> `git log --grep bbc4d71d63` where all the commits pretty much follow this
> pattern: that commit is the one causing the actual observed regression,
> while 44a94c7ef989 is much older, and while it's wrong, it wasn't causing
> an issue in practice.
> 
> Or did I misunderstand something?

With that grep command you limited yourself only to those commits which 
reference this particular commit. There are others, which also change "rgmii" 
to "rgmii-id" and reference other commits, like:
544cc3f8573b ("arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet")
97a38c1c213b ("arm64: dts: allwinner: beelink-gs1: Enable both RGMII RX/TX 
delay")
(there are more).

Anyway, let's continue this discussion in Andrew's thread.

> 
> > Other than that, this patch is fine and once fixes tag is fixed, you can add:
> > Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > 
> > For next version, you should:
> > - change fixed tag
> > - add my review-by tag right above your signed-off-by tag
> > - mark patch as v2 (add "-v2" parameter to git format-patch)
> > - describe change right under "---" line
> > 
> 
> Will do.

Please wait until discussion reaches a conclusion.

> 
> > Note, if you borked something when sending, you should mark patch or patch 
> > series as "RESEND", so recipients don't look for changes in two subsequent 
e-
> > mails (--subject-prefix="RESEND PATCH").
> 
> Not sure I follow you so before I disturb everyone with more noise I'd
> just like to confirm: you mean a git send-email in-reply-to=[broken patch
> attempt] (the one where I borked the --cc), right? But with what patch?
> I'm a bit confused here.

That's just for the future reference. No need to do anything now for this 
patch. If you bork any send attempt in the future, recreate same patch(es) 
with this additional tag ("RESEND") and send them again.

> 
> > Thanks for the fix!
> 
> No problem; I really think a scan of all the other boards would be
> meaningful though, it looks like a lot of them got fixed but there are
> many other candidates and the issue feels pretty critical to me
> (regression, and no network at all).

I guess you speak for all boards, not just those with Allwinner SoC? I fixed as 
many boards as I have - testing is very desired. On some boards rgmii was 
changed to rgmii-txid, so it's not as straightforward as search and replace. 
It could be also deducted from schematics, but at least one Allwinner board 
has this configured in HW wrong (SW fix was needed for that board) and other 
boards might not have schematics publicy available.

In short, I wouldn't start mass generating patches for this.

Best regards,
Jernej

> 
> -- 
> Clément B.
> 



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-31 19:53     ` Jernej Škrabec
@ 2021-08-31 20:53       ` Andrew Lunn
  2021-09-01 15:31         ` Jernej Škrabec
  0 siblings, 1 reply; 13+ messages in thread
From: Andrew Lunn @ 2021-08-31 20:53 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Maxime Ripard, Chen-Yu Tsai, Clément Bœsch, Willy Liu,
	Rob Herring, David S. Miller, linux-arm-kernel, linux-sunxi,
	linux-kernel

> True, but then again, DT is a bit special, since it's not used only by Linux. 
> It's shared at least with BSDs and U-Boot, which most likely have independent 
> driver implementation. That's why it's good to have DT fixes referencing DT 
> related commits. As you said, DT described HW wrong.
> 
> Looking at past Allwinner related DT commits regarding this issue, we were not 
> totally consistent. Most of them reference commit where emac node was 
> introduced in DT. But I also found a couple of commits which indeed have fixes 
> tag for bbc4d71d6354.

All true, and it is not a big deal if it does go back further. I don't
care, we can let the Allwinner Maintainer decide. Ah, that is you :-)

I just want to try to keep it simple for somebody who is contributing
their first Linux kernel patch. If it is good enough, i say accept it,
and we can do a bit more education on the second contribution.

    Andre

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-08-31 20:53       ` Andrew Lunn
@ 2021-09-01 15:31         ` Jernej Škrabec
  2021-09-03  9:21           ` Maxime Ripard
  0 siblings, 1 reply; 13+ messages in thread
From: Jernej Škrabec @ 2021-09-01 15:31 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Maxime Ripard, Chen-Yu Tsai, Clément Bœsch, Willy Liu,
	Rob Herring, David S. Miller, linux-arm-kernel, linux-sunxi,
	linux-kernel

Dne torek, 31. avgust 2021 ob 22:53:24 CEST je Andrew Lunn napisal(a):
> > True, but then again, DT is a bit special, since it's not used only by 
Linux. 
> > It's shared at least with BSDs and U-Boot, which most likely have 
independent 
> > driver implementation. That's why it's good to have DT fixes referencing DT 
> > related commits. As you said, DT described HW wrong.
> > 
> > Looking at past Allwinner related DT commits regarding this issue, we were 
not 
> > totally consistent. Most of them reference commit where emac node was 
> > introduced in DT. But I also found a couple of commits which indeed have 
fixes 
> > tag for bbc4d71d6354.
> 
> All true, and it is not a big deal if it does go back further. I don't
> care, we can let the Allwinner Maintainer decide. Ah, that is you :-)
> 
> I just want to try to keep it simple for somebody who is contributing
> their first Linux kernel patch. If it is good enough, i say accept it,
> and we can do a bit more education on the second contribution.

Maxime, Chen-Yu, thoughts?

Since there are both approaches for fixes tag already in, I guess this is also 
fine.

Best regards,
Jernej





^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
  2021-09-01 15:31         ` Jernej Škrabec
@ 2021-09-03  9:21           ` Maxime Ripard
  0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2021-09-03  9:21 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Andrew Lunn, Chen-Yu Tsai, Clément Bœsch, Willy Liu,
	Rob Herring, David S. Miller, linux-arm-kernel, linux-sunxi,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

On Wed, Sep 01, 2021 at 05:31:32PM +0200, Jernej Škrabec wrote:
> Dne torek, 31. avgust 2021 ob 22:53:24 CEST je Andrew Lunn napisal(a):
> > > True, but then again, DT is a bit special, since it's not used only by 
> Linux. 
> > > It's shared at least with BSDs and U-Boot, which most likely have 
> independent 
> > > driver implementation. That's why it's good to have DT fixes referencing DT 
> > > related commits. As you said, DT described HW wrong.
> > > 
> > > Looking at past Allwinner related DT commits regarding this issue, we were 
> not 
> > > totally consistent. Most of them reference commit where emac node was 
> > > introduced in DT. But I also found a couple of commits which indeed have 
> fixes 
> > > tag for bbc4d71d6354.
> > 
> > All true, and it is not a big deal if it does go back further. I don't
> > care, we can let the Allwinner Maintainer decide. Ah, that is you :-)
> > 
> > I just want to try to keep it simple for somebody who is contributing
> > their first Linux kernel patch. If it is good enough, i say accept it,
> > and we can do a bit more education on the second contribution.
> 
> Maxime, Chen-Yu, thoughts?
> 
> Since there are both approaches for fixes tag already in, I guess this is also 
> fine.

I agree with you, the fixes should point at the initial Device Tree
issue. Our DT are used by other projects and even if in Linux it wasn't
causing any issue before another commit showed up, it might affect those
projects differently.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node
  2021-08-30 20:49 ` Jernej Škrabec
  2021-08-30 21:25   ` Clément Bœsch
  2021-08-30 21:50   ` Andrew Lunn
@ 2021-09-05  0:20   ` Clément Bœsch
  2021-09-05  0:42     ` Andrew Lunn
  2021-09-06  8:03     ` Maxime Ripard
  2 siblings, 2 replies; 13+ messages in thread
From: Clément Bœsch @ 2021-09-05  0:20 UTC (permalink / raw)
  To: jernej.skrabec
  Cc: andrew, davem, linux-arm-kernel, linux-kernel, linux-sunxi,
	mripard, robh+dt, u, wens, willy.liu

RX and TX delay are provided by ethernet PHY. Reflect that in ethernet
node.

Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
Signed-off-by: Clément Bœsch <u@pkh.me>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
Reword the commit message and description (in particular, refer to the
DT hash instead of the kernel network commit).
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
index 02f8e72f0cad..05486cccee1c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
@@ -75,7 +75,7 @@ &emac {
 	pinctrl-0 = <&emac_rgmii_pins>;
 	phy-supply = <&reg_gmac_3v3>;
 	phy-handle = <&ext_rgmii_phy>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
 
-- 
2.33.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node
  2021-09-05  0:20   ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
@ 2021-09-05  0:42     ` Andrew Lunn
  2021-09-06  8:03     ` Maxime Ripard
  1 sibling, 0 replies; 13+ messages in thread
From: Andrew Lunn @ 2021-09-05  0:42 UTC (permalink / raw)
  To: Clément Bœsch
  Cc: jernej.skrabec, davem, linux-arm-kernel, linux-kernel,
	linux-sunxi, mripard, robh+dt, wens, willy.liu

On Sun, Sep 05, 2021 at 02:20:27AM +0200, Clément Bœsch wrote:
> RX and TX delay are provided by ethernet PHY. Reflect that in ethernet
> node.
> 
> Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> Signed-off-by: Clément Bœsch <u@pkh.me>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node
  2021-09-05  0:20   ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
  2021-09-05  0:42     ` Andrew Lunn
@ 2021-09-06  8:03     ` Maxime Ripard
  1 sibling, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2021-09-06  8:03 UTC (permalink / raw)
  To: Clément Bœsch
  Cc: jernej.skrabec, andrew, davem, linux-arm-kernel, linux-kernel,
	linux-sunxi, robh+dt, wens, willy.liu

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

On Sun, Sep 05, 2021 at 02:20:27AM +0200, Clément Bœsch wrote:
> RX and TX delay are provided by ethernet PHY. Reflect that in ethernet
> node.
> 
> Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes")
> Signed-off-by: Clément Bœsch <u@pkh.me>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Applied, thanks
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-09-06  8:03 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 15:16 [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Clément Bœsch
2021-08-30 20:49 ` Jernej Škrabec
2021-08-30 21:25   ` Clément Bœsch
2021-08-31 20:17     ` Jernej Škrabec
2021-08-30 21:50   ` Andrew Lunn
2021-08-31 19:53     ` Jernej Škrabec
2021-08-31 20:53       ` Andrew Lunn
2021-09-01 15:31         ` Jernej Škrabec
2021-09-03  9:21           ` Maxime Ripard
2021-09-05  0:20   ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
2021-09-05  0:42     ` Andrew Lunn
2021-09-06  8:03     ` Maxime Ripard
2021-08-30 21:52 ` [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).