LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Roger Knecht <roger@norberthealth.com>
Cc: Jiri Kosina <jkosina@suse.cz>, Jiri Kosina <trivial@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2] Trivial comment fix for the CRC ITU-T polynom
Date: Mon, 30 Aug 2021 21:57:14 +0300	[thread overview]
Message-ID: <20210830185714.GK12231@kadam> (raw)
In-Reply-To: <20210830163324.12537-1-roger@norberthealth.com>

On Mon, Aug 30, 2021 at 06:33:24PM +0200, Roger Knecht wrote:
> This patch fixes a small typo in the CRC ITU-T polynom documentation.
> 
> The code comment says that the polynom is x^16 + x^12 + x^15 + 1, but the
> correct polynom is x^16 + x^12 + x^5 + 1.
> 
> Quote from page 2 in the ITU-T V.41 specification:
>   "2 Encoding and checking process
> 
>   The service bits and information bits, taken in conjunction, correspond
>   to the coefficients of a message polynomial having terms from x^(n-1) 
>   (n = total number of bits in a block or sequence) down to x^16. This 
>   polynomial is divided, modulo 2, by the generating polynomial 
>   x^16 + x^12 + x^5 + 1. [...]"
> 
> Source: https://www.itu.int/rec/T-REC-V.41-198811-I/en)
> 
> The hex polynom 0x1021 and CRC code implementation are correct.
> 
> Changes for the resend:
>   - Extended patch description
>   - Added additional CCs
> 
> Thanks,
> Roger

Hi Roger,

Can you put the Changes and the "Thanks" part of the email after ...

> 
> Signed-off-by: Roger Knecht <roger@norberthealth.com>
> ---
  ^^^

... this cut off line so that they are not included in the final git
log.  These patches are applied with `cat raw_email.txt | git am -s` if
you want to test how it works yourself.

regards,
dan carpenter

  reply	other threads:[~2021-08-30 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 16:33 Roger Knecht
2021-08-30 18:57 ` Dan Carpenter [this message]
2021-08-31 12:45   ` Roger Knecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830185714.GK12231@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=corbet@lwn.net \
    --cc=jkosina@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger@norberthealth.com \
    --cc=trivial@kernel.org \
    --subject='Re: [PATCH RESEND v2] Trivial comment fix for the CRC ITU-T polynom' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).